From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753651AbcJNPSj (ORCPT <rfc822;w@1wt.eu>);
        Fri, 14 Oct 2016 11:18:39 -0400
Received: from mail-wm0-f44.google.com ([74.125.82.44]:38107 "EHLO
        mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752843AbcJNPSc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 14 Oct 2016 11:18:32 -0400
Date: Fri, 14 Oct 2016 17:18:27 +0200
From: Vincent Guittot <vincent.guittot@linaro.org>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Joseph Salisbury <joseph.salisbury@canonical.com>,
        Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, Mike Galbraith <efault@gmx.de>
Subject: Re: [v4.8-rc1 Regression] sched/fair: Apply more PELT fixes
Message-ID: <20161014151827.GA10379@linaro.org>
References: <1475927349.5573.1.camel@gmx.de>
 <CAKfTPtDo7PsZjDSH4KteyCJ=yq63Ha5iwkucjRTvtP_J3o=MKw@mail.gmail.com>
 <57FE6302.6060103@canonical.com>
 <CAKfTPtDLLzt2s0_p2uw3dt8MRH0o8_Tus6P5Uze+6gBHFm-rVg@mail.gmail.com>
 <57FFADC8.2020602@canonical.com>
 <CAKfTPtDU+DmF4iLwHWF2jEnZCjPUXBOu9c6Zqh4+kQPMio39nQ@mail.gmail.com>
 <43c59cba-2044-1de2-0f78-8f346bd1e3cb@arm.com>
 <CAKfTPtAo=E62XK8kTrrCp1NbxQbhJeYFEoxfTEHvdKTyVZODbQ@mail.gmail.com>
 <CAKfTPtADw=JChCccEQ+HohaYwbOCh3QuWOFrGJdGudOHCD8-OA@mail.gmail.com>
 <d0b0e00d-2892-6386-3e09-8df568e161ef@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d0b0e00d-2892-6386-3e09-8df568e161ef@arm.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Le Friday 14 Oct 2016 à 14:10:07 (+0100), Dietmar Eggemann a écrit :
> On 14/10/16 09:24, Vincent Guittot wrote:
> > On 13 October 2016 at 23:34, Vincent Guittot <vincent.guittot@linaro.org> wrote:
> >> On 13 October 2016 at 20:49, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
> >>> On 13/10/16 17:48, Vincent Guittot wrote:
> >>>> On 13 October 2016 at 17:52, Joseph Salisbury
> >>>> <joseph.salisbury@canonical.com> wrote:
> >>>>> On 10/13/2016 06:58 AM, Vincent Guittot wrote:
> >>>>>> Hi,
> >>>>>>
> >>>>>> On 12 October 2016 at 18:21, Joseph Salisbury
> >>>>>> <joseph.salisbury@canonical.com> wrote:
> >>>>>>> On 10/12/2016 08:20 AM, Vincent Guittot wrote:
> >>>>>>>> On 8 October 2016 at 13:49, Mike Galbraith <efault@gmx.de> wrote:
> >>>>>>>>> On Sat, 2016-10-08 at 13:37 +0200, Vincent Guittot wrote:
> >>>>>>>>>> On 8 October 2016 at 10:39, Ingo Molnar <mingo@kernel.org> wrote:
> >>>>>>>>>>> * Peter Zijlstra <peterz@infradead.org> wrote:
> >>>>>>>>>>>
> >>>>>>>>>>>> On Fri, Oct 07, 2016 at 03:38:23PM -0400, Joseph Salisbury wrote:
> 
> [...]
> 
> >>> When I create a tg_root/tg_x/tg_y_1 and a tg_root/tg_x/tg_y_2 group, the tg_x->load_avg
> >>> becomes > 6*1024 before any tasks ran in it.
> >>
> >> This is normal as se->avg.load_avg is initialized to
> >> scale_load_down(se->load.weight) and this se->avg.load_avg will be
> >> added to tg_x[cpu]->cfs_rq->avg.load_avg when attached to the cfs_rq
> 
> Yeah, you right, even when I've created 50 second level groups,
> tg_x->load_avg is ~6800.
> 
> Could it have something to do with the fact that .se->load.weight = 2
> for all these task groups? on a 64bit system?

I don't think so, the problem really comes from tg->load_avg = 381697
but sum of cfs_rq[cpu]->tg_load_avg_contrib = 1013 which is << tg->load_avg
and cfs_rq[cpu]->tg_load_avg_contrib == cfs_rq[cpu]->avg.load_avg so we can't 
expect any negative delta to remove this large value

> 
> In case we call  __update_load_avg(..., se->on_rq *
> scale_load_down(se->load.weight), ...) we pass a weight argument of 0
> for these se's.
> 
> Does not happen with:
> 
> -       if (shares < MIN_SHARES)
> -               shares = MIN_SHARES;
> +       if (shares < scale_load(MIN_SHARES))
> +               shares = scale_load(MIN_SHARES);
> 
> in  calc_cfs_shares().
> 
> [...]
> 
>