All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Dave Chinner <david@fromorbit.com>,
	eguan@redhat.com, fstests@vger.kernel.org
Subject: Re: [PATCH 2/2] fstests: run xfs_io as multi threaded process
Date: Sat, 15 Oct 2016 02:11:26 -0700	[thread overview]
Message-ID: <20161015091126.GA9631@infradead.org> (raw)
In-Reply-To: <1476477810-17478-2-git-send-email-amir73il@gmail.com>

On Fri, Oct 14, 2016 at 11:43:30PM +0300, Amir Goldstein wrote:
> Try to run xfs_io in all tests with command line option -M
> which starts an idle thread before performing any io.
> 
> The purpose of this idle thread is to test io from a multi threaded
> process. With single threaded process, the file table is not shared
> and file structs are not reference counted.
> 
> So in order to improve the change of detecting file struct reference
> leaks, all xfs_io commands in tests will try to run with this option.

I like the idea behing the -M command, but I'm not sure if we should
always use it.  For one this means we won't test the fget fastpath
any more, and second I'd like to know what the impact on xfstests
runtime is.

  reply	other threads:[~2016-10-15  9:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-14 20:43 [PATCH 1/2] fstests: fix call sites that used xfs_io directly Amir Goldstein
2016-10-14 20:43 ` [PATCH 2/2] fstests: run xfs_io as multi threaded process Amir Goldstein
2016-10-15  9:11   ` Christoph Hellwig [this message]
2016-10-15 15:13     ` Amir Goldstein
2016-10-15 17:04       ` Christoph Hellwig
2016-10-15 20:59         ` Amir Goldstein
2016-10-16  7:14           ` Christoph Hellwig
2016-10-16  8:51             ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161015091126.GA9631@infradead.org \
    --to=hch@infradead.org \
    --cc=amir73il@gmail.com \
    --cc=david@fromorbit.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.