From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvyqc-0003SQ-RB for qemu-devel@nongnu.org; Sun, 16 Oct 2016 23:44:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bvyqZ-00013h-0L for qemu-devel@nongnu.org; Sun, 16 Oct 2016 23:44:22 -0400 Date: Mon, 17 Oct 2016 14:38:06 +1100 From: David Gibson Message-ID: <20161017033806.GP25390@umbus.fritz.box> References: <1476589070-5792-1-git-send-email-rth@twiddle.net> <1476589070-5792-15-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p2pkNiL1PnZBJ6Nr" Content-Disposition: inline In-Reply-To: <1476589070-5792-15-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 14/15] target-ppc: Use tcg_gen_extract_* List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org --p2pkNiL1PnZBJ6Nr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 15, 2016 at 08:37:49PM -0700, Richard Henderson wrote: > Use the new primitives for RDWINM and RLDICL. >=20 > Cc: qemu-ppc@nongnu.org > Signed-off-by: Richard Henderson Applied to ppc-for-2.8, thanks. > --- > target-ppc/translate.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) >=20 > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > index bfc1301..724d95c 100644 > --- a/target-ppc/translate.c > +++ b/target-ppc/translate.c > @@ -1977,9 +1977,8 @@ static void gen_rlwinm(DisasContext *ctx) > if (mb =3D=3D 0 && me =3D=3D (31 - sh)) { > tcg_gen_shli_tl(t_ra, t_rs, sh); > tcg_gen_ext32u_tl(t_ra, t_ra); > - } else if (sh !=3D 0 && me =3D=3D 31 && sh =3D=3D (32 - mb)) { > - tcg_gen_ext32u_tl(t_ra, t_rs); > - tcg_gen_shri_tl(t_ra, t_ra, mb); > + } else if (me =3D=3D 31 && (me - mb + 1) + sh <=3D 32) { > + tcg_gen_extract_tl(t_ra, t_rs, sh, me - mb + 1); > } else { > target_ulong mask; > #if defined(TARGET_PPC64) > @@ -2094,8 +2093,8 @@ static void gen_rldinm(DisasContext *ctx, int mb, i= nt me, int sh) > =20 > if (sh !=3D 0 && mb =3D=3D 0 && me =3D=3D (63 - sh)) { > tcg_gen_shli_tl(t_ra, t_rs, sh); > - } else if (sh !=3D 0 && me =3D=3D 63 && sh =3D=3D (64 - mb)) { > - tcg_gen_shri_tl(t_ra, t_rs, mb); > + } else if (me =3D=3D 63 && (me - mb + 1) + sh <=3D 64) { > + tcg_gen_extract_tl(t_ra, t_rs, sh, me - mb + 1); > } else { > tcg_gen_rotli_tl(t_ra, t_rs, sh); > tcg_gen_andi_tl(t_ra, t_ra, MASK(mb, me)); --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --p2pkNiL1PnZBJ6Nr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYBEeeAAoJEGw4ysog2bOSrf0QAKnIBt0bgusjSlxt6J7idekl xByNkCA7ZTajrlKj6utUg5513Zca0f8enJ/dzpD1TH1u36wn4lJlcvXv8WevisQC lnPIDC8MeBbdIpE5MHbZM7wMXoxVSLxNhD1ebwDKXQv0xTiCIWljc+spvR/+G+b5 GjY05ScxREtMn8SzELlPDc9c/hzpdFFz9DVe5PwThoheQ/gKbaIXL6FfMkxSvgIj uSMsFPZ8ECbFTt17UY5EZ3HIcKXPT3cQyXDTcwBnYxruxEfdpok3ruwaAfSczVV3 czeA0cRYtsf/q9UJuUZxmrvnYdJFi4BL70xdNcb+tZYz8447Xtiv3KbaV8/QjeMl c1n0BY8Ik7xlDtn+0SHPzgurrQuOKXcRJHBGw6btERqN1N5tYKyUN+BGor7aACxB MrSh1QH/NJUXTPySJ3WoFH4HSUTg9OYJsE4sAcYTXqyI/PLEe7HH+BfxuDjmKPoT kUmstXRB2Qsn86yYl0Qux4UDu62yWulAmerPKhBm5iKvKqeNxb5eOSE5frCcAbAa dDRwnqu2p/djLKsEAkaskNvljEyVlYr0flLCHNiSVJctW4EYh3zJnNK0ShTy7fqk rj6kPly0U7QNfGUEogmvHGzslRM0as1yFjfIEmpfb7ilNWm46zXmGCa3EZSI1qey vGE6CplsSJDmTw3Z5vAc =zXCu -----END PGP SIGNATURE----- --p2pkNiL1PnZBJ6Nr--