From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758478AbcJQI3j (ORCPT ); Mon, 17 Oct 2016 04:29:39 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39394 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757613AbcJQI3Y (ORCPT ); Mon, 17 Oct 2016 04:29:24 -0400 Date: Mon, 17 Oct 2016 10:29:31 +0200 From: Greg KH To: Fernando Apesteguia Cc: lidza.louina@gmail.com, devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: dgnc: replace DGNC_VERIFY_BOARD macro Message-ID: <20161017082931.GA17106@kroah.com> References: <1476465777-720-1-git-send-email-fernando.apesteguia@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476465777-720-1-git-send-email-fernando.apesteguia@gmail.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 14, 2016 at 07:22:57PM +0200, Fernando Apesteguia wrote: > The patch replaces the macro with a function (dgnc_get_board) and > substitutes the macro statement with a call to that function and a > comparison on the returned value. > > This removes a checkpatch warning. > > Signed-off-by: Fernando Apesteguia > --- > drivers/staging/dgnc/dgnc_sysfs.c | 74 +++++++++++++++++++++++++++------------ > 1 file changed, 51 insertions(+), 23 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c > index 290bf6e..3ea23a9 100644 > --- a/drivers/staging/dgnc/dgnc_sysfs.c > +++ b/drivers/staging/dgnc/dgnc_sysfs.c > @@ -90,17 +90,21 @@ void dgnc_remove_driver_sysfiles(struct pci_driver *dgnc_driver) > driver_remove_file(driverfs, &driver_attr_pollrate); > } > > -#define DGNC_VERIFY_BOARD(p, bd) \ > - do { \ > - if (!p) \ > - return 0; \ > - \ > - bd = dev_get_drvdata(p); \ > - if (!bd || bd->magic != DGNC_BOARD_MAGIC) \ > - return 0; \ > - if (bd->state != BOARD_READY) \ > - return 0; \ > - } while (0) > +static struct dgnc_board *dgnc_get_board(struct device *p) > +{ > + struct dgnc_board *bd; > + > + if (!p) > + return NULL; > + > + bd = dev_get_drvdata(p); > + if (!bd || bd->magic != DGNC_BOARD_MAGIC) > + return NULL; > + if (bd->state != BOARD_READY) > + return NULL; > + > + return bd; > +} No, this macro should be removed entirely as what it does is pointless in some parts, wrong in others, and not needed at all in the rest :( I've asked others to fix this up properly in the past, but it doesn't seem like anyone wants to do the work... I don't want to take this patch as it will hide the real issues here. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 17 Oct 2016 10:29:31 +0200 From: Greg KH Subject: Re: [PATCH] staging: dgnc: replace DGNC_VERIFY_BOARD macro Message-ID: <20161017082931.GA17106@kroah.com> References: <1476465777-720-1-git-send-email-fernando.apesteguia@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1476465777-720-1-git-send-email-fernando.apesteguia@gmail.com> List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Fernando Apesteguia Cc: devel@driverdev.osuosl.org, lidza.louina@gmail.com, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org On Fri, Oct 14, 2016 at 07:22:57PM +0200, Fernando Apesteguia wrote: > The patch replaces the macro with a function (dgnc_get_board) and > substitutes the macro statement with a call to that function and a > comparison on the returned value. > > This removes a checkpatch warning. > > Signed-off-by: Fernando Apesteguia > --- > drivers/staging/dgnc/dgnc_sysfs.c | 74 +++++++++++++++++++++++++++------------ > 1 file changed, 51 insertions(+), 23 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c > index 290bf6e..3ea23a9 100644 > --- a/drivers/staging/dgnc/dgnc_sysfs.c > +++ b/drivers/staging/dgnc/dgnc_sysfs.c > @@ -90,17 +90,21 @@ void dgnc_remove_driver_sysfiles(struct pci_driver *dgnc_driver) > driver_remove_file(driverfs, &driver_attr_pollrate); > } > > -#define DGNC_VERIFY_BOARD(p, bd) \ > - do { \ > - if (!p) \ > - return 0; \ > - \ > - bd = dev_get_drvdata(p); \ > - if (!bd || bd->magic != DGNC_BOARD_MAGIC) \ > - return 0; \ > - if (bd->state != BOARD_READY) \ > - return 0; \ > - } while (0) > +static struct dgnc_board *dgnc_get_board(struct device *p) > +{ > + struct dgnc_board *bd; > + > + if (!p) > + return NULL; > + > + bd = dev_get_drvdata(p); > + if (!bd || bd->magic != DGNC_BOARD_MAGIC) > + return NULL; > + if (bd->state != BOARD_READY) > + return NULL; > + > + return bd; > +} No, this macro should be removed entirely as what it does is pointless in some parts, wrong in others, and not needed at all in the rest :( I've asked others to fix this up properly in the past, but it doesn't seem like anyone wants to do the work... I don't want to take this patch as it will hide the real issues here. thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel