From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935148AbcJQPuQ (ORCPT ); Mon, 17 Oct 2016 11:50:16 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:45062 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964992AbcJQPt7 (ORCPT ); Mon, 17 Oct 2016 11:49:59 -0400 Date: Mon, 17 Oct 2016 17:49:38 +0200 From: Peter Zijlstra To: Boqun Feng Cc: Will Deacon , Linus Torvalds , Waiman Long , Jason Low , Ding Tianhong , Thomas Gleixner , Ingo Molnar , Imre Deak , Linux Kernel Mailing List , Davidlohr Bueso , Tim Chen , Terry Rudd , "Paul E. McKenney" , Jason Low , Chris Wilson , Daniel Vetter Subject: Re: [PATCH -v4 6/8] locking/mutex: Restructure wait loop Message-ID: <20161017154938.GV3142@twins.programming.kicks-ass.net> References: <20161007145243.361481786@infradead.org> <20161007150211.271490994@infradead.org> <20161013151720.GB13138@arm.com> <20161017104449.GO3117@twins.programming.kicks-ass.net> <20161017132408.GF3157@twins.programming.kicks-ass.net> <20161017134501.GA27939@tardis.cn.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161017134501.GA27939@tardis.cn.ibm.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 17, 2016 at 09:45:01PM +0800, Boqun Feng wrote: > But __mutex_set_flag() and __mutex_trylock() actually touch the same > atomic word? So we don't need extra things to order them? Right.. in any case brain is confused. I'll look again at it later.