From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759441AbcJQU2e (ORCPT ); Mon, 17 Oct 2016 16:28:34 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56300 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759389AbcJQU23 (ORCPT ); Mon, 17 Oct 2016 16:28:29 -0400 Date: Mon, 17 Oct 2016 22:28:34 +0200 From: Greg Kroah-Hartman To: Eric Anholt Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stephen Warren , Lee Jones , bcm-kernel-feedback-list@broadcom.com, Dom Cobley Subject: Re: [PATCH 2/5] staging/vchi: Fix build warnings when formatting pointers on aarch64. Message-ID: <20161017202834.GA30101@kroah.com> References: <20161017194406.1080-1-eric@anholt.net> <20161017194406.1080-3-eric@anholt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161017194406.1080-3-eric@anholt.net> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 17, 2016 at 12:44:03PM -0700, Eric Anholt wrote: > The code was generally using "%x" to print and "(unsigned int)" to > cast the pointers, but we have %p for printing pointers in the same > format without any broken casts. I already did this work, it's all checked into my tree, and is in linux-next now. You were cc:ed on the patches as well. Also, please use "%pK" for kernel pointers, you never want to print an address to userspace unless debugging is enabled, as it is a security leak. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg Kroah-Hartman) Date: Mon, 17 Oct 2016 22:28:34 +0200 Subject: [PATCH 2/5] staging/vchi: Fix build warnings when formatting pointers on aarch64. In-Reply-To: <20161017194406.1080-3-eric@anholt.net> References: <20161017194406.1080-1-eric@anholt.net> <20161017194406.1080-3-eric@anholt.net> Message-ID: <20161017202834.GA30101@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Oct 17, 2016 at 12:44:03PM -0700, Eric Anholt wrote: > The code was generally using "%x" to print and "(unsigned int)" to > cast the pointers, but we have %p for printing pointers in the same > format without any broken casts. I already did this work, it's all checked into my tree, and is in linux-next now. You were cc:ed on the patches as well. Also, please use "%pK" for kernel pointers, you never want to print an address to userspace unless debugging is enabled, as it is a security leak. thanks, greg k-h