From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: fix locking for the reflink operation
Date: Mon, 17 Oct 2016 14:35:50 -0700 [thread overview]
Message-ID: <20161017213550.GA7786@birch.djwong.org> (raw)
In-Reply-To: <1476705920-32493-1-git-send-email-hch@lst.de>
On Mon, Oct 17, 2016 at 02:05:16PM +0200, Christoph Hellwig wrote:
> When creating a reflink we need to take the iolock much earlier, as
> various early checks done in xfs_file_share_range currently are racy
> without it. Patches 1-3 sort that out in a minimal invasive way,
> but I think we should just merge xfs_file_share_range and
> xfs_reflink_remap_range, which is what patch 4 does.
>
> Patches 1-3 are something I'd like to see in 4.9, patch 4 might not
> fully qualify, but just getting it in might make everyones life easier.
This series (+ the CoW optimization series before it) seem to run ok here.
I'm ok with (more soak testing and) sending it in for 4.9.
--D
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-10-17 21:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 12:05 fix locking for the reflink operation Christoph Hellwig
2016-10-17 12:05 ` [PATCH 1/4] xfs: remove the same fs check from xfs_file_share_range Christoph Hellwig
2016-10-17 21:11 ` Darrick J. Wong
2016-10-17 12:05 ` [PATCH 2/4] xfs: fix the same_inode check in xfs_file_share_range Christoph Hellwig
2016-10-17 21:12 ` Darrick J. Wong
2016-10-17 12:05 ` [PATCH 3/4] xfs: move inode locking from xfs_reflink_remap_range to xfs_file_share_range Christoph Hellwig
2016-10-17 21:16 ` Darrick J. Wong
2016-10-17 12:05 ` [PATCH 4/4] xfs: merge xfs_reflink_remap_range and xfs_file_share_range Christoph Hellwig
2016-10-17 21:29 ` Darrick J. Wong
2016-10-18 5:17 ` Christoph Hellwig
2016-10-17 21:35 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161017213550.GA7786@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.