From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gross Subject: Re: [RFC V3 PATCH 5/7] arm64: dts: msm8994 SoC and Huawei Angler (Nexus 6P) support Date: Mon, 17 Oct 2016 17:15:35 -0500 Message-ID: <20161017221535.GA3145@hector.attlocal.net> References: <1476265054-22511-1-git-send-email-jeremymc@redhat.com> <1476265054-22511-6-git-send-email-jeremymc@redhat.com> <20161012133450.GC21050@remoulade> <3e641d25-8ca6-3594-5d3e-038d6f7a9eba@redhat.com> <6be08daf-0ad7-7913-ee63-854d52eb6ba1@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f169.google.com ([209.85.192.169]:35723 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758497AbcJQWPi (ORCPT ); Mon, 17 Oct 2016 18:15:38 -0400 Received: by mail-pf0-f169.google.com with SMTP id s8so83950983pfj.2 for ; Mon, 17 Oct 2016 15:15:37 -0700 (PDT) Content-Disposition: inline In-Reply-To: <6be08daf-0ad7-7913-ee63-854d52eb6ba1@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Michael Scott Cc: Jeremy McNicoll , Rob Herring , Mark Rutland , Jeremy McNicoll , linux-arm-msm , linux-soc@vger.kernel.org, "devicetree@vger.kernel.org" , Stephen Boyd , Arnd Bergmann , Bjorn Andersson On Fri, Oct 14, 2016 at 03:06:45PM -0700, Michael Scott wrote: > > > On 10/12/2016 05:42 PM, Jeremy McNicoll wrote: > >On 2016-10-12 7:20 AM, Rob Herring wrote: > >>On Wed, Oct 12, 2016 at 8:34 AM, Mark Rutland > >>wrote: > >>>On Wed, Oct 12, 2016 at 02:37:32AM -0700, Jeremy McNicoll wrote: > >>>>+/ { > >>>>+ model = "HUAWEI MSM8994 ANGLER rev-1.01"; > >>>>+ compatible = "qcom,msm8994"; > >>>>+ qcom,board-id= <8026 0>; > > Hello Jeremy, > > When I tested these patches on linux-next, the bootloader on my Nexus 6P > wasn't finding the dtb until I adjusted the board-id value to <8023 0>. > > Apparently, my hardware matches "Huawei Technologies, Inc. MSM8994 Angler > VN2" in the original kernel sources: > https://android.googlesource.com/kernel/msm/+/android-msm-angler-3.10-nougat/arch/arm64/boot/dts/huawei/huawei_angler_vn2.dts Sounds like we need another board file that at least covers the main msm-id for this. > > I'm not sure what the most common hardware is out in the wild, but the > board-id for your dts comes from this commit, which seems to indicate it's a > DVT model (as opposed to a PVT model): > https://android.googlesource.com/kernel/msm/+/e9a476191862cfe8e5e30e2babc04052f9ab936b > > We should definitely get a sample size of > 1 Too bad those phones are somewhat expensive. Andy