All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: david@fromorbit.com, eguan@redhat.com, linux-xfs@vger.kernel.org,
	hch@infradead.org, fstests@vger.kernel.org
Subject: Re: [PATCH 2/3] misc: fix fallocate commands that need the unshare switch
Date: Mon, 17 Oct 2016 22:19:37 -0700	[thread overview]
Message-ID: <20161018051937.GB31237@infradead.org> (raw)
In-Reply-To: <147674216832.23842.4457619951534662629.stgit@birch.djwong.org>

On Mon, Oct 17, 2016 at 03:09:28PM -0700, Darrick J. Wong wrote:
> We re-added the UNSHARE flag to fallocate, so go make sure that all
> the unshare tests actually check that the installed copy of xfs_io
> supports the 'funshare' command and that the underlying filesystem
> understands the flag, and change the tests themselves to use
> funshare.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Looks fine, and tests fine on XFS, btrfs and ext4:

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2016-10-18  5:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17 22:09 [PATCH v2 0/3] xfstests: fix tests for rmap/reflink Darrick J. Wong
2016-10-17 22:09 ` [PATCH 1/3] xfs: set the refcount btree cowflag when setting up cow Darrick J. Wong
2016-10-17 22:09 ` [PATCH 2/3] misc: fix fallocate commands that need the unshare switch Darrick J. Wong
2016-10-18  5:19   ` Christoph Hellwig [this message]
2016-10-17 22:09 ` [PATCH 3/3] misc: fix more xfs_db open-coding instances Darrick J. Wong
2016-10-20 14:44   ` Eryu Guan
2016-10-21  3:21     ` Darrick J. Wong
  -- strict thread matches above, loose matches on Subject: below --
2016-10-14 18:12 [PATCH 0/3] xfstests: fix tests for rmap/reflink Darrick J. Wong
2016-10-14 18:13 ` [PATCH 2/3] misc: fix fallocate commands that need the unshare switch Darrick J. Wong
2016-10-15 17:03   ` Christoph Hellwig
2016-10-16  6:18     ` Christoph Hellwig
2016-10-17 21:57       ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161018051937.GB31237@infradead.org \
    --to=hch@infradead.org \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.