From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwRIR-00032W-9U for qemu-devel@nongnu.org; Tue, 18 Oct 2016 06:07:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwRIO-0005GU-5Y for qemu-devel@nongnu.org; Tue, 18 Oct 2016 06:06:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41964) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwRIO-0005G1-0E for qemu-devel@nongnu.org; Tue, 18 Oct 2016 06:06:56 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 56721C05678D for ; Tue, 18 Oct 2016 10:06:55 +0000 (UTC) Date: Tue, 18 Oct 2016 11:06:52 +0100 From: "Daniel P. Berrange" Message-ID: <20161018100652.GI4349@redhat.com> Reply-To: "Daniel P. Berrange" References: <20161012191502.GC16187@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161012191502.GC16187@work-vm> Subject: Re: [Qemu-devel] chardev's and fd's in monitors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: qemu-devel@nongnu.org, armbru@redhat.com On Wed, Oct 12, 2016 at 08:15:02PM +0100, Dr. David Alan Gilbert wrote: > Hi, > I had a look at a couple of readline like libraries; > editline and linenoise. A difficulty with using them is that > they both want fd's or FILE*'s; editline takes either but > from a brief look I think it's expecting to extract the fd. > That makes them tricky to integrate into qemu, where > the chardev's hide a whole bunch of non-fd things; in particular > tls, mux, ringbuffers etc. > > If we could get away with just a FILE* then we could use fopencookie, > but that's GNU only. > > Is there any sane way of shepherding all chardev's into having an > fd? > > Once you had those then you could also use them in a separate thread. BTW, what is the actual thread issue you are facing ? Chardevs at least ought to be usable from a separate thread, as long as each distinct chardev object instance was only used from one thread at a time ? Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|