From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935234AbcJRPYQ (ORCPT ); Tue, 18 Oct 2016 11:24:16 -0400 Received: from mail.us.es ([193.147.175.20]:57728 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935077AbcJRPYI (ORCPT ); Tue, 18 Oct 2016 11:24:08 -0400 Date: Tue, 18 Oct 2016 17:23:54 +0200 From: Pablo Neira Ayuso To: Arnd Bergmann Cc: Patrick McHardy , Jozsef Kadlecsik , "David S. Miller" , Linus Torvalds , linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org Subject: Re: [PATCH 01/28] [v2] netfilter: nf_tables: avoid uninitialized variable warning Message-ID: <20161018152354.GA2759@salvia> References: <20161017220342.1627073-1-arnd@arndb.de> <20161017220557.1688282-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161017220557.1688282-1-arnd@arndb.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 18, 2016 at 12:05:30AM +0200, Arnd Bergmann wrote: > The newly added nft_range_eval() function handles the two possible > nft range operations, but as the compiler warning points out, > any unexpected value would lead to the 'mismatch' variable being > used without being initialized: > > net/netfilter/nft_range.c: In function 'nft_range_eval': > net/netfilter/nft_range.c:45:5: error: 'mismatch' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > This removes the variable in question and instead moves the > condition into the switch itself, which is potentially more > efficient than adding a bogus 'default' clause as in my > first approach, and is nicer than using the 'uninitialized_var' > macro. Applied to the nf tree, thanks Arnd.