From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51205) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwioI-0003yL-T4 for qemu-devel@nongnu.org; Wed, 19 Oct 2016 00:49:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwioA-0001Sg-9o for qemu-devel@nongnu.org; Wed, 19 Oct 2016 00:49:02 -0400 Date: Wed, 19 Oct 2016 13:16:50 +1100 From: David Gibson Message-ID: <20161019021650.GC11140@umbus.fritz.box> References: <1476823604-15403-1-git-send-email-thuth@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IpbVkmxF4tDyP/Kb" Content-Disposition: inline In-Reply-To: <1476823604-15403-1-git-send-email-thuth@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/5] nvram: Refactor OpenBIOS NVRAM code to support -prom-env on pseries, too List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Alexander Graf , qemu-ppc@nongnu.org, Mark Cave-Ayland , qemu-devel@nongnu.org, Artyom Tarasenko --IpbVkmxF4tDyP/Kb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 18, 2016 at 10:46:39PM +0200, Thomas Huth wrote: > The OpenBIOS NVRAM set-up is based on the layout defined in the CHRP > (Common Hardware Reference Platform) specification. This is the same > layout that is also used by the PAPR specification and thus by the SLOF > firmware of the pseries machine. By refactoring the NVRAM code from > mac_nvram.c, we can use the same functions for setting up the NVRAM > for both, OpenBIOS and SLOF. This way we can support the "-prom-env" > parameter of QEMU for SLOF, too, which is very useful to influence > the firmware boot process. >=20 > Thomas Huth (5): > nvram: Introduce helper functions for CHRP "system" and "free space" > partitions > sparc: Use the new common NVRAM functions for system and free space > partition > spapr_nvram: Pre-initialize the NVRAM to support the -prom-env > parameter > nvram: Move the remaining CHRP NVRAM related code to chrp_nvram.[ch] > nvram: Rename openbios_firmware_abi.h into sun_nvram.h >=20 > hw/nvram/Makefile.objs | 1 + > hw/nvram/chrp_nvram.c | 85 ++++++++++++++++= ++++++ > hw/nvram/mac_nvram.c | 49 +++---------- > hw/nvram/spapr_nvram.c | 6 ++ > hw/sparc/sun4m.c | 35 ++------- > hw/sparc64/sun4u.c | 35 ++------- > include/hw/nvram/chrp_nvram.h | 54 ++++++++++++++ > .../nvram/{openbios_firmware_abi.h =3D> sun_nvram.h} | 47 +----------- > tests/postcopy-test.c | 8 +- > 9 files changed, 179 insertions(+), 141 deletions(-) > create mode 100644 hw/nvram/chrp_nvram.c > create mode 100644 include/hw/nvram/chrp_nvram.h > rename include/hw/nvram/{openbios_firmware_abi.h =3D> sun_nvram.h} (50%) Series, Reviewed-by: David Gibson I've put it into ppc-for-2.8 tentatively. However I'd like to get an Acked-by from Mark for the Sparc bits before I send my next pull request. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --IpbVkmxF4tDyP/Kb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYBteRAAoJEGw4ysog2bOSt9IP/2ufiiIeqdYr/yQ39Q+sOlih gn9sGsn+3EU2apjxZfIkRJdrxOx2HD3qp4KyQNY68xmm71mCounWGL0CGACVCO/7 j3xaOQgfpHj+thD8KuFf2gBW57RCIsAUF5vIKSLUW23IF8KAwZcRjAbRtYHUOPWb iNzcEaxu2JJveWW0tyIP4FSrD91TSdDy9mx2C2pJI8OPNMnCb0aGwGJVtsjd4ZIc EhWnvLXUYBjCRxOBIOpSyFu4uVZ4KuHr+c4h3hQxrNfmlrGGrcinmOmM96EShuEX zVnKT8xwKZynSp95GqGoMb6dUjHXcOKZAM5wEQH1dcS0v1asb1TFypmVZf2yXMdV oADMWsMpTYvlHvAOGMaExPrcMDPihRsjYvYsqPYdNsRiz9/RAELdWcl9CzesBFmm Xrda8u2FE+3cbNUHRTQnLJZDxJxiM3CY1jxtK2kctlUDggNQQ4HPIYP9SgEroGA6 KmqyHjuTr59DF1bXRgAd2WGoO+TdNlcdIjbyk8J/gBa7cfoIvVIn1v4GaLu0OBTi J5vwr3m5LeBCr8CiVpuPbObHGlhk/7igKhVh/JrKHQXIa362Ews6fvbfGt/NVDqA /abKIoDyGbO8cWj+Hu21q5wN0l3gqXJOm0CY19b56Cp1pjTnLVf75qNqExosavKt dM0tNpbCQNjQdakVhKBE =ZDWH -----END PGP SIGNATURE----- --IpbVkmxF4tDyP/Kb--