All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 08/12] drm/i915/gvt: Stop checking for impossible interrupts from a kthread
Date: Wed, 19 Oct 2016 11:11:43 +0100	[thread overview]
Message-ID: <20161019101147.17342-9-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20161019101147.17342-1-chris@chris-wilson.co.uk>

The kthread will not be interrupted, don't even bother checking.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>
---
 drivers/gpu/drm/i915/gvt/scheduler.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/gvt/scheduler.c
index 224f19ae61ab..310435498932 100644
--- a/drivers/gpu/drm/i915/gvt/scheduler.c
+++ b/drivers/gpu/drm/i915/gvt/scheduler.c
@@ -423,12 +423,7 @@ static int workload_thread(void *priv)
 		/*
 		 * Always take i915 big lock first
 		 */
-		ret = i915_mutex_lock_interruptible(&gvt->dev_priv->drm);
-		if (ret < 0) {
-			gvt_err("i915 submission is not available, retry\n");
-			schedule_timeout(1);
-			continue;
-		}
+		mutex_lock(&gvt->dev_priv->drm.struct_mutex);
 
 		gvt_dbg_sched("ring id %d will dispatch workload %p\n",
 				workload->ring_id, workload);
@@ -447,7 +442,7 @@ static int workload_thread(void *priv)
 				workload->ring_id, workload);
 
 		workload->status = i915_wait_request(workload->req,
-						     I915_WAIT_INTERRUPTIBLE | I915_WAIT_LOCKED,
+						     I915_WAIT_LOCKED,
 						     NULL, NULL);
 		if (workload->status != 0)
 			gvt_err("fail to wait workload, skip\n");
-- 
2.9.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-10-19 10:12 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-19 10:11 gvt gem fixes Chris Wilson
2016-10-19 10:11 ` [PATCH 01/12] drm/i915/gvt: s/drm_gem_object_unreference/i915_gem_object_put/ Chris Wilson
2016-10-19 10:11 ` [PATCH 02/12] drm/i915/gvt: Add runtime pm around fences Chris Wilson
2016-10-19 10:11 ` [PATCH 03/12] drm/i915/gvt: i915_gem_object_create() returns an error pointer Chris Wilson
2016-10-19 10:11 ` [PATCH 04/12] drm/i915: Catch premature unpinning of pages Chris Wilson
2016-10-19 10:26   ` Joonas Lahtinen
2016-10-19 10:11 ` [PATCH 05/12] drm/i915/gvt: Use the returned VMA to provide the virtual address Chris Wilson
2016-10-19 10:11 ` [PATCH 06/12] drm/i915/gvt: Remove dangerous unpin of backing storage of bound GPU object Chris Wilson
2016-10-19 10:11 ` [PATCH 07/12] drm/i915/gvt: Hold a reference on the request Chris Wilson
2016-10-19 10:32   ` Zhenyu Wang
2016-10-19 10:53     ` Chris Wilson
2016-10-20  0:22   ` Zhenyu Wang
2016-10-20  6:52     ` Chris Wilson
2016-10-20  7:33       ` Zhenyu Wang
2016-10-19 10:11 ` Chris Wilson [this message]
2016-10-19 10:11 ` [PATCH 09/12] drm/i915/gvt: Stop waiting whilst holding struct_mutex Chris Wilson
2016-10-19 10:11 ` [PATCH 10/12] drm/i915/gvt: Use common mapping routines for indirect_ctx object Chris Wilson
2016-10-19 10:26   ` Zhenyu Wang
2016-10-19 10:11 ` [PATCH 11/12] drm/i915/gvt: Use common mapping routines for shadow_bb object Chris Wilson
2016-10-19 10:11 ` [PATCH 12/12] drm/i915/gvt: Remove defunct vmap_batch() Chris Wilson
2016-10-19 10:45 ` gvt gem fixes Zhenyu Wang
2016-10-19 11:02   ` Chris Wilson
2016-10-20  0:33     ` Zhenyu Wang
2016-10-20  7:02       ` Daniel Vetter
2016-10-20  7:15         ` Zhenyu Wang
2016-10-20  9:13           ` Daniel Vetter
2016-10-19 13:54 ` ✗ Fi.CI.BAT: warning for series starting with [01/12] drm/i915/gvt: s/drm_gem_object_unreference/i915_gem_object_put/ Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161019101147.17342-9-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.