All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Szymon Janc <szymon.janc@codecoup.pl>,
	puthik@chromium.org,
	"linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] doc/device-api: Add AdvertisingFlags
Date: Wed, 19 Oct 2016 20:15:58 +0300	[thread overview]
Message-ID: <20161019171558.GA16713@x1c.P-661HNU-F1> (raw)
In-Reply-To: <CABBYNZJMncaA0pgOx5DvGS5=Mfy=Q0bp=CfPDKtg2Bif7rB-gQ@mail.gmail.com>

Hi Luiz,

On Wed, Oct 19, 2016, Luiz Augusto von Dentz wrote:
> > Hmm I wonder.. why not just expose full AD + SCAN_RSP this way?
> > Are we going to add prop for every data type?
> 
> Then there is no reason to parse the AD, and even broken/unknown AD
> should be send which sounds like a very dangerous think to do so Id
> leave this for application that can deal with the management socket
> but not over D-Bus.

I'm not so sure about this (having a "raw" AD/EIR API). We don't
necessarily need to expose the raw data as such, but it could be a
dictionary where the key is the data type and the value a byte array.
That'd at least prevent common pitfalls with broken parsing.

We could also consider making this a subscription based thing so that
it's not a broadcast signal but either a unicast signal or a method call
to whomever has requested to receive the information. Side note: I think
the approach the bus1 folks would like to take is to get rid of
broadcast signals completely and rely on a service-based subscription
mechanism.

Johan

  reply	other threads:[~2016-10-19 17:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-18 19:10 [PATCH v2 0/2] Expose AdvertisingDataFlags in Device API puthik
2016-10-18 19:10 ` puthik
2016-10-18 19:10 ` [PATCH v2 1/2] doc/device-api: Add AdvertisingFlags puthik
2016-10-19  7:19   ` Luiz Augusto von Dentz
2016-10-19 16:15     ` Szymon Janc
2016-10-19 16:21       ` Luiz Augusto von Dentz
2016-10-19 17:15         ` Johan Hedberg [this message]
2016-10-20  1:54           ` Puthikorn Voravootivat
2016-10-18 19:11 ` [PATCH v2 2/2] core: Add implementation of AdvertisingFlags puthik
2016-10-19  7:23   ` Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161019171558.GA16713@x1c.P-661HNU-F1 \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=puthik@chromium.org \
    --cc=szymon.janc@codecoup.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.