From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [kvm-unit-tests PATCH 02/14] x86: smp: allow multiple init for
 smp setup
Date: Wed, 19 Oct 2016 22:23:55 +0200
Message-ID: <20161019202354.GC8573@potion>
References: <1476448852-30062-1-git-send-email-peterx@redhat.com>
 <1476448852-30062-3-git-send-email-peterx@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, jan.kiszka@web.de, agordeev@redhat.com,
        drjones@redhat.com, pbonzini@redhat.com
To: Peter Xu <peterx@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:56584 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750751AbcJSUX7 (ORCPT <rfc822;kvm@vger.kernel.org>);
        Wed, 19 Oct 2016 16:23:59 -0400
Content-Disposition: inline
In-Reply-To: <1476448852-30062-3-git-send-email-peterx@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

2016-10-14 20:40+0800, Peter Xu:
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  lib/x86/smp.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/lib/x86/smp.c b/lib/x86/smp.c
> index 1eb49f2..bb74087 100644
> --- a/lib/x86/smp.c
> +++ b/lib/x86/smp.c
> @@ -111,8 +111,13 @@ void on_cpu_async(int cpu, void (*function)(void *data), void *data)
>  void smp_init(void)
>  {
>      int i;
> +    bool smp_inited = false;

Missing "static".

The first two patches are just for sanity and not needed in the series?

>      void ipi_entry(void);
>  
> +    if (smp_inited) {
> +        return;
> +    }
> +
>      _cpu_count = fwcfg_get_nb_cpus();
>  
>      setup_idt();
> @@ -122,4 +127,5 @@ void smp_init(void)
>      for (i = 1; i < cpu_count(); ++i)
>          on_cpu(i, setup_smp_id, 0);
>  
> +    smp_inited = true;
>  }
> -- 
> 2.7.4
>