From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754879AbcJTGm1 (ORCPT ); Thu, 20 Oct 2016 02:42:27 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:34631 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750820AbcJTGm0 (ORCPT ); Thu, 20 Oct 2016 02:42:26 -0400 Date: Thu, 20 Oct 2016 08:42:21 +0200 From: Daniel Vetter To: Stefan Agner Cc: daniel.vetter@ffwll.ch, meng.yi@nxp.com, dri-devel@lists.freedesktop.org, alison.wang@freescale.com, jianwei.wang.chn@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] drm/fb_cma_helper: do not free fbdev if there is none Message-ID: <20161020064221.GK20761@phenom.ffwll.local> Mail-Followup-To: Stefan Agner , meng.yi@nxp.com, dri-devel@lists.freedesktop.org, alison.wang@freescale.com, jianwei.wang.chn@gmail.com, linux-kernel@vger.kernel.org References: <20161020003221.2941-1-stefan@agner.ch> <20161020003221.2941-2-stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161020003221.2941-2-stefan@agner.ch> X-Operating-System: Linux phenom 4.6.0-1-amd64 User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 19, 2016 at 05:32:19PM -0700, Stefan Agner wrote: > If fbdev emulation is not in use (or not built-in), fb_helper.fbdev > is NULL. Don't call calling drm_fbdev_cma_defio_fini in this case. > > Signed-off-by: Stefan Agner Yeah makes sense. Applied to drm-misc. -Daniel > --- > drivers/gpu/drm/drm_fb_cma_helper.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c > index 1fd6eac..12d654d 100644 > --- a/drivers/gpu/drm/drm_fb_cma_helper.c > +++ b/drivers/gpu/drm/drm_fb_cma_helper.c > @@ -557,7 +557,8 @@ EXPORT_SYMBOL_GPL(drm_fbdev_cma_init); > void drm_fbdev_cma_fini(struct drm_fbdev_cma *fbdev_cma) > { > drm_fb_helper_unregister_fbi(&fbdev_cma->fb_helper); > - drm_fbdev_cma_defio_fini(fbdev_cma->fb_helper.fbdev); > + if (fbdev_cma->fb_helper.fbdev) > + drm_fbdev_cma_defio_fini(fbdev_cma->fb_helper.fbdev); > drm_fb_helper_release_fbi(&fbdev_cma->fb_helper); > > if (fbdev_cma->fb) { > -- > 2.10.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/3] drm/fb_cma_helper: do not free fbdev if there is none Date: Thu, 20 Oct 2016 08:42:21 +0200 Message-ID: <20161020064221.GK20761@phenom.ffwll.local> References: <20161020003221.2941-1-stefan@agner.ch> <20161020003221.2941-2-stefan@agner.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-lf0-x244.google.com (mail-lf0-x244.google.com [IPv6:2a00:1450:4010:c07::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 813B46E0F1 for ; Thu, 20 Oct 2016 06:42:26 +0000 (UTC) Received: by mail-lf0-x244.google.com with SMTP id x79so5861892lff.2 for ; Wed, 19 Oct 2016 23:42:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20161020003221.2941-2-stefan@agner.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Stefan Agner Cc: jianwei.wang.chn@gmail.com, meng.yi@nxp.com, alison.wang@freescale.com, daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBPY3QgMTksIDIwMTYgYXQgMDU6MzI6MTlQTSAtMDcwMCwgU3RlZmFuIEFnbmVyIHdy b3RlOgo+IElmIGZiZGV2IGVtdWxhdGlvbiBpcyBub3QgaW4gdXNlIChvciBub3QgYnVpbHQtaW4p LCBmYl9oZWxwZXIuZmJkZXYKPiBpcyBOVUxMLiBEb24ndCBjYWxsIGNhbGxpbmcgZHJtX2ZiZGV2 X2NtYV9kZWZpb19maW5pIGluIHRoaXMgY2FzZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBTdGVmYW4g QWduZXIgPHN0ZWZhbkBhZ25lci5jaD4KClllYWggbWFrZXMgc2Vuc2UuIEFwcGxpZWQgdG8gZHJt LW1pc2MuCi1EYW5pZWwKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZmJfY21hX2hlbHBl ci5jIHwgMyArKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlv bigtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2NtYV9oZWxwZXIu YyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfY21hX2hlbHBlci5jCj4gaW5kZXggMWZkNmVhYy4u MTJkNjU0ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2NtYV9oZWxwZXIu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfY21hX2hlbHBlci5jCj4gQEAgLTU1Nyw3 ICs1NTcsOCBAQCBFWFBPUlRfU1lNQk9MX0dQTChkcm1fZmJkZXZfY21hX2luaXQpOwo+ICB2b2lk IGRybV9mYmRldl9jbWFfZmluaShzdHJ1Y3QgZHJtX2ZiZGV2X2NtYSAqZmJkZXZfY21hKQo+ICB7 Cj4gIAlkcm1fZmJfaGVscGVyX3VucmVnaXN0ZXJfZmJpKCZmYmRldl9jbWEtPmZiX2hlbHBlcik7 Cj4gLQlkcm1fZmJkZXZfY21hX2RlZmlvX2ZpbmkoZmJkZXZfY21hLT5mYl9oZWxwZXIuZmJkZXYp Owo+ICsJaWYgKGZiZGV2X2NtYS0+ZmJfaGVscGVyLmZiZGV2KQo+ICsJCWRybV9mYmRldl9jbWFf ZGVmaW9fZmluaShmYmRldl9jbWEtPmZiX2hlbHBlci5mYmRldik7Cj4gIAlkcm1fZmJfaGVscGVy X3JlbGVhc2VfZmJpKCZmYmRldl9jbWEtPmZiX2hlbHBlcik7Cj4gIAo+ICAJaWYgKGZiZGV2X2Nt YS0+ZmIpIHsKPiAtLSAKPiAyLjEwLjAKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVu Z2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK