From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxB61-0007zc-U0 for qemu-devel@nongnu.org; Thu, 20 Oct 2016 07:01:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bxB61-0005EG-6l for qemu-devel@nongnu.org; Thu, 20 Oct 2016 07:01:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54428) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bxB61-0005Dv-1o for qemu-devel@nongnu.org; Thu, 20 Oct 2016 07:01:13 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4005585545 for ; Thu, 20 Oct 2016 11:01:12 +0000 (UTC) Date: Thu, 20 Oct 2016 12:01:08 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20161020110108.GE2039@work-vm> References: <87twc8d60e.fsf@dusky.pond.sub.org> <20161019100552.GD2035@work-vm> <20161019101616.GL11194@redhat.com> <87a8e0bkl6.fsf@dusky.pond.sub.org> <20161019122158.GS11194@redhat.com> <20161019180616.GF2035@work-vm> <87oa2fwg9z.fsf@dusky.pond.sub.org> <20161020090356.GD12145@redhat.com> <20161020095835.GC2039@work-vm> <87funrti86.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87funrti86.fsf@dusky.pond.sub.org> Subject: Re: [Qemu-devel] chardev's and fd's in monitors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: "Daniel P. Berrange" , qemu-devel@nongnu.org * Markus Armbruster (armbru@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > The problem is that our way of propagating errors actively discourages > > people from adding errors and you're left with lots of useless invented errno's. > > error_report makes it easy for people to scatter meaningful error messages > > in at any point. > > > > Make an easy, concise way of reporting an error that fits in with > > a propagation scheme and I'd consider converting stuff. > > error_setg(errp, "This is as simple as it gets, I'm afraid") > > Snark aside, I acknowledge the pain of converting call chains to > propagate Error objects, having converted "a few" myself. If you can get it down to that line it would be great! But unfortunately it isn't: a) I have to make sure my cleanup path after that error_setg doesn't cause any other errors because that breaks the rule that I can't call error_setg twice. b) I've got to put the whole local_err/error_propagate stuff all over. c) We insist on allowing the Err ** pointer to be NULL that removes some potential simplifications. No; just too messy - give me something I can just drop those error_setg's in and I'd be happy - it's everything around it that I find truly painful. Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK