From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Xu <peterx@redhat.com>
Subject: Re: [kvm-unit-tests RFC PATCH 00/14] VT-d unit test
Date: Thu, 20 Oct 2016 19:28:42 +0800
Message-ID: <20161020112842.GN15168@pxdev.xzpeter.org>
References: <1476448852-30062-1-git-send-email-peterx@redhat.com>
 <20161019202110.GB8573@potion>
 <20161020060551.GG15168@pxdev.xzpeter.org>
 <20161020110858.GE8573@potion>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: kvm@vger.kernel.org, jan.kiszka@web.de, agordeev@redhat.com,
        drjones@redhat.com, pbonzini@redhat.com
To: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:60672 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932721AbcJTL2r (ORCPT <rfc822;kvm@vger.kernel.org>);
        Thu, 20 Oct 2016 07:28:47 -0400
Content-Disposition: inline
In-Reply-To: <20161020110858.GE8573@potion>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Oct 20, 2016 at 01:08:59PM +0200, Radim Krčmář wrote:

[...]

> Btw. isn't this series already testing one fixed QEMU bug?
> When I run this test with old QEMU (qemu-2.7.0-3.fc26), then I get this
> output:
> 
>   [...]
>   INTR: setup IRTE index 0
>   lib/pci.c:52: assert failed: dev && dev->inited && dev->msi_offset
>           STACK: 40344c 402fd1 400567 40028f
> 
> new QEMU works fine, so I assume that we should test it and not assert.

One thing forgot to mention: I think you are right, I should test it
and not assert, so that when people are using old edu device, we can
just skip the MSI tests.

Thanks!

-- peterx