From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH v2 3/4] ACPI / gpio: Add hogging support Date: Thu, 20 Oct 2016 15:29:29 +0300 Message-ID: <20161020122929.GG24289@lahna.fi.intel.com> References: <20160929133944.158596-1-mika.westerberg@linux.intel.com> <20160929133944.158596-4-mika.westerberg@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga06.intel.com ([134.134.136.31]:1596 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932289AbcJTM3d (ORCPT ); Thu, 20 Oct 2016 08:29:33 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Linus Walleij Cc: "Rafael J. Wysocki" , Alexandre Courbot , ACPI Devel Maling List , "linux-kernel@vger.kernel.org" On Thu, Oct 20, 2016 at 02:09:30PM +0200, Linus Walleij wrote: > On Thu, Sep 29, 2016 at 3:39 PM, Mika Westerberg > wrote: > > > GPIO hogging means that the GPIO controller can "hog" and configure certain > > GPIOs without need for a driver or userspace to do that. This is useful in > > open-connected boards where BIOS cannot possibly know beforehand which > > devices will be connected to the board. > > > > This adds GPIO hogging mechanism to ACPI analogous to Device Tree. > > > > Signed-off-by: Mika Westerberg > > Overall nice to have the hogs in ACPI too! > > Again here my comment is to break out device_property() and fwnode_* > accessing code to a file shared between ACPI and OF. > > If it makes sense. > > Because the idea was not to invent those abstractions in order to > just use them with ACPI I hope. > > The problem is that some of the code seems to be ACPI-specific, > so if it doesn't work out, I'm also OK to keep it like this. Yeah, this one differs between ACPI and DT and I'm not sure if it can be easily generalized using device_property APIs.