From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [kvm-unit-tests PATCH 10/14] pci: add bdf helpers Date: Thu, 20 Oct 2016 14:55:39 +0200 Message-ID: <20161020125539.6jbickrv52x3mvec@kamzik.brq.redhat.com> References: <1476448852-30062-1-git-send-email-peterx@redhat.com> <1476448852-30062-11-git-send-email-peterx@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, jan.kiszka@web.de, agordeev@redhat.com, rkrcmar@redhat.com, pbonzini@redhat.com To: Peter Xu Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58142 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935180AbcJTMzo (ORCPT ); Thu, 20 Oct 2016 08:55:44 -0400 Content-Disposition: inline In-Reply-To: <1476448852-30062-11-git-send-email-peterx@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Oct 14, 2016 at 08:40:48PM +0800, Peter Xu wrote: > Signed-off-by: Peter Xu > --- > lib/pci.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/pci.h b/lib/pci.h > index b8755ff..6a1c3c9 100644 > --- a/lib/pci.h > +++ b/lib/pci.h > @@ -18,6 +18,12 @@ enum { > #define PCI_BAR_NUM (6) > #define PCI_DEVFN_MAX (256) > > +#define PCI_BDF_GET_DEVFN(x) ((x) & 0xff) > +#define PCI_BDF_GET_BUS(x) (((x) >> 8) & 0xff) > +#define PCI_SLOT(devfn) (((devfn) >> 3) & 0x1f) > +#define PCI_FUNC(devfn) ((devfn) & 0x07) > +#define PCI_BUILD_BDF(bus, devfn) ((bus << 8) | (devfn)) As I mention frequently; I know nothing about PCI, but this doesn't look right to me. DEVFN should be defined as #define PCI_DEVFN(slot, func) ((((slot) & 0x1f) << 3) | ((func) & 0x07)) Care to explain these? Please provide the explanation in the commit message to along with a motivation for adding them. Thanks, drew > + > struct pci_dev { > bool inited; > uint16_t pci_addr; > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html