All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Sean Paul <seanpaul@chromium.org>
Cc: dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: Rename "struct fence" to "struct dma_fence"
Date: Thu, 20 Oct 2016 15:57:06 +0100	[thread overview]
Message-ID: <20161020145706.GB25820@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <CAOw6vbKV6wZ7gGhYhSPRCY_Jmr_igbnQkNdOLuJ910_suF0-Zg@mail.gmail.com>

On Thu, Oct 20, 2016 at 10:39:47AM -0400, Sean Paul wrote:
> On Thu, Oct 20, 2016 at 2:47 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > I plan to usurp the short name of struct fence for a core kernel struct,
> > and so I need to rename the specialised fence/timeline for DMA
> > operations to make room.
> >
> > A consensus was reached in
> > https://lists.freedesktop.org/archives/dri-devel/2016-July/113083.html
> > that making clear this fence applies to DMA operations was a good thing.
> > Since then the patch has grown a bit as usage increases (and we wanted
> > to wait until after the sw_sync destage), so hopefully it remains a good
> > thing!
> >
> > I've pushed the patch to
> >
> > https://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=dma-fence&id=a4a27d87e4fccefb9f9d55f9c73ccab8f2ade3cc
> >
> > as I suspect it might be too large for the list.
> >
> > Highlights of the change:
> >
> >         struct fence -> struct dma_fence (and all fence*() to dma_fence*())
> >         struct fence_array -> struct dma_fence_array
> >
> >         107 files changed, 1174 insertions(+), 1136 deletions(-)
> >
> > Mostly generated with the provided cocci spatch, but even with
> > --include-headers it seemed to miss some headers, and I never quite
> > worked out the substition commands for macros, so there is some grep and
> > replace.
> 
> For the curious (like me), here's the diff between ickle's HEAD and
> what the cocci script outputs:
> 
> http://hastebin.com/udizixoyed.go

Hmm, looks like I had a few changes for dma-fence-array that didn't make
it back into the changelog. And still missed most of the trace_*(), as
only one was used outside.

Most recently used spatch:
https://people.freedesktop.org/~ickle/fence.spatch
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-10-20 14:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-20  6:47 Rename "struct fence" to "struct dma_fence" Chris Wilson
2016-10-20  6:47 ` [PATCH] dma-buf: Rename struct fence to dma_fence Chris Wilson
2016-10-20  7:48   ` Christian König
2016-10-20 12:08   ` Gustavo Padovan
2016-10-20 17:15     ` Sumit Semwal
2016-10-21 12:22       ` Daniel Vetter
2016-10-20 14:08 ` Rename "struct fence" to "struct dma_fence" Daniel Vetter
2016-10-20 14:39 ` Sean Paul
2016-10-20 14:57   ` Chris Wilson [this message]
2016-10-20 15:03     ` Sean Paul
2016-10-25  9:25 ` [PATCH v2] dma-buf: Rename struct fence to dma_fence Chris Wilson
2016-10-25 10:21   ` Daniel Vetter
2016-10-25 11:32   ` [PATCH v3] " Chris Wilson
2016-10-25 12:00   ` [PATCH v4] " Chris Wilson
2016-10-25 12:49     ` Daniel Vetter
2016-10-25 10:16 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-10-25 12:16 ` ✓ Fi.CI.BAT: success for dma-buf: Rename struct fence to dma_fence (rev2) Patchwork
2016-10-25 12:46 ` ✗ Fi.CI.BAT: warning for dma-buf: Rename struct fence to dma_fence (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161020145706.GB25820@nuc-i3427.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=seanpaul@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.