From: David Miller <davem@davemloft.net>
To: sparclinux@vger.kernel.org
Subject: Re: Regression with 4.7.2 on sun4u
Date: Fri, 21 Oct 2016 17:26:45 +0000 [thread overview]
Message-ID: <20161021.132645.2214056203503527673.davem@davemloft.net> (raw)
In-Reply-To: <3fc12066-505b-5f87-cbbe-88593a736162@physik.fu-berlin.de>
From: Rob Gardner <rob.gardner@oracle.com>
Date: Fri, 21 Oct 2016 09:49:30 -0600
> That could be either a stray memory write or a boot time patch gone
> wrong.
It could be that we need to use non-predicting branches in the jump
label implementation. We could be overflowing the branch displacement
range if the kernel being built is really huge.
Something like the following would fix it if true:
diff --git a/arch/sparc/kernel/jump_label.c b/arch/sparc/kernel/jump_label.c
index 59bbeff..841d98e 100644
--- a/arch/sparc/kernel/jump_label.c
+++ b/arch/sparc/kernel/jump_label.c
@@ -19,13 +19,8 @@ void arch_jump_label_transform(struct jump_entry *entry,
if (type = JUMP_LABEL_JMP) {
s32 off = (s32)entry->target - (s32)entry->code;
-#ifdef CONFIG_SPARC64
- /* ba,pt %xcc, . + (off << 2) */
- val = 0x10680000 | ((u32) off >> 2);
-#else
/* ba . + (off << 2) */
val = 0x10800000 | ((u32) off >> 2);
-#endif
} else {
val = 0x01000000;
}
next prev parent reply other threads:[~2016-10-21 17:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 9:22 Regression with 4.7.2 on sun4u John Paul Adrian Glaubitz
2016-09-07 10:01 ` Anatoly Pugachev
2016-10-21 9:12 ` Anatoly Pugachev
2016-10-21 12:57 ` Anatoly Pugachev
2016-10-21 15:00 ` David Miller
2016-10-21 15:49 ` Rob Gardner
2016-10-21 16:35 ` James Clarke
2016-10-21 17:26 ` David Miller [this message]
2016-10-21 17:47 ` James Clarke
2016-10-21 21:52 ` James Clarke
2016-10-22 1:07 ` David Miller
2016-10-22 9:51 ` James Clarke
2016-10-24 18:11 ` David Miller
2016-10-25 0:10 ` James Clarke
2016-10-26 2:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021.132645.2214056203503527673.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.