From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935056AbcJUR6i (ORCPT ); Fri, 21 Oct 2016 13:58:38 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:33314 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933350AbcJUR6d (ORCPT ); Fri, 21 Oct 2016 13:58:33 -0400 Date: Fri, 21 Oct 2016 13:58:28 -0400 (EDT) Message-Id: <20161021.135828.966455231750113733.davem@davemloft.net> To: jarod@redhat.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, asbjorn@asbjorn.st, parameswaran.r7@gmail.com Subject: Re: [PATCH net] net: remove MTU limits on a few ether_setup callers From: David Miller In-Reply-To: <20161021032527.12954-1-jarod@redhat.com> References: <20161021032527.12954-1-jarod@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 21 Oct 2016 10:58:32 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jarod Wilson Date: Thu, 20 Oct 2016 23:25:27 -0400 > These few drivers call ether_setup(), but have no ndo_change_mtu, and thus > were overlooked for changes to MTU range checking behavior. They > previously had no range checks, so for feature-parity, set their min_mtu > to 0 and max_mtu to ETH_MAX_MTU (65535), instead of the 68 and 1500 > inherited from the ether_setup() changes. Fine-tuning can come after we get > back to full feature-parity here. > > CC: netdev@vger.kernel.org > Reported-by: Asbjoern Sloth Toennesen > CC: Asbjoern Sloth Toennesen > CC: R Parameswaran > Signed-off-by: Jarod Wilson Applied. Please use "[PATCH net-next]" in your subject line when a patch targets net-next.