On 2016.10.21 11:06:01 +0300, Dan Carpenter wrote: > submit_context() should return negative error codes and zero on success > but by mistake we made it a bool. I've changed it to int. Also I made > it static because this isn't referenced in any other files. > > This doesn't affect runtime because the return is eventually propogated > to elsp_mmio_write() where it is ignored. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/i915/gvt/execlist.c b/drivers/gpu/drm/i915/gvt/execlist.c > index c50a3d1a5131..bc69ba1842ea 100644 > --- a/drivers/gpu/drm/i915/gvt/execlist.c > +++ b/drivers/gpu/drm/i915/gvt/execlist.c > @@ -616,7 +616,7 @@ static int prepare_mm(struct intel_vgpu_workload *workload) > (list_empty(q) ? NULL : container_of(q->prev, \ > struct intel_vgpu_workload, list)) > > -bool submit_context(struct intel_vgpu *vgpu, int ring_id, > +static int submit_context(struct intel_vgpu *vgpu, int ring_id, > struct execlist_ctx_descriptor_format *desc, > bool emulate_schedule_in) > { Dan, this has been fixed in our recent pull, should hit linux-next very soon. thanks -- Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827