From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934891AbcJUJ1x (ORCPT ); Fri, 21 Oct 2016 05:27:53 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:19118 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932528AbcJUJ1t (ORCPT ); Fri, 21 Oct 2016 05:27:49 -0400 Date: Fri, 21 Oct 2016 12:27:30 +0300 From: Dan Carpenter To: SF Markus Elfring Cc: Jiri Kosina , Geert Uytterhoeven , LKML , kernel-janitors@vger.kernel.org Subject: Re: FRV-setup: Clarification for "source code clean-up"? Message-ID: <20161021092730.GJ4418@mwanda> References: <1405b16a-c470-531d-458d-fb6042b93230@users.sourceforge.net> <81f557b2-40f3-0625-331d-c5b115f1971c@users.sourceforge.net> <20161021075142.GS4469@mwanda> <139f8031-4823-8de4-1a79-0af80f82cd89@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <139f8031-4823-8de4-1a79-0af80f82cd89@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 21, 2016 at 11:11:54AM +0200, SF Markus Elfring wrote: > > It's all about ratios... Each clean up patch has chance of introducing > > a bug. > > Each update suggestion contains a possibility for mistakes. > Yes. But bug fix patches make up for it by fixing stuff. > > > If you only send clean up patches then you only introduce bugs. > > I find such a conclusion questionable with the wording "only". > How are you going to fix bugs if you only send clean ups? > > > We really don't want people sending patches if they introduce more bugs > > than they fix. > > How do you think about to discuss corresponding software development > statistics in more detail? I think normal developers should fix 10 bugs or add a few features for every regression they introduce. I introduced a regression just last week, so that's a normal part of life, but I was at least *trying* to fix a bug when I did it. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Fri, 21 Oct 2016 09:27:30 +0000 Subject: Re: FRV-setup: Clarification for "source code clean-up"? Message-Id: <20161021092730.GJ4418@mwanda> List-Id: References: <1405b16a-c470-531d-458d-fb6042b93230@users.sourceforge.net> <81f557b2-40f3-0625-331d-c5b115f1971c@users.sourceforge.net> <20161021075142.GS4469@mwanda> <139f8031-4823-8de4-1a79-0af80f82cd89@users.sourceforge.net> In-Reply-To: <139f8031-4823-8de4-1a79-0af80f82cd89@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: Jiri Kosina , Geert Uytterhoeven , LKML , kernel-janitors@vger.kernel.org On Fri, Oct 21, 2016 at 11:11:54AM +0200, SF Markus Elfring wrote: > > It's all about ratios... Each clean up patch has chance of introducing > > a bug. > > Each update suggestion contains a possibility for mistakes. > Yes. But bug fix patches make up for it by fixing stuff. > > > If you only send clean up patches then you only introduce bugs. > > I find such a conclusion questionable with the wording "only". > How are you going to fix bugs if you only send clean ups? > > > We really don't want people sending patches if they introduce more bugs > > than they fix. > > How do you think about to discuss corresponding software development > statistics in more detail? I think normal developers should fix 10 bugs or add a few features for every regression they introduce. I introduced a regression just last week, so that's a normal part of life, but I was at least *trying* to fix a bug when I did it. regards, dan carpenter