From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxWFD-0002sa-CW for qemu-devel@nongnu.org; Fri, 21 Oct 2016 05:36:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bxWF9-0007UD-Ke for qemu-devel@nongnu.org; Fri, 21 Oct 2016 05:36:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34216) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bxWF9-0007Tz-FC for qemu-devel@nongnu.org; Fri, 21 Oct 2016 05:36:03 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B405B624C6 for ; Fri, 21 Oct 2016 09:36:02 +0000 (UTC) Date: Fri, 21 Oct 2016 10:35:59 +0100 From: "Daniel P. Berrange" Message-ID: <20161021093559.GB6585@redhat.com> Reply-To: "Daniel P. Berrange" References: <20161019081210.GA2035@work-vm> <20161019084235.GE11194@redhat.com> <87twc8d60e.fsf@dusky.pond.sub.org> <20161019100552.GD2035@work-vm> <20161019101616.GL11194@redhat.com> <87a8e0bkl6.fsf@dusky.pond.sub.org> <20161019122158.GS11194@redhat.com> <20161019180616.GF2035@work-vm> <20161020083730.GC12145@redhat.com> <417509f7-1640-39ca-cf95-06494a0b8ce5@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <417509f7-1640-39ca-cf95-06494a0b8ce5@redhat.com> Subject: Re: [Qemu-devel] chardev's and fd's in monitors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: "Dr. David Alan Gilbert" , Markus Armbruster , qemu-devel@nongnu.org On Thu, Oct 20, 2016 at 06:56:11PM +0200, Paolo Bonzini wrote: > > > On 20/10/2016 10:37, Daniel P. Berrange wrote: > > You have a problem of context - if you have multiple monitors, how do > > you know which to send the error back to if you're not in the event > > loop thread, and thus cur_mon is NULL. With Marc-Andre's series which > > allows proper async command processing it gets even harder, because > > there's potentially many outstanding commands associated with a monitor > > and you need to decide which the error should be given to. > > Why should it even consult the current monitor? Shouldn't errors go to > all HMP monitors when QEMU falls back to error_report? I rather think not - say you're running two monitors, one for issuing commands like hotplug, and in the other just using to query stats/info about the VM. Why should an error about a failed hotplug command pollute the output of the other monitor you're using for querying stats. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|