From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Fri, 21 Oct 2016 10:27:22 +0000 Subject: Re: [patch] drm/i915/gvt: cleanup a type issue in submit_context() Message-Id: <20161021102722.GT4469@mwanda> List-Id: References: <20161021080601.GA28738@elgon.mountain> <20161021082738.2va437v2qzsf7inq@zhen-hp.sh.intel.com> In-Reply-To: <20161021082738.2va437v2qzsf7inq@zhen-hp.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Zhenyu Wang Cc: Daniel Vetter , Jani Nikula , David Airlie , Zhi Wang , Yulei Zhang , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org On Fri, Oct 21, 2016 at 04:27:38PM +0800, Zhenyu Wang wrote: > On 2016.10.21 11:06:01 +0300, Dan Carpenter wrote: > > submit_context() should return negative error codes and zero on success > > but by mistake we made it a bool. I've changed it to int. Also I made > > it static because this isn't referenced in any other files. > > > > This doesn't affect runtime because the return is eventually propogated > > to elsp_mmio_write() where it is ignored. > > > > Signed-off-by: Dan Carpenter > > > > diff --git a/drivers/gpu/drm/i915/gvt/execlist.c b/drivers/gpu/drm/i915/gvt/execlist.c > > index c50a3d1a5131..bc69ba1842ea 100644 > > --- a/drivers/gpu/drm/i915/gvt/execlist.c > > +++ b/drivers/gpu/drm/i915/gvt/execlist.c > > @@ -616,7 +616,7 @@ static int prepare_mm(struct intel_vgpu_workload *workload) > > (list_empty(q) ? NULL : container_of(q->prev, \ > > struct intel_vgpu_workload, list)) > > > > -bool submit_context(struct intel_vgpu *vgpu, int ring_id, > > +static int submit_context(struct intel_vgpu *vgpu, int ring_id, > > struct execlist_ctx_descriptor_format *desc, > > bool emulate_schedule_in) > > { > > Dan, this has been fixed in our recent pull, should hit linux-next very soon. > Could you review elsp_mmio_write() as well? Should we be doing something with that return value? regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [patch] drm/i915/gvt: cleanup a type issue in submit_context() Date: Fri, 21 Oct 2016 13:27:22 +0300 Message-ID: <20161021102722.GT4469@mwanda> References: <20161021080601.GA28738@elgon.mountain> <20161021082738.2va437v2qzsf7inq@zhen-hp.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20161021082738.2va437v2qzsf7inq@zhen-hp.sh.intel.com> Sender: kernel-janitors-owner@vger.kernel.org To: Zhenyu Wang Cc: Daniel Vetter , Jani Nikula , David Airlie , Zhi Wang , Yulei Zhang , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Fri, Oct 21, 2016 at 04:27:38PM +0800, Zhenyu Wang wrote: > On 2016.10.21 11:06:01 +0300, Dan Carpenter wrote: > > submit_context() should return negative error codes and zero on success > > but by mistake we made it a bool. I've changed it to int. Also I made > > it static because this isn't referenced in any other files. > > > > This doesn't affect runtime because the return is eventually propogated > > to elsp_mmio_write() where it is ignored. > > > > Signed-off-by: Dan Carpenter > > > > diff --git a/drivers/gpu/drm/i915/gvt/execlist.c b/drivers/gpu/drm/i915/gvt/execlist.c > > index c50a3d1a5131..bc69ba1842ea 100644 > > --- a/drivers/gpu/drm/i915/gvt/execlist.c > > +++ b/drivers/gpu/drm/i915/gvt/execlist.c > > @@ -616,7 +616,7 @@ static int prepare_mm(struct intel_vgpu_workload *workload) > > (list_empty(q) ? NULL : container_of(q->prev, \ > > struct intel_vgpu_workload, list)) > > > > -bool submit_context(struct intel_vgpu *vgpu, int ring_id, > > +static int submit_context(struct intel_vgpu *vgpu, int ring_id, > > struct execlist_ctx_descriptor_format *desc, > > bool emulate_schedule_in) > > { > > Dan, this has been fixed in our recent pull, should hit linux-next very soon. > Could you review elsp_mmio_write() as well? Should we be doing something with that return value? regards, dan carpenter