From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50530)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1bxYCP-0007Sq-NT
	for qemu-devel@nongnu.org; Fri, 21 Oct 2016 07:41:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1bxYCK-000266-RP
	for qemu-devel@nongnu.org; Fri, 21 Oct 2016 07:41:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58652)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <ehabkost@redhat.com>) id 1bxYCK-00024s-Me
	for qemu-devel@nongnu.org; Fri, 21 Oct 2016 07:41:16 -0400
Date: Fri, 21 Oct 2016 09:41:13 -0200
From: Eduardo Habkost <ehabkost@redhat.com>
Message-ID: <20161021114113.GK5057@thinpad.lan.raisama.net>
References: <1476878743-144953-12-git-send-email-imammedo@redhat.com>
	<1476975522-154506-1-git-send-email-imammedo@redhat.com>
	<20161020185148.GJ5057@thinpad.lan.raisama.net>
	<20161021105327.2bce44f7@nial.brq.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161021105327.2bce44f7@nial.brq.redhat.com>
Subject: Re: [Qemu-devel] [PATCH] fixup! pc: add 'etc/boot-cpus' fw_cfg file
 for machine with more than 255 CPUs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: liuxiaojian6@huawei.com, rkrcmar@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, peterx@redhat.com, kevin@koconnor.net, kraxel@redhat.com, pbonzini@redhat.com, lersek@redhat.com, chao.gao@intel.com

On Fri, Oct 21, 2016 at 10:53:27AM +0200, Igor Mammedov wrote:
> On Thu, 20 Oct 2016 16:51:48 -0200
> Eduardo Habkost <ehabkost@redhat.com> wrote:
> 
> > On Thu, Oct 20, 2016 at 04:58:42PM +0200, Igor Mammedov wrote:
> > > Currently firmware uses 1 byte at 0x5F offset in RTC CMOS
> > > to get number of CPUs present at boot. However 1 byte is
> > > not enough to handle more than 255 CPUs.  So add a new
> > > fw_cfg file that would allow QEMU to tell it.
> > > For compat reasons add file only for machine types that
> > > support more than 255 CPUs.
> > > 
> > > Signed-off-by: Igor Mammedov <imammedo@redhat.com>  
> > 
> > I suggest squashing this into the patch, to clarify why we are
> > setting it to 0.
> > 
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> 
> Could you squash it in while merging series?

I will do.

-- 
Eduardo