All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH 1/3] nvme-cli: follow-on discovery tweaks from thread
Date: Fri, 21 Oct 2016 06:21:31 -0700	[thread overview]
Message-ID: <20161021132130.GA9492@infradead.org> (raw)
In-Reply-To: <1476906187-29183-2-git-send-email-james_p_freyensee@linux.intel.com>

Hi Jay,

I'm not a huge fan with the explicit mention of the Get Log Page
command for th Discovery, but given that no one but us two seems to
care I'm not going to block the patch over it.

The rest of this patch and the connect-all version of it looks fine to
me:

Reviewed-by: Christoph Hellwig <hch at lst.de>

  reply	other threads:[~2016-10-21 13:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-19 19:43 [PATCH 0/3] nvme-cli: fabric doc and tool fixes Jay Freyensee
2016-10-19 19:43 ` [PATCH 1/3] nvme-cli: follow-on discovery tweaks from thread Jay Freyensee
2016-10-21 13:21   ` Christoph Hellwig [this message]
2016-10-19 19:43 ` [PATCH 2/3] nvme-cli: follow-on doc tweaks to nvme-connect-all Jay Freyensee
2016-10-19 19:43 ` [PATCH 3/3] nvme-cli: fix nvme-connect-all using hostnqn Jay Freyensee
2016-10-21 13:22   ` Christoph Hellwig
2016-10-21 14:54     ` J Freyensee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161021132130.GA9492@infradead.org \
    --to=hch@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.