All of lore.kernel.org
 help / color / mirror / Atom feed
* (unknown), 
@ 2016-09-05 15:21 Christoph Hellwig
  2016-09-05 15:21 ` [PATCH] ahci: use pci_alloc_irq_vectors Christoph Hellwig
  0 siblings, 1 reply; 19+ messages in thread
From: Christoph Hellwig @ 2016-09-05 15:21 UTC (permalink / raw)
  To: tj; +Cc: dan.j.williamps, rrichter, linux-ide

Hi Tejun,

this patch converts the ahci driver to use the new PCI MSI/MSI-X
vector allocator.  Note that you need to first pull 4.8-rc4 or -rc5
into the libata for-4.9 branch as it depends on changes added to
mainline after that branch started.


^ permalink raw reply	[flat|nested] 19+ messages in thread
* [PATCH] ahci: use pci_alloc_irq_vectors
  2016-09-05 15:21 (unknown), Christoph Hellwig
@ 2016-09-05 15:21 ` Christoph Hellwig
  2016-09-06 16:39   ` Tejun Heo
  0 siblings, 1 reply; 19+ messages in thread
From: Christoph Hellwig @ 2016-09-05 15:21 UTC (permalink / raw)
  To: tj; +Cc: dan.j.williamps, rrichter, linux-ide

Use the new pci_alloc_irq_vectors API to allocate MSI-X and MSI vectors.
The big advantage over the old code is that we can use the same API for
MSI and MSI-X, and that we don't need to store the MSI-X vector mapping
in driver-private data structures.

This first conversion keeps the probe order as-is: MSI-X multi vector,
MSI multi vector, MSI single vector, MSI-X single vector and last a
single least legacy interrupt line.  There is one small change of
behavior: we now check the "MSI Revert to Single Message" flag for
MSI-X in addition to MSI.

Because the API to find the Linux IRQ number for a MSI/MSI-X vector
is PCI specific, but libahaci is bus-agnostic I had to a
get_irq_vector function pointer to struct ahci_host_priv.  The
alternative would be to move the multi-vector case of ahci_host_activate
to ahci.c and just call ata_host_activate directly from the others
users of ahci_host_activate.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/ata/ahci.c    | 149 +++++++++++---------------------------------------
 drivers/ata/ahci.h    |  24 ++------
 drivers/ata/libahci.c |  11 +++-
 3 files changed, 45 insertions(+), 139 deletions(-)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 90eabaf..ba5f11c 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1400,142 +1400,56 @@ static irqreturn_t ahci_thunderx_irq_handler(int irq, void *dev_instance)
 }
 #endif
 
-/*
- * ahci_init_msix() - optionally enable per-port MSI-X otherwise defer
- * to single msi.
- */
-static int ahci_init_msix(struct pci_dev *pdev, unsigned int n_ports,
-			  struct ahci_host_priv *hpriv, unsigned long flags)
+static int ahci_get_irq_vector(struct ata_host *host, int port)
 {
-	int nvec, i, rc;
-
-	/* Do not init MSI-X if MSI is disabled for the device */
-	if (hpriv->flags & AHCI_HFLAG_NO_MSI)
-		return -ENODEV;
-
-	nvec = pci_msix_vec_count(pdev);
-	if (nvec < 0)
-		return nvec;
-
-	/*
-	 * Proper MSI-X implementations will have a vector per-port.
-	 * Barring that, we prefer single-MSI over single-MSIX.  If this
-	 * check fails (not enough MSI-X vectors for all ports) we will
-	 * be called again with the flag clear iff ahci_init_msi()
-	 * fails.
-	 */
-	if (flags & AHCI_HFLAG_MULTI_MSIX) {
-		if (nvec < n_ports)
-			return -ENODEV;
-		nvec = n_ports;
-	} else if (nvec) {
-		nvec = 1;
-	} else {
-		/*
-		 * Emit dev_err() since this was the non-legacy irq
-		 * method of last resort.
-		 */
-		rc = -ENODEV;
-		goto fail;
-	}
-
-	for (i = 0; i < nvec; i++)
-		hpriv->msix[i].entry = i;
-	rc = pci_enable_msix_exact(pdev, hpriv->msix, nvec);
-	if (rc < 0)
-		goto fail;
-
-	if (nvec > 1)
-		hpriv->flags |= AHCI_HFLAG_MULTI_MSIX;
-	hpriv->irq = hpriv->msix[0].vector; /* for single msi-x */
-
-	return nvec;
-fail:
-	dev_err(&pdev->dev,
-		"failed to enable MSI-X with error %d, # of vectors: %d\n",
-		rc, nvec);
-
-	return rc;
+	return pci_irq_vector(to_pci_dev(host->dev), port);
 }
 
 static int ahci_init_msi(struct pci_dev *pdev, unsigned int n_ports,
 			struct ahci_host_priv *hpriv)
 {
-	int rc, nvec;
+	int nvec;
 
 	if (hpriv->flags & AHCI_HFLAG_NO_MSI)
 		return -ENODEV;
 
-	nvec = pci_msi_vec_count(pdev);
-	if (nvec < 0)
-		return nvec;
-
 	/*
 	 * If number of MSIs is less than number of ports then Sharing Last
 	 * Message mode could be enforced. In this case assume that advantage
 	 * of multipe MSIs is negated and use single MSI mode instead.
 	 */
-	if (nvec < n_ports)
-		goto single_msi;
-
-	rc = pci_enable_msi_exact(pdev, nvec);
-	if (rc == -ENOSPC)
-		goto single_msi;
-	if (rc < 0)
-		return rc;
+	nvec = pci_alloc_irq_vectors(pdev, n_ports, INT_MAX,
+			PCI_IRQ_MSIX | PCI_IRQ_MSI);
+	if (nvec > 0) {
+		if (!(readl(hpriv->mmio + HOST_CTL) & HOST_MRSM)) {
+			hpriv->get_irq_vector = ahci_get_irq_vector;
+			hpriv->flags |= AHCI_HFLAG_MULTI_MSI;
+			return nvec;
+		}
 
-	/* fallback to single MSI mode if the controller enforced MRSM mode */
-	if (readl(hpriv->mmio + HOST_CTL) & HOST_MRSM) {
-		pci_disable_msi(pdev);
+		/*
+		 * Fallback to single MSI mode if the controller enforced MRSM
+		 * mode.
+		 */
 		printk(KERN_INFO "ahci: MRSM is on, fallback to single MSI\n");
-		goto single_msi;
+		pci_free_irq_vectors(pdev);
 	}
 
-	if (nvec > 1)
-		hpriv->flags |= AHCI_HFLAG_MULTI_MSI;
-
-	goto out;
-
-single_msi:
-	nvec = 1;
-
-	rc = pci_enable_msi(pdev);
-	if (rc < 0)
-		return rc;
-out:
-	hpriv->irq = pdev->irq;
-
-	return nvec;
-}
-
-static int ahci_init_interrupts(struct pci_dev *pdev, unsigned int n_ports,
-				struct ahci_host_priv *hpriv)
-{
-	int nvec;
-
 	/*
-	 * Try to enable per-port MSI-X.  If the host is not capable
-	 * fall back to single MSI before finally attempting single
-	 * MSI-X.
+	 * -ENOSPC indicated we don't have enough vectors.  Don't bother trying
+	 * a single vectors for any other error:
 	 */
-	nvec = ahci_init_msix(pdev, n_ports, hpriv, AHCI_HFLAG_MULTI_MSIX);
-	if (nvec >= 0)
+	if (nvec < 0 && nvec != -ENOSPC)
 		return nvec;
 
-	nvec = ahci_init_msi(pdev, n_ports, hpriv);
-	if (nvec >= 0)
-		return nvec;
-
-	/* try single-msix */
-	nvec = ahci_init_msix(pdev, n_ports, hpriv, 0);
-	if (nvec >= 0)
+	/*
+	 * If the host is not capable of supporting per-port vectors, fall
+	 * back to single MSI before finally attempting single MSI-X.
+	 */
+	nvec = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_MSI);
+	if (nvec == 1)
 		return nvec;
-
-	/* legacy intx interrupts */
-	pci_intx(pdev, 1);
-	hpriv->irq = pdev->irq;
-
-	return 0;
+	return pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_MSIX);
 }
 
 static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
@@ -1698,11 +1612,12 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 	if (!host)
 		return -ENOMEM;
 	host->private_data = hpriv;
-	hpriv->msix = devm_kzalloc(&pdev->dev,
-			sizeof(struct msix_entry) * n_ports, GFP_KERNEL);
-	if (!hpriv->msix)
-		return -ENOMEM;
-	ahci_init_interrupts(pdev, n_ports, hpriv);
+
+	if (ahci_init_msi(pdev, n_ports, hpriv) < 0) {
+		/* legacy intx interrupts */
+		pci_intx(pdev, 1);
+	}
+	hpriv->irq = pdev->irq;
 
 	if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss)
 		host->flags |= ATA_HOST_PARALLEL_SCAN;
diff --git a/drivers/ata/ahci.h b/drivers/ata/ahci.h
index 70b06bc..0cc08f8 100644
--- a/drivers/ata/ahci.h
+++ b/drivers/ata/ahci.h
@@ -242,12 +242,10 @@ enum {
 	AHCI_HFLAG_NO_FBS		= (1 << 18), /* no FBS */
 
 #ifdef CONFIG_PCI_MSI
-	AHCI_HFLAG_MULTI_MSI		= (1 << 20), /* multiple PCI MSIs */
-	AHCI_HFLAG_MULTI_MSIX		= (1 << 21), /* per-port MSI-X */
+	AHCI_HFLAG_MULTI_MSI		= (1 << 20), /* per-port MSI(-X) */
 #else
 	/* compile out MSI infrastructure */
 	AHCI_HFLAG_MULTI_MSI		= 0,
-	AHCI_HFLAG_MULTI_MSIX		= 0,
 #endif
 	AHCI_HFLAG_WAKE_BEFORE_STOP	= (1 << 22), /* wake before DMA stop */
 
@@ -351,7 +349,6 @@ struct ahci_host_priv {
 	 * the PHY position in this array.
 	 */
 	struct phy		**phys;
-	struct msix_entry	*msix;		/* Optional MSI-X support */
 	unsigned		nports;		/* Number of ports */
 	void			*plat_data;	/* Other platform data */
 	unsigned int		irq;		/* interrupt line */
@@ -362,22 +359,11 @@ struct ahci_host_priv {
 	 */
 	void			(*start_engine)(struct ata_port *ap);
 	irqreturn_t 		(*irq_handler)(int irq, void *dev_instance);
-};
 
-#ifdef CONFIG_PCI_MSI
-static inline int ahci_irq_vector(struct ahci_host_priv *hpriv, int port)
-{
-	if (hpriv->flags & AHCI_HFLAG_MULTI_MSIX)
-		return hpriv->msix[port].vector;
-	else
-		return hpriv->irq + port;
-}
-#else
-static inline int ahci_irq_vector(struct ahci_host_priv *hpriv, int port)
-{
-	return hpriv->irq;
-}
-#endif
+	/* only required for per-port MSI(-X) support */
+	int			(*get_irq_vector)(struct ata_host *host,
+						  int port);
+};
 
 extern int ahci_ignore_sss;
 
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index 5a1329e..0d028ea 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -2378,7 +2378,7 @@ static int ahci_port_start(struct ata_port *ap)
 	/*
 	 * Switch to per-port locking in case each port has its own MSI vector.
 	 */
-	if (hpriv->flags & (AHCI_HFLAG_MULTI_MSI | AHCI_HFLAG_MULTI_MSIX)) {
+	if (hpriv->flags & AHCI_HFLAG_MULTI_MSI) {
 		spin_lock_init(&pp->lock);
 		ap->lock = &pp->lock;
 	}
@@ -2520,7 +2520,7 @@ static int ahci_host_activate_multi_irqs(struct ata_host *host,
 	 */
 	for (i = 0; i < host->n_ports; i++) {
 		struct ahci_port_priv *pp = host->ports[i]->private_data;
-		int irq = ahci_irq_vector(hpriv, i);
+		int irq = hpriv->get_irq_vector(host, i);
 
 		/* Do not receive interrupts sent by dummy ports */
 		if (!pp) {
@@ -2556,10 +2556,15 @@ int ahci_host_activate(struct ata_host *host, struct scsi_host_template *sht)
 	int irq = hpriv->irq;
 	int rc;
 
-	if (hpriv->flags & (AHCI_HFLAG_MULTI_MSI | AHCI_HFLAG_MULTI_MSIX)) {
+	if (hpriv->flags & AHCI_HFLAG_MULTI_MSI) {
 		if (hpriv->irq_handler)
 			dev_warn(host->dev,
 			         "both AHCI_HFLAG_MULTI_MSI flag set and custom irq handler implemented\n");
+		if (!hpriv->get_irq_vector) {
+			dev_err(host->dev,
+				"AHCI_HFLAG_MULTI_MSI requires ->get_irq_vector!\n");
+			return -EIO;
+		}
 
 		rc = ahci_host_activate_multi_irqs(host, sht);
 	} else {
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 19+ messages in thread
* Re: [PATCH] ahci: use pci_alloc_irq_vectors
  2016-09-05 15:21 ` [PATCH] ahci: use pci_alloc_irq_vectors Christoph Hellwig
@ 2016-09-06 16:39   ` Tejun Heo
  2016-10-20 15:47       ` Robert Richter
  0 siblings, 1 reply; 19+ messages in thread
From: Tejun Heo @ 2016-09-06 16:39 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: dan.j.williamps, rrichter, linux-ide

On Mon, Sep 05, 2016 at 05:21:45PM +0200, Christoph Hellwig wrote:
> Use the new pci_alloc_irq_vectors API to allocate MSI-X and MSI vectors.
> The big advantage over the old code is that we can use the same API for
> MSI and MSI-X, and that we don't need to store the MSI-X vector mapping
> in driver-private data structures.
> 
> This first conversion keeps the probe order as-is: MSI-X multi vector,
> MSI multi vector, MSI single vector, MSI-X single vector and last a
> single least legacy interrupt line.  There is one small change of
> behavior: we now check the "MSI Revert to Single Message" flag for
> MSI-X in addition to MSI.
> 
> Because the API to find the Linux IRQ number for a MSI/MSI-X vector
> is PCI specific, but libahaci is bus-agnostic I had to a
> get_irq_vector function pointer to struct ahci_host_priv.  The
> alternative would be to move the multi-vector case of ahci_host_activate
> to ahci.c and just call ata_host_activate directly from the others
> users of ahci_host_activate.

Applied to libata/for-4.9 after pulling in the mainline.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 19+ messages in thread
* Re: [PATCH] ahci: use pci_alloc_irq_vectors
  2016-09-06 16:39   ` Tejun Heo
@ 2016-10-20 15:47       ` Robert Richter
  0 siblings, 0 replies; 19+ messages in thread
From: Robert Richter @ 2016-10-20 15:47 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Auger Eric, Marc Zyngier, linux-ide, dan.j.williamps,
	Christoph Hellwig, linux-arm-kernel

On 06.09.16 12:39:46, Tejun Heo wrote:
> On Mon, Sep 05, 2016 at 05:21:45PM +0200, Christoph Hellwig wrote:
> > Use the new pci_alloc_irq_vectors API to allocate MSI-X and MSI vectors.
> > The big advantage over the old code is that we can use the same API for
> > MSI and MSI-X, and that we don't need to store the MSI-X vector mapping
> > in driver-private data structures.
> > 
> > This first conversion keeps the probe order as-is: MSI-X multi vector,
> > MSI multi vector, MSI single vector, MSI-X single vector and last a
> > single least legacy interrupt line.  There is one small change of
> > behavior: we now check the "MSI Revert to Single Message" flag for
> > MSI-X in addition to MSI.
> > 
> > Because the API to find the Linux IRQ number for a MSI/MSI-X vector
> > is PCI specific, but libahaci is bus-agnostic I had to a
> > get_irq_vector function pointer to struct ahci_host_priv.  The
> > alternative would be to move the multi-vector case of ahci_host_activate
> > to ahci.c and just call ata_host_activate directly from the others
> > users of ahci_host_activate.
> 
> Applied to libata/for-4.9 after pulling in the mainline.

Hm, this broke SATA on ThunderX. Log below.

I could not yet look into this closer but reverting this patch
helped:

 0b9e2988ab22 ahci: use pci_alloc_irq_vectors

-Robert




[   14.940982] ata1.00: qc timeout (cmd 0x27)
[   14.941017] ata2.00: qc timeout (cmd 0x27)
[   14.941021] ata2.00: failed to read native max address (err_mask=0x4)
[   14.941023] ata2.00: HPA support seems broken, skipping HPA handling
[   14.961969] ata1.00: failed to read native max address (err_mask=0x4)
[   14.968401] ata1.00: HPA support seems broken, skipping HPA handling
[   15.405004] ata2: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
[   15.437004] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
[   20.573007] ata2.00: qc timeout (cmd 0xef)
[   20.573037] ata1.00: qc timeout (cmd 0xef)
[   20.573041] ata1.00: failed to enable AA (error_mask=0x4)
[   20.573044] ata1: limiting SATA link speed to 3.0 Gbps
[   20.591691] ata2.00: failed to enable AA (error_mask=0x4)
[   20.597083] ata2: limiting SATA link speed to 3.0 Gbps
[   21.037003] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   21.043861] ata1.00: ATA-8: WDC WD5003ABYZ-011FA0, 01.01S03, max UDMA/133
[   21.050647] ata1.00: 976773168 sectors, multi 0: LBA48 NCQ (depth 31/32)
[   21.061007] ata2: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   21.067683] ata2.00: ATA-8: WDC WD5003ABYZ-011FA0, 01.01S03, max UDMA/133
[   21.074468] ata2.00: 976773168 sectors, multi 0: LBA48 NCQ (depth 31/32)
[   36.444979] ata1.00: qc timeout (cmd 0xef)
[   36.445011] ata2.00: qc timeout (cmd 0xef)
[   36.445014] ata2.00: failed to set xfermode (err_mask=0x4)
[   36.445016] ata2.00: disabled
[   36.445026] ata2: hard resetting link
[   36.465268] ata1.00: failed to set xfermode (err_mask=0x4)
[   36.470750] ata1.00: disabled
[   36.473718] ata1: hard resetting link
[   36.909003] ata2: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   36.915184] ata2: EH complete
[   36.941013] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   36.947196] ata1: EH complete
[   36.960294] Freeing unused kernel memory: 1024K (fffffe0001f70000 -
fffffe0002070000)

../..

[  161.266664] dracut-initqueue[624]: Warning: dracut-initqueue timeout
- starting timeout scripts
[  161.793311] dracut-initqueue[624]: Warning: dracut-initqueue timeout
- starting timeout scripts
[  162.309073] dracut-initqueue[624]: Warning: dracut-initqueue timeout
- starting timeout scripts

^ permalink raw reply	[flat|nested] 19+ messages in thread
* [PATCH] ahci: use pci_alloc_irq_vectors
@ 2016-10-20 15:47       ` Robert Richter
  0 siblings, 0 replies; 19+ messages in thread
From: Robert Richter @ 2016-10-20 15:47 UTC (permalink / raw)
  To: linux-arm-kernel

On 06.09.16 12:39:46, Tejun Heo wrote:
> On Mon, Sep 05, 2016 at 05:21:45PM +0200, Christoph Hellwig wrote:
> > Use the new pci_alloc_irq_vectors API to allocate MSI-X and MSI vectors.
> > The big advantage over the old code is that we can use the same API for
> > MSI and MSI-X, and that we don't need to store the MSI-X vector mapping
> > in driver-private data structures.
> > 
> > This first conversion keeps the probe order as-is: MSI-X multi vector,
> > MSI multi vector, MSI single vector, MSI-X single vector and last a
> > single least legacy interrupt line.  There is one small change of
> > behavior: we now check the "MSI Revert to Single Message" flag for
> > MSI-X in addition to MSI.
> > 
> > Because the API to find the Linux IRQ number for a MSI/MSI-X vector
> > is PCI specific, but libahaci is bus-agnostic I had to a
> > get_irq_vector function pointer to struct ahci_host_priv.  The
> > alternative would be to move the multi-vector case of ahci_host_activate
> > to ahci.c and just call ata_host_activate directly from the others
> > users of ahci_host_activate.
> 
> Applied to libata/for-4.9 after pulling in the mainline.

Hm, this broke SATA on ThunderX. Log below.

I could not yet look into this closer but reverting this patch
helped:

 0b9e2988ab22 ahci: use pci_alloc_irq_vectors

-Robert




[   14.940982] ata1.00: qc timeout (cmd 0x27)
[   14.941017] ata2.00: qc timeout (cmd 0x27)
[   14.941021] ata2.00: failed to read native max address (err_mask=0x4)
[   14.941023] ata2.00: HPA support seems broken, skipping HPA handling
[   14.961969] ata1.00: failed to read native max address (err_mask=0x4)
[   14.968401] ata1.00: HPA support seems broken, skipping HPA handling
[   15.405004] ata2: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
[   15.437004] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
[   20.573007] ata2.00: qc timeout (cmd 0xef)
[   20.573037] ata1.00: qc timeout (cmd 0xef)
[   20.573041] ata1.00: failed to enable AA (error_mask=0x4)
[   20.573044] ata1: limiting SATA link speed to 3.0 Gbps
[   20.591691] ata2.00: failed to enable AA (error_mask=0x4)
[   20.597083] ata2: limiting SATA link speed to 3.0 Gbps
[   21.037003] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   21.043861] ata1.00: ATA-8: WDC WD5003ABYZ-011FA0, 01.01S03, max UDMA/133
[   21.050647] ata1.00: 976773168 sectors, multi 0: LBA48 NCQ (depth 31/32)
[   21.061007] ata2: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   21.067683] ata2.00: ATA-8: WDC WD5003ABYZ-011FA0, 01.01S03, max UDMA/133
[   21.074468] ata2.00: 976773168 sectors, multi 0: LBA48 NCQ (depth 31/32)
[   36.444979] ata1.00: qc timeout (cmd 0xef)
[   36.445011] ata2.00: qc timeout (cmd 0xef)
[   36.445014] ata2.00: failed to set xfermode (err_mask=0x4)
[   36.445016] ata2.00: disabled
[   36.445026] ata2: hard resetting link
[   36.465268] ata1.00: failed to set xfermode (err_mask=0x4)
[   36.470750] ata1.00: disabled
[   36.473718] ata1: hard resetting link
[   36.909003] ata2: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   36.915184] ata2: EH complete
[   36.941013] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   36.947196] ata1: EH complete
[   36.960294] Freeing unused kernel memory: 1024K (fffffe0001f70000 -
fffffe0002070000)

../..

[  161.266664] dracut-initqueue[624]: Warning: dracut-initqueue timeout
- starting timeout scripts
[  161.793311] dracut-initqueue[624]: Warning: dracut-initqueue timeout
- starting timeout scripts
[  162.309073] dracut-initqueue[624]: Warning: dracut-initqueue timeout
- starting timeout scripts

^ permalink raw reply	[flat|nested] 19+ messages in thread
* Re: [PATCH] ahci: use pci_alloc_irq_vectors
  2016-10-20 15:47       ` Robert Richter
@ 2016-10-21 12:59         ` Christoph Hellwig
  -1 siblings, 0 replies; 19+ messages in thread
From: Christoph Hellwig @ 2016-10-21 12:59 UTC (permalink / raw)
  To: Robert Richter
  Cc: Tejun Heo, Christoph Hellwig, dan.j.williamps, linux-ide,
	linux-arm-kernel, Marc Zyngier, Auger Eric

Hi Robert,

can you try the latest fixed in the libata tree:

https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/log/?h=for-4.9-fixes

^ permalink raw reply	[flat|nested] 19+ messages in thread
* [PATCH] ahci: use pci_alloc_irq_vectors
@ 2016-10-21 12:59         ` Christoph Hellwig
  0 siblings, 0 replies; 19+ messages in thread
From: Christoph Hellwig @ 2016-10-21 12:59 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Robert,

can you try the latest fixed in the libata tree:

https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/log/?h=for-4.9-fixes

^ permalink raw reply	[flat|nested] 19+ messages in thread
* Re: [PATCH] ahci: use pci_alloc_irq_vectors
  2016-10-21 12:59         ` Christoph Hellwig
@ 2016-10-21 14:01           ` Robert Richter
  -1 siblings, 0 replies; 19+ messages in thread
From: Robert Richter @ 2016-10-21 14:01 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Robert Richter, Auger Eric, Marc Zyngier, linux-ide,
	dan.j.williamps, Tejun Heo, linux-arm-kernel

Christoph,

On 21.10.16 14:59:18, Christoph Hellwig wrote:
> can you try the latest fixed in the libata tree:
> 
> https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/log/?h=for-4.9-fixes

I see now this warning:

 WARNING: CPU: 0 PID: 1601 at drivers/ata/libata-core.c:6426 ata_host_activate+0x138/0x150

... and it still fails:

[   21.765921] ata1.00: qc timeout (cmd 0xec)
[   21.770031] ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   22.249869] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
[   22.533896] ata4.00: qc timeout (cmd 0xec)
[   22.537996] ata4.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   23.017874] ata4: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
[   32.261874] ata1.00: qc timeout (cmd 0xec)
[   32.265972] ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   32.272059] ata1: limiting SATA link speed to 3.0 Gbps
[   32.753873] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   33.029878] ata4.00: qc timeout (cmd 0xec)
[   33.033978] ata4.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   33.040066] ata4: limiting SATA link speed to 3.0 Gbps
[   33.521884] ata4: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   63.493874] ata1.00: qc timeout (cmd 0xec)
[   63.497973] ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   63.977867] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   65.541890] ata4.00: qc timeout (cmd 0xec)
[   65.545987] ata4.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   66.025873] ata4: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   66.032337] VFS: Cannot open root device "sda2" or unknown-block(0,0): error -6
[   66.039682] Please append a correct "root=" boot option; here are the available partitions:
[   66.048047] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0)

Full log below.

(Note that I tested a backported version based on 4.8 with all your 3
patches applied.)

-Robert


[   15.740362] ahci 0001:00:08.0: version 3.0
[   15.744577] ahci 0001:00:08.0: AHCI 0001.0300 32 slots 1 ports 6 Gbps 0x1 impl SATA mode
[   15.752670] ahci 0001:00:08.0: flags: 64bit ncq sntf ilck pm led clo only pmp fbs pio slum part ccc apst 
[   15.762239] ahci 0001:00:08.0: port 0 is not capable of FBS
[   15.767996] ------------[ cut here ]------------
[   15.772610] WARNING: CPU: 0 PID: 1601 at drivers/ata/libata-core.c:6426 ata_host_activate+0x138/0x150
[   15.781815] 
[   15.783298] CPU: 0 PID: 1601 Comm: kworker/0:1 Tainted: G        W       4.8.1-00004-gf0dadca853a2 #171
[   15.792677] Hardware name: www.cavium.com ThunderX CRB-2S/ThunderX CRB-2S, BIOS 0.3 Sep 13 2016
[   15.801365] Workqueue: events work_for_cpu_fn
[   15.805714] task: ffff800fcb5e4e00 task.stack: ffff800fcb618000
[   15.811622] PC is at ata_host_activate+0x138/0x150
[   15.816401] LR is at ata_host_activate+0x5c/0x150
[   15.821094] pc : [<ffff0000087b7868>] lr : [<ffff0000087b778c>] pstate: 60000045
[   15.828476] sp : ffff800fcb61bbb0
[   15.831780] x29: ffff800fcb61bbb0 x28: 0000000000000001 
[   15.837085] x27: ffff000009245408 x26: ffff000009245bf0 
[   15.842391] x25: ffff800fca8e40a0 x24: ffff800fcb451118 
[   15.847695] x23: 0000000000000080 x22: ffff000009245bf0 
[   15.853000] x21: 0000000000000000 x20: ffff0000087cddc8 
[   15.858305] x19: ffff800fcb451218 x18: ffff0000892f7d77 
[   15.863610] x17: ffff7fe003f2e820 x16: ffffffffffffff98 
[   15.868915] x15: 0000000000000006 x14: ffff0000092f7d85 
[   15.874220] x13: ffff00000979ffff x12: 0000000000000008 
[   15.879525] x11: 0088000000000000 x10: 0140000000000040 
[   15.884829] x9 : 0000000000000000 x8 : ffff000009796500 
[   15.890135] x7 : 0000000000000006 x6 : ffff800fcb618000 
[   15.895439] x5 : ffff800fcb901b00 x4 : 0000000000000000 
[   15.900744] x3 : ffff00001b000104 x2 : ffff800fcb451118 
[   15.906049] x1 : 0000000000000040 x0 : 0000000000000000 
[   15.911354] 
[   15.912835] ---[ end trace 2c145cc81872d49e ]---
[   15.917440] Call trace:
[   15.919876] Exception stack(0xffff800fcb61b9e0 to 0xffff800fcb61bb10)
[   15.926306] b9e0: ffff800fcb451218 0001000000000000 ffff800fcb61bbb0 ffff0000087b7868
[   15.934124] ba00: ffff000009780000 0000000000020000 0000000000000008 00e800000000070f
[   15.941942] ba20: 0000000000000000 ffff7fe000300100 ffff800fcb61bab0 ffff000008776250
[   15.949760] ba40: ffff800fca8e40a0 ffff800fca8e4150 0000000000000004 0000000000000040
[   15.957578] ba60: 0000000000016500 ffff800fcb451118 ffff800fcb61bab0 ffff0000087d10e8
[   15.965396] ba80: 0000000000000000 0000000000000040 ffff800fcb451118 ffff00001b000104
[   15.973214] baa0: 0000000000000000 ffff800fcb901b00 ffff800fcb618000 0000000000000006
[   15.981032] bac0: ffff000009796500 0000000000000000 0140000000000040 0088000000000000
[   15.988849] bae0: 0000000000000008 ffff00000979ffff ffff0000092f7d85 0000000000000006
[   15.996667] bb00: ffffffffffffff98 ffff7fe003f2e820
[   16.001533] [<ffff0000087b7868>] ata_host_activate+0x138/0x150
[   16.007356] [<ffff0000087d2950>] ahci_host_activate+0x138/0x170
[   16.013264] [<ffff0000087ced84>] ahci_init_one+0x8d4/0xd50
[   16.018740] [<ffff00000850f394>] local_pci_probe+0x3c/0xb8
[   16.024214] [<ffff0000080cc458>] work_for_cpu_fn+0x18/0x28
[   16.029689] [<ffff0000080ce710>] process_one_work+0x118/0x378
[   16.035424] [<ffff0000080cebd8>] worker_thread+0x268/0x4b0
[   16.040900] [<ffff0000080d4c10>] kthread+0xd0/0xe8
[   16.045680] [<ffff000008082e90>] ret_from_fork+0x10/0x40
[   16.051483] scsi host0: ahci
[   16.054531] ata1: SATA max UDMA/133 abar m2097152@0x814000000000 port 0x814000000100
[   16.062464] ahci 0001:00:09.0: AHCI 0001.0300 32 slots 1 ports 6 Gbps 0x1 impl SATA mode
[   16.070558] ahci 0001:00:09.0: flags: 64bit ncq sntf ilck pm led clo only pmp fbs pio slum part ccc apst 
[   16.080121] ahci 0001:00:09.0: port 0 is not capable of FBS
[   16.085790] ------------[ cut here ]------------
[   16.090400] WARNING: CPU: 0 PID: 1601 at drivers/ata/libata-core.c:6426 ata_host_activate+0x138/0x150
[   16.099604] 
[   16.101086] CPU: 0 PID: 1601 Comm: kworker/0:1 Tainted: G        W       4.8.1-00004-gf0dadca853a2 #171
[   16.110464] Hardware name: www.cavium.com ThunderX CRB-2S/ThunderX CRB-2S, BIOS 0.3 Sep 13 2016
[   16.119150] Workqueue: events work_for_cpu_fn
[   16.123498] task: ffff800fcb5e4e00 task.stack: ffff800fcb618000
[   16.129406] PC is at ata_host_activate+0x138/0x150
[   16.134186] LR is at ata_host_activate+0x5c/0x150
[   16.138878] pc : [<ffff0000087b7868>] lr : [<ffff0000087b778c>] pstate: 60000045
[   16.146260] sp : ffff800fcb61bbb0
[   16.149563] x29: ffff800fcb61bbb0 x28: 0000000000000001 
[   16.154868] x27: ffff000009245408 x26: ffff000009245bf0 
[   16.160172] x25: ffff800fca8e60a0 x24: ffff800fcb45ff18 
[   16.165477] x23: 0000000000000080 x22: ffff000009245bf0 
[   16.170781] x21: 0000000000000000 x20: ffff0000087cddc8 
[   16.176086] x19: ffff800fcb45fe18 x18: ffff0000892f7d77 
[   16.181390] x17: ffff7fe040029e60 x16: ffffffffffffff98 
[   16.186695] x15: 0000000000000006 x14: ffff0000092f7d85 
[   16.192000] x13: ffff000009f3ffff x12: 0000000000000008 
[   16.197304] x11: 0088000000000000 x10: 0140000000000040 
[   16.202608] x9 : 0000000000000000 x8 : ffff000009f36500 
[   16.207913] x7 : 0000000000000006 x6 : ffff800fcb618000 
[   16.213218] x5 : ffff800fcb903900 x4 : 0000000000000000 
[   16.218522] x3 : ffff00001b400104 x2 : ffff800fcb45ff18 
[   16.223827] x1 : 0000000000000040 x0 : 0000000000000000 
[   16.229131] 
[   16.230612] ---[ end trace 2c145cc81872d49f ]---
[   16.235216] Call trace:
[   16.237652] Exception stack(0xffff800fcb61b9e0 to 0xffff800fcb61bb10)
[   16.244081] b9e0: ffff800fcb45fe18 0001000000000000 ffff800fcb61bbb0 ffff0000087b7868
[   16.251899] ba00: ffff000009f20000 0000000000020000 0000000000000008 00e800000000070f
[   16.259717] ba20: 0000000000000000 ffff7fe000300180 ffff800fcb61bab0 ffff000008776250
[   16.267535] ba40: ffff800fca8e60a0 ffff800fca8e6150 0000000000000004 0000000000000040
[   16.275353] ba60: 0000000000016500 ffff800fcb45ff18 ffff800fcb61bab0 ffff0000087d10e8
[   16.283170] ba80: 0000000000000000 0000000000000040 ffff800fcb45ff18 ffff00001b400104
[   16.290988] baa0: 0000000000000000 ffff800fcb903900 ffff800fcb618000 0000000000000006
[   16.298806] bac0: ffff000009f36500 0000000000000000 0140000000000040 0088000000000000
[   16.306623] bae0: 0000000000000008 ffff000009f3ffff ffff0000092f7d85 0000000000000006
[   16.314440] bb00: ffffffffffffff98 ffff7fe040029e60
[   16.319307] [<ffff0000087b7868>] ata_host_activate+0x138/0x150
[   16.325128] [<ffff0000087d2950>] ahci_host_activate+0x138/0x170
[   16.331036] [<ffff0000087ced84>] ahci_init_one+0x8d4/0xd50
[   16.336510] [<ffff00000850f394>] local_pci_probe+0x3c/0xb8
[   16.341985] [<ffff0000080cc458>] work_for_cpu_fn+0x18/0x28
[   16.347458] [<ffff0000080ce710>] process_one_work+0x118/0x378
[   16.353192] [<ffff0000080cebd8>] worker_thread+0x268/0x4b0
[   16.358667] [<ffff0000080d4c10>] kthread+0xd0/0xe8
[   16.363447] [<ffff000008082e90>] ret_from_fork+0x10/0x40
[   16.369153] scsi host1: ahci
[   16.372172] ata2: SATA max UDMA/133 abar m2097152@0x815000000000 port 0x815000000100
[   16.380095] ahci 0001:00:0a.0: AHCI 0001.0300 32 slots 1 ports 6 Gbps 0x1 impl SATA mode
[   16.388189] ahci 0001:00:0a.0: flags: 64bit ncq sntf ilck pm led clo only pmp fbs pio slum part ccc apst 
[   16.397752] ahci 0001:00:0a.0: port 0 is not capable of FBS
[   16.403423] ------------[ cut here ]------------
[   16.408033] WARNING: CPU: 0 PID: 1601 at drivers/ata/libata-core.c:6426 ata_host_activate+0x138/0x150
[   16.417238] 
[   16.418719] CPU: 0 PID: 1601 Comm: kworker/0:1 Tainted: G        W       4.8.1-00004-gf0dadca853a2 #171
[   16.428098] Hardware name: www.cavium.com ThunderX CRB-2S/ThunderX CRB-2S, BIOS 0.3 Sep 13 2016
[   16.436784] Workqueue: events work_for_cpu_fn
[   16.441131] task: ffff800fcb5e4e00 task.stack: ffff800fcb618000
[   16.447039] PC is at ata_host_activate+0x138/0x150
[   16.451818] LR is at ata_host_activate+0x5c/0x150
[   16.456511] pc : [<ffff0000087b7868>] lr : [<ffff0000087b778c>] pstate: 60000045
[   16.463893] sp : ffff800fcb61bbb0
[   16.467196] x29: ffff800fcb61bbb0 x28: 0000000000000001 
[   16.472501] x27: ffff000009245408 x26: ffff000009245bf0 
[   16.477806] x25: ffff800fca8e80a0 x24: ffff800fcb451b18 
[   16.483111] x23: 0000000000000080 x22: ffff000009245bf0 
[   16.488415] x21: 0000000000000000 x20: ffff0000087cddc8 
[   16.493720] x19: ffff800fcb451c18 x18: ffff0000892f7d77 
[   16.499025] x17: ffff7fe003f2e6a0 x16: ffffffffffffff98 
[   16.504330] x15: 0000000000000006 x14: ffff0000092f7d85 
[   16.509634] x13: ffff000009f6ffff x12: 0000000000000008 
[   16.514939] x11: 0088000000000000 x10: 0140000000000040 
[   16.520244] x9 : 0000000000000000 x8 : ffff000009f66500 
[   16.525548] x7 : 0000000000000006 x6 : ffff800fcb618000 
[   16.530853] x5 : ffff800fcb905780 x4 : 0000000000000000 
[   16.536158] x3 : ffff00001b800104 [   16.537881] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)

[   16.545541] x2 : ffff800fcb451b18 
[   16.549110] x1 : 0000000000000040 x0 : 0000000000000000 
[   16.554414] 
[   16.555893] ---[ end trace 2c145cc81872d4a0 ]---
[   16.560499] Call trace:
[   16.562934] Exception stack(0xffff800fcb61b9e0 to 0xffff800fcb61bb10)
[   16.569363] b9e0: ffff800fcb451c18 0001000000000000 ffff800fcb61bbb0 ffff0000087b7868
[   16.577181] ba00: ffff000009f50000 0000000000020000 0000000000000008 00e800000000070f
[   16.584999] ba20: 0000000000000000 ffff7fe000300200 ffff800fcb61bab0 ffff000008776250
[   16.592817] ba40: ffff800fca8e80a0 ffff800fca8e8150 0000000000000004 0000000000000040
[   16.600634] ba60: 0000000000016500 ffff800fcb451b18 ffff800fcb61bab0 ffff0000087d10e8
[   16.608452] ba80: 0000000000000000 0000000000000040 ffff800fcb451b18 ffff00001b800104
[   16.616270] baa0: 0000000000000000 ffff800fcb905780 ffff800fcb618000 0000000000000006
[   16.624088] bac0: ffff000009f66500 0000000000000000 0140000000000040 0088000000000000
[   16.631905] bae0: 0000000000000008 ffff000009f6ffff ffff0000092f7d85 0000000000000006
[   16.639723] bb00: ffffffffffffff98 ffff7fe003f2e6a0
[   16.644589] [<ffff0000087b7868>] ata_host_activate+0x138/0x150
[   16.650411] [<ffff0000087d2950>] ahci_host_activate+0x138/0x170
[   16.656318] [<ffff0000087ced84>] ahci_init_one+0x8d4/0xd50
[   16.661793] [<ffff00000850f394>] local_pci_probe+0x3c/0xb8
[   16.667266] [<ffff0000080cc458>] work_for_cpu_fn+0x18/0x28
[   16.672741] [<ffff0000080ce710>] process_one_work+0x118/0x378
[   16.678475] [<ffff0000080cebd8>] worker_thread+0x268/0x4b0
[   16.683949] [<ffff0000080d4c10>] kthread+0xd0/0xe8
[   16.688728] [<ffff000008082e90>] ret_from_fork+0x10/0x40
[   16.692073] ata2: SATA link down (SStatus 0 SControl 300)
[   16.699826] scsi host2: ahci
[   16.702835] ata3: SATA max UDMA/133 abar m2097152@0x816000000000 port 0x816000000100
[   16.710759] ahci 0001:00:0b.0: AHCI 0001.0300 32 slots 1 ports 6 Gbps 0x1 impl SATA mode
[   16.718852] ahci 0001:00:0b.0: flags: 64bit ncq sntf ilck pm led clo only pmp fbs pio slum part ccc apst 
[   16.728416] ahci 0001:00:0b.0: port 0 is not capable of FBS
[   16.734084] ------------[ cut here ]------------
[   16.738693] WARNING: CPU: 0 PID: 1601 at drivers/ata/libata-core.c:6426 ata_host_activate+0x138/0x150
[   16.747898] 
[   16.749379] CPU: 0 PID: 1601 Comm: kworker/0:1 Tainted: G        W       4.8.1-00004-gf0dadca853a2 #171
[   16.758758] Hardware name: www.cavium.com ThunderX CRB-2S/ThunderX CRB-2S, BIOS 0.3 Sep 13 2016
[   16.767444] Workqueue: events work_for_cpu_fn
[   16.771792] task: ffff800fcb5e4e00 task.stack: ffff800fcb618000
[   16.777699] PC is at ata_host_activate+0x138/0x150
[   16.782479] LR is at ata_host_activate+0x5c/0x150
[   16.787171] pc : [<ffff0000087b7868>] lr : [<ffff0000087b778c>] pstate: 60000045
[   16.794553] sp : ffff800fcb61bbb0
[   16.797856] x29: ffff800fcb61bbb0 x28: 0000000000000001 
[   16.803161] x27: ffff000009245408 x26: ffff000009245bf0 
[   16.808466] x25: ffff800fca8ea0a0 x24: ffff800fcb45f518 
[   16.813770] x23: 0000000000000080 x22: ffff000009245bf0 
[   16.819075] x21: 0000000000000000 x20: ffff0000087cddc8 
[   16.824380] x19: ffff800fcb45f418 x18: ffff0000892f7d77 
[   16.829685] x17: ffff7fe003f2e6a0 x16: ffffffffffffff98 
[   16.834989] x15: 0000000000000006 x14: ffff0000092f7d85 
[   16.840294] x13: ffff000009fbffff x12: 0000000000000008 
[   16.845599] x11: 0088000000000000 x10: 0140000000000040 
[   16.850903] x9 : 0000000000000000 x8 : ffff000009fb6500 
[   16.856208] x7 : 0000000000000006 x6 : ffff800fcb618000 
[   16.861512] x5 : ffff800fcb907500 x4 : 0000000000000000 
[   16.866817] x3 : ffff00001bc00104 x2 : ffff800fcb45f518 
[   16.872122] x1 : 0000000000000040 x0 : 0000000000000000 
[   16.877426] 
[   16.878906] ---[ end trace 2c145cc81872d4a1 ]---
[   16.883511] Call trace:
[   16.885946] Exception stack(0xffff800fcb61b9e0 to 0xffff800fcb61bb10)
[   16.892376] b9e0: ffff800fcb45f418 0001000000000000 ffff800fcb61bbb0 ffff0000087b7868
[   16.900194] ba00: ffff000009fa0000 0000000000020000 0000000000000008 00e800000000070f
[   16.908011] ba20: 0000000000000000 ffff7fe000300280 ffff800fcb61bab0 ffff000008776250
[   16.915829] ba40: ffff800fca8ea0a0 ffff800fca8ea150 0000000000000004 0000000000000040
[   16.923647] ba60: 0000000000016500 ffff800fcb45f518 ffff800fcb61bab0 ffff0000087d10e8
[   16.931465] ba80: 0000000000000000 0000000000000040 ffff800fcb45f518 ffff00001bc00104
[   16.939283] baa0: 0000000000000000 ffff800fcb907500 ffff800fcb618000 0000000000000006
[   16.947101] bac0: ffff000009fb6500 0000000000000000 0140000000000040 0088000000000000
[   16.954918] bae0: 0000000000000008 ffff000009fbffff ffff0000092f7d85 0000000000000006
[   16.962735] bb00: ffffffffffffff98 ffff7fe003f2e6a0
[   16.967602] [<ffff0000087b7868>] ata_host_activate+0x138/0x150
[   16.973424] [<ffff0000087d2950>] ahci_host_activate+0x138/0x170
[   16.979332] [<ffff0000087ced84>] ahci_init_one+0x8d4/0xd50
[   16.984805] [<ffff00000850f394>] local_pci_probe+0x3c/0xb8
[   16.990280] [<ffff0000080cc458>] work_for_cpu_fn+0x18/0x28
[   16.995753] [<ffff0000080ce710>] process_one_work+0x118/0x378
[   17.001488] [<ffff0000080cebd8>] worker_thread+0x268/0x4b0
[   17.006963] [<ffff0000080d4c10>] kthread+0xd0/0xe8
[   17.011742] [<ffff000008082e90>] ret_from_fork+0x10/0x40
[   17.017465] scsi host3: ahci
[   17.020476] ata4: SATA max UDMA/133 abar m2097152@0x817000000000 port 0x817000000100
[   17.024054] ata3: SATA link down (SStatus 0 SControl 300)
[   17.033978] ahci 0005:00:08.0: AHCI 0001.0300 32 slots 1 ports 6 Gbps 0x1 impl SATA mode
[   17.042077] ahci 0005:00:08.0: flags: 64bit ncq sntf ilck pm led clo only pmp fbs pio slum part ccc apst 
[   17.051650] ahci 0005:00:08.0: port 0 is not capable of FBS
[   17.057638] ------------[ cut here ]------------
[   17.062263] WARNING: CPU: 49 PID: 1 at drivers/ata/libata-core.c:6426 ata_host_activate+0x138/0x150
[   17.071295] 
[   17.072781] CPU: 49 PID: 1 Comm: swapper/0 Tainted: G        W       4.8.1-00004-gf0dadca853a2 #171
[   17.081814] Hardware name: www.cavium.com ThunderX CRB-2S/ThunderX CRB-2S, BIOS 0.3 Sep 13 2016
[   17.090500] task: ffff800fc8340000 task.stack: ffff810000484000
[   17.096409] PC is at ata_host_activate+0x138/0x150
[   17.101190] LR is at ata_host_activate+0x5c/0x150
[   17.105883] pc : [<ffff0000087b7868>] lr : [<ffff0000087b778c>] pstate: 60000045
[   17.113266] sp : ffff810000487a90
[   17.116570] x29: ffff810000487a90 x28: 0000000000000001 
[   17.121879] x27: ffff000009245408 x26: ffff000009245bf0 
[   17.127187] x25: ffff8100084810a0 x24: ffff81000a705018 
[   17.132495] x23: 0000000000000080 x22: ffff000009245bf0 
[   17.137803] x21: 0000000000000000 x20: ffff0000087cddc8 
[   17.143110] x19: ffff81000a705118 x18: ffff0000892f7d77 
[   17.148418] x17: ffff7fe003f2e620 x16: 0000000000000002 
[   17.153726] x15: 0000000000000006 x14: ffff0000092f7d85 
[   17.159033] x13: ffff00000a62ffff x12: 0000000000000008 
[   17.164341] x11: 0088000000000000 x10: 0140000000000040 
[   17.169649] x9 : 0000000000000000 x8 : ffff00000a626500 
[   17.174956] x7 : 0000000000000006 x6 : ffff810000484000 
[   17.180264] x5 : ffff81000a71f480 x4 : 0000000000000000 
[   17.185571] x3 : ffff00001e400104 x2 : ffff81000a705018 
[   17.190879] x1 : 0000000000000040 x0 : 0000000000000000 
[   17.196186] 
[   17.197667] ---[ end trace 2c145cc81872d4a2 ]---
[   17.202274] Call trace:
[   17.204712] Exception stack(0xffff8100004878c0 to 0xffff8100004879f0)
[   17.211143] 78c0: ffff81000a705118 0001000000000000 ffff810000487a90 ffff0000087b7868
[   17.218961] 78e0: ffff00000a610000 0000000000020000 0000000000000008 00e800000000070f
[   17.226780] 7900: 0000000000000000 ffff7fe000300300 ffff810000487990 ffff000008776250
[   17.234598] 7920: ffff8100084810a0 ffff810008481150 0000000000000004 0000000000000040
[   17.242417] 7940: 0000000000016500 ffff81000a705018 ffff810000487990 ffff0000087d10e8
[   17.250235] 7960: 0000000000000000 0000000000000040 ffff81000a705018 ffff00001e400104
[   17.258054] 7980: 0000000000000000 ffff81000a71f480 ffff810000484000 0000000000000006
[   17.265872] 79a0: ffff00000a626500 0000000000000000 0140000000000040 0088000000000000
[   17.273691] 79c0: 0000000000000008 ffff00000a62ffff ffff0000092f7d85 0000000000000006
[   17.281508] 79e0: 0000000000000002 ffff7fe003f2e620
[   17.286376] [<ffff0000087b7868>] ata_host_activate+0x138/0x150
[   17.292201] [<ffff0000087d2950>] ahci_host_activate+0x138/0x170
[   17.298111] [<ffff0000087ced84>] ahci_init_one+0x8d4/0xd50
[   17.303590] [<ffff00000850f394>] local_pci_probe+0x3c/0xb8
[   17.309065] [<ffff000008510330>] pci_device_probe+0x110/0x148
[   17.314808] [<ffff00000876ac54>] driver_probe_device+0x204/0x2b0
[   17.320803] [<ffff00000876adac>] __driver_attach+0xac/0xb0
[   17.326279] [<ffff000008768d24>] bus_for_each_dev+0x5c/0xa0
[   17.331840] [<ffff00000876aee8>] driver_attach+0x20/0x28
[   17.337141] [<ffff0000087697d0>] bus_add_driver+0x1c8/0x230
[   17.342703] [<ffff00000876b620>] driver_register+0x60/0xf8
[   17.348178] [<ffff0000085103a0>] __pci_register_driver+0x38/0x40
[   17.354183] [<ffff0000090b2fec>] ahci_pci_driver_init+0x20/0x28
[   17.360100] [<ffff000009080c88>] do_one_initcall+0x84/0x114
[   17.365662] [<ffff000009080ed0>] kernel_init_freeable+0x1b8/0x25c
[   17.371754] [<ffff000008c20f30>] kernel_init+0x10/0x108
[   17.376972] [<ffff000008082e90>] ret_from_fork+0x10/0x40
[   17.382862] scsi host4: ahci
[   17.385910] ata5: SATA max UDMA/133 abar m2097152@0x914000000000 port 0x914000000100
[   17.393763] ahci 0005:00:09.0: AHCI 0001.0300 32 slots 1 ports 6 Gbps 0x1 impl SATA mode
[   17.401864] ahci 0005:00:09.0: flags: 64bit ncq sntf ilck pm led clo only pmp fbs pio slum part ccc apst 
[   17.411425] ahci 0005:00:09.0: port 0 is not capable of FBS
[   17.417096] ------------[ cut here ]------------
[   17.421707] WARNING: CPU: 49 PID: 1 at drivers/ata/libata-core.c:6426 ata_host_activate+0x138/0x150
[   17.430739] 
[   17.432221] CPU: 49 PID: 1 Comm: swapper/0 Tainted: G        W       4.8.1-00004-gf0dadca853a2 #171
[   17.441253] Hardware name: www.cavium.com ThunderX CRB-2S/ThunderX CRB-2S, BIOS 0.3 Sep 13 2016
[   17.449939] task: ffff800fc8340000 task.stack: ffff810000484000
[   17.455847] PC is at ata_host_activate+0x138/0x150
[   17.460627] LR is at ata_host_activate+0x5c/0x150
[   17.465320] pc : [<ffff0000087b7868>] lr : [<ffff0000087b778c>] pstate: 60000045
[   17.472703] sp : ffff810000487a90
[   17.476007] x29: ffff810000487a90 x28: 0000000000000001 
[   17.481314] x27: ffff000009245408 x26: ffff000009245bf0 
[   17.486621] x25: ffff8100084830a0 x24: ffff81000a70fa18 
[   17.491929] x23: 0000000000000080 x22: ffff000009245bf0 
[   17.497236] x21: 0000000000000000 x20: ffff0000087cddc8 
[   17.502544] x19: ffff81000a70f918 x18: ffff0000892f7d77 
[   17.507851] x17: ffff7fe040029ea0 [   17.509883] ata4: SATA link up 6.0 Gbps (SStatus 133 SControl 300)

[   17.517234] x16: ffffffffffffff98 
[   17.520804] x15: 0000000000000006 x14: ffff0000092f7d85 
[   17.526112] x13: ffff00000a67ffff x12: 0000000000000008 
[   17.531420] x11: 0088000000000000 x10: 0140000000000040 
[   17.536727] x9 : 0000000000000000 x8 : ffff00000a676500 
[   17.542035] x7 : 0000000000000006 x6 : ffff810000484000 
[   17.547342] x5 : ffff81000a71d680 x4 : 0000000000000000 
[   17.552650] x3 : ffff00001e800104 x2 : ffff81000a70fa18 
[   17.557957] x1 : 0000000000000040 x0 : 0000000000000000 
[   17.563264] 
[   17.564745] ---[ end trace 2c145cc81872d4a3 ]---
[   17.569351] Call trace:
[   17.571788] Exception stack(0xffff8100004878c0 to 0xffff8100004879f0)
[   17.578218] 78c0: ffff81000a70f918 0001000000000000 ffff810000487a90 ffff0000087b7868
[   17.586036] 78e0: ffff00000a660000 0000000000020000 0000000000000008 00e800000000070f
[   17.593855] 7900: 0000000000000000 ffff7fe000300380 ffff810000487990 ffff000008776250
[   17.601673] 7920: ffff8100084830a0 ffff810008483150 0000000000000004 0000000000000040
[   17.609492] 7940: 0000000000016500 ffff81000a70fa18 ffff810000487990 ffff0000087d10e8
[   17.617310] 7960: 0000000000000000 0000000000000040 ffff81000a70fa18 ffff00001e800104
[   17.625129] 7980: 0000000000000000 ffff81000a71d680 ffff810000484000 0000000000000006
[   17.632947] 79a0: ffff00000a676500 0000000000000000 0140000000000040 0088000000000000
[   17.640765] 79c0: 0000000000000008 ffff00000a67ffff ffff0000092f7d85 0000000000000006
[   17.648583] 79e0: ffffffffffffff98 ffff7fe040029ea0
[   17.653451] [<ffff0000087b7868>] ata_host_activate+0x138/0x150
[   17.659273] [<ffff0000087d2950>] ahci_host_activate+0x138/0x170
[   17.665182] [<ffff0000087ced84>] ahci_init_one+0x8d4/0xd50
[   17.670657] [<ffff00000850f394>] local_pci_probe+0x3c/0xb8
[   17.676131] [<ffff000008510330>] pci_device_probe+0x110/0x148
[   17.681867] [<ffff00000876ac54>] driver_probe_device+0x204/0x2b0
[   17.687863] [<ffff00000876adac>] __driver_attach+0xac/0xb0
[   17.693337] [<ffff000008768d24>] bus_for_each_dev+0x5c/0xa0
[   17.698899] [<ffff00000876aee8>] driver_attach+0x20/0x28
[   17.704200] [<ffff0000087697d0>] bus_add_driver+0x1c8/0x230
[   17.708031] ata5: SATA link down (SStatus 0 SControl 300)
[   17.715147] [<ffff00000876b620>] driver_register+0x60/0xf8
[   17.720621] [<ffff0000085103a0>] __pci_register_driver+0x38/0x40
[   17.726617] [<ffff0000090b2fec>] ahci_pci_driver_init+0x20/0x28
[   17.732527] [<ffff000009080c88>] do_one_initcall+0x84/0x114
[   17.738089] [<ffff000009080ed0>] kernel_init_freeable+0x1b8/0x25c
[   17.744172] [<ffff000008c20f30>] kernel_init+0x10/0x108
[   17.749386] [<ffff000008082e90>] ret_from_fork+0x10/0x40
[   17.755136] scsi host5: ahci
[   17.758152] ata6: SATA max UDMA/133 abar m2097152@0x915000000000 port 0x915000000100
[   17.766004] ahci 0005:00:0a.0: AHCI 0001.0300 32 slots 1 ports 6 Gbps 0x1 impl SATA mode
[   17.774095] ahci 0005:00:0a.0: flags: 64bit ncq sntf ilck pm led clo only pmp fbs pio slum part ccc apst 
[   17.783660] ahci 0005:00:0a.0: port 0 is not capable of FBS
[   17.789335] ------------[ cut here ]------------
[   17.793946] WARNING: CPU: 49 PID: 1 at drivers/ata/libata-core.c:6426 ata_host_activate+0x138/0x150
[   17.802977] 
[   17.804460] CPU: 49 PID: 1 Comm: swapper/0 Tainted: G        W       4.8.1-00004-gf0dadca853a2 #171
[   17.813491] Hardware name: www.cavium.com ThunderX CRB-2S/ThunderX CRB-2S, BIOS 0.3 Sep 13 2016
[   17.822177] task: ffff800fc8340000 task.stack: ffff810000484000
[   17.828085] PC is at ata_host_activate+0x138/0x150
[   17.832866] LR is at ata_host_activate+0x5c/0x150
[   17.837559] pc : [<ffff0000087b7868>] lr : [<ffff0000087b778c>] pstate: 60000045
[   17.844942] sp : ffff810000487a90
[   17.848246] x29: ffff810000487a90 x28: 0000000000000001 
[   17.853553] x27: ffff000009245408 x26: ffff000009245bf0 
[   17.858861] x25: ffff8100084850a0 x24: ffff81000a705e18 
[   17.864169] x23: 0000000000000080 x22: ffff000009245bf0 
[   17.869477] x21: 0000000000000000 x20: ffff0000087cddc8 
[   17.874784] x19: ffff81000a705f18 x18: ffff0000892f7d77 
[   17.880092] x17: ffff7fe040029ea0 x16: ffffffffffffff98 
[   17.885399] x15: 0000000000000006 x14: ffff0000092f7d85 
[   17.890707] x13: ffff00000a6dffff x12: 0000000000000008 
[   17.896014] x11: 0088000000000000 x10: 0140000000000040 
[   17.901321] x9 : 0000000000000000 x8 : ffff00000a6d6500 
[   17.906628] x7 : 0000000000000006 x6 : ffff810000484000 
[   17.911936] x5 : ffff81000a71b880 x4 : 0000000000000000 
[   17.917244] x3 : ffff00001ec00104 x2 : ffff81000a705e18 
[   17.922551] x1 : 0000000000000040 x0 : 0000000000000000 
[   17.927858] 
[   17.929339] ---[ end trace 2c145cc81872d4a4 ]---
[   17.933945] Call trace:
[   17.936381] Exception stack(0xffff8100004878c0 to 0xffff8100004879f0)
[   17.942811] 78c0: ffff81000a705f18 0001000000000000 ffff810000487a90 ffff0000087b7868
[   17.950630] 78e0: ffff00000a6c0000 0000000000020000 0000000000000008 00e800000000070f
[   17.958449] 7900: 0000000000000000 ffff7fe000300400 ffff810000487990 ffff000008776250
[   17.966267] 7920: ffff8100084850a0 ffff810008485150 0000000000000004 0000000000000040
[   17.974085] 7940: 0000000000016500 ffff81000a705e18 ffff810000487990 ffff0000087d10e8
[   17.981904] 7960: 0000000000000000 0000000000000040 ffff81000a705e18 ffff00001ec00104
[   17.989722] 7980: 0000000000000000 ffff81000a71b880 ffff810000484000 0000000000000006
[   17.997541] 79a0: ffff00000a6d6500 0000000000000000 0140000000000040 0088000000000000
[   18.005359] 79c0: 0000000000000008 ffff00000a6dffff ffff0000092f7d85 0000000000000006
[   18.013177] 79e0: ffffffffffffff98 ffff7fe040029ea0
[   18.018044] [<ffff0000087b7868>] ata_host_activate+0x138/0x150
[   18.023867] [<ffff0000087d2950>] ahci_host_activate+0x138/0x170
[   18.029775] [<ffff0000087ced84>] ahci_init_one+0x8d4/0xd50
[   18.035250] [<ffff00000850f394>] local_pci_probe+0x3c/0xb8
[   18.040725] [<ffff000008510330>] pci_device_probe+0x110/0x148
[   18.046460] [<ffff00000876ac54>] driver_probe_device+0x204/0x2b0
[   18.052456] [<ffff00000876adac>] __driver_attach+0xac/0xb0
[   18.057931] [<ffff000008768d24>] bus_for_each_dev+0x5c/0xa0
[   18.063492] [<ffff00000876aee8>] driver_attach+0x20/0x28
[   18.068793] [<ffff0000087697d0>] bus_add_driver+0x1c8/0x230
[   18.074355] [<ffff00000876b620>] driver_register+0x60/0xf8
[   18.079829] [<ffff0000085103a0>] __pci_register_driver+0x38/0x40
[   18.080051] ata6: SATA link down (SStatus 0 SControl 300)
[   18.091210] [<ffff0000090b2fec>] ahci_pci_driver_init+0x20/0x28
[   18.097120] [<ffff000009080c88>] do_one_initcall+0x84/0x114
[   18.102682] [<ffff000009080ed0>] kernel_init_freeable+0x1b8/0x25c
[   18.108765] [<ffff000008c20f30>] kernel_init+0x10/0x108
[   18.113979] [<ffff000008082e90>] ret_from_fork+0x10/0x40
[   18.119725] scsi host6: ahci
[   18.122747] ata7: SATA max UDMA/133 abar m2097152@0x916000000000 port 0x916000000100
[   18.130601] ahci 0005:00:0b.0: AHCI 0001.0300 32 slots 1 ports 6 Gbps 0x1 impl SATA mode
[   18.138693] ahci 0005:00:0b.0: flags: 64bit ncq sntf ilck pm led clo only pmp fbs pio slum part ccc apst 
[   18.148258] ahci 0005:00:0b.0: port 0 is not capable of FBS
[   18.153931] ------------[ cut here ]------------
[   18.158542] WARNING: CPU: 49 PID: 1 at drivers/ata/libata-core.c:6426 ata_host_activate+0x138/0x150
[   18.167574] 
[   18.169057] CPU: 49 PID: 1 Comm: swapper/0 Tainted: G        W       4.8.1-00004-gf0dadca853a2 #171
[   18.178089] Hardware name: www.cavium.com ThunderX CRB-2S/ThunderX CRB-2S, BIOS 0.3 Sep 13 2016
[   18.186774] task: ffff800fc8340000 task.stack: ffff810000484000
[   18.192683] PC is at ata_host_activate+0x138/0x150
[   18.197463] LR is at ata_host_activate+0x5c/0x150
[   18.202156] pc : [<ffff0000087b7868>] lr : [<ffff0000087b778c>] pstate: 60000045
[   18.209539] sp : ffff810000487a90
[   18.212843] x29: ffff810000487a90 x28: 0000000000000001 
[   18.218150] x27: ffff000009245408 x26: ffff000009245bf0 
[   18.223458] x25: ffff8100084870a0 x24: ffff81000a70ec18 
[   18.228765] x23: 0000000000000080 x22: ffff000009245bf0 
[   18.234073] x21: 0000000000000000 x20: ffff0000087cddc8 
[   18.239380] x19: ffff81000a70eb18 x18: ffff0000892f7d77 
[   18.244688] x17: ffff7fe040029ee0 x16: ffffffffffffff98 
[   18.249995] x15: 0000000000000006 x14: ffff0000092f7d85 
[   18.255303] x13: ffff00000a73ffff x12: 0000000000000008 
[   18.260611] x11: 0088000000000000 x10: 0140000000000040 
[   18.265918] x9 : 0000000000000000 x8 : ffff00000a736500 
[   18.271225] x7 : 0000000000000006 x6 : ffff810000484000 
[   18.276533] x5 : ffff81000a719a80 x4 : 0000000000000000 
[   18.281840] x3 : ffff00001f000104 x2 : ffff81000a70ec18 
[   18.287148] x1 : 0000000000000040 x0 : 0000000000000000 
[   18.292455] 
[   18.293936] ---[ end trace 2c145cc81872d4a5 ]---
[   18.298542] Call trace:
[   18.300979] Exception stack(0xffff8100004878c0 to 0xffff8100004879f0)
[   18.307409] 78c0: ffff81000a70eb18 0001000000000000 ffff810000487a90 ffff0000087b7868
[   18.315228] 78e0: ffff00000a720000 0000000000020000 0000000000000008 00e800000000070f
[   18.323046] 7900: 0000000000000000 ffff7fe000300480 ffff810000487990 ffff000008776250
[   18.330865] 7920: ffff8100084870a0 ffff810008487150 0000000000000004 0000000000000040
[   18.338683] 7940: 0000000000016500 ffff81000a70ec18 ffff810000487990 ffff0000087d10e8
[   18.346502] 7960: 0000000000000000 0000000000000040 ffff81000a70ec18 ffff00001f000104
[   18.354320] 7980: 0000000000000000 ffff81000a719a80 ffff810000484000 0000000000000006
[   18.362139] 79a0: ffff00000a736500 0000000000000000 0140000000000040 0088000000000000
[   18.369957] 79c0: 0000000000000008 ffff00000a73ffff ffff0000092f7d85 0000000000000006
[   18.377775] 79e0: ffffffffffffff98 ffff7fe040029ee0
[   18.382643] [<ffff0000087b7868>] ata_host_activate+0x138/0x150
[   18.388465] [<ffff0000087d2950>] ahci_host_activate+0x138/0x170
[   18.394373] [<ffff0000087ced84>] ahci_init_one+0x8d4/0xd50
[   18.399848] [<ffff00000850f394>] local_pci_probe+0x3c/0xb8
[   18.405323] [<ffff000008510330>] pci_device_probe+0x110/0x148
[   18.411059] [<ffff00000876ac54>] driver_probe_device+0x204/0x2b0
[   18.417055] [<ffff00000876adac>] __driver_attach+0xac/0xb0
[   18.422529] [<ffff000008768d24>] bus_for_each_dev+0x5c/0xa0
[   18.428091] [<ffff00000876aee8>] driver_attach+0x20/0x28
[   18.433392] [<ffff0000087697d0>] bus_add_driver+0x1c8/0x230
[   18.438954] [<ffff00000876b620>] driver_register+0x60/0xf8
[   18.444010] ata7: SATA link down (SStatus 0 SControl 300)
[   18.449813] [<ffff0000085103a0>] __pci_register_driver+0x38/0x40
[   18.455809] [<ffff0000090b2fec>] ahci_pci_driver_init+0x20/0x28
[   18.461719] [<ffff000009080c88>] do_one_initcall+0x84/0x114
[   18.467281] [<ffff000009080ed0>] kernel_init_freeable+0x1b8/0x25c
[   18.473364] [<ffff000008c20f30>] kernel_init+0x10/0x108
[   18.478578] [<ffff000008082e90>] ret_from_fork+0x10/0x40
[   18.484409] scsi host7: ahci
[   18.487425] ata8: SATA max UDMA/133 abar m2097152@0x917000000000 port 0x917000000100
...
[   18.808074] ata8: SATA link down (SStatus 0 SControl 300)
...
[   21.765921] ata1.00: qc timeout (cmd 0xec)
[   21.770031] ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   22.249869] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
[   22.533896] ata4.00: qc timeout (cmd 0xec)
[   22.537996] ata4.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   23.017874] ata4: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
[   32.261874] ata1.00: qc timeout (cmd 0xec)
[   32.265972] ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   32.272059] ata1: limiting SATA link speed to 3.0 Gbps
[   32.753873] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   33.029878] ata4.00: qc timeout (cmd 0xec)
[   33.033978] ata4.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   33.040066] ata4: limiting SATA link speed to 3.0 Gbps
[   33.521884] ata4: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   63.493874] ata1.00: qc timeout (cmd 0xec)
[   63.497973] ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   63.977867] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   65.541890] ata4.00: qc timeout (cmd 0xec)
[   65.545987] ata4.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   66.025873] ata4: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   66.032337] VFS: Cannot open root device "sda2" or unknown-block(0,0): error -6
[   66.039682] Please append a correct "root=" boot option; here are the available partitions:
[   66.048047] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0)
[   66.056304] CPU: 55 PID: 1 Comm: swapper/0 Tainted: G        W       4.8.1-00004-gf0dadca853a2 #171
[   66.065337] Hardware name: www.cavium.com ThunderX CRB-2S/ThunderX CRB-2S, BIOS 0.3 Sep 13 2016
[   66.074023] Call trace:
[   66.076474] [<ffff0000080883c8>] dump_backtrace+0x0/0x1a0
[   66.081863] [<ffff00000808857c>] show_stack+0x14/0x20
[   66.086908] [<ffff00000849adf4>] dump_stack+0x94/0xb8
[   66.091956] [<ffff00000815df94>] panic+0x10c/0x26c
[   66.096744] [<ffff000009081318>] mount_block_root+0x18c/0x264
[   66.102480] [<ffff00000908150c>] mount_root+0x11c/0x134
[   66.107695] [<ffff000009081660>] prepare_namespace+0x13c/0x184
[   66.113517] [<ffff000009080f50>] kernel_init_freeable+0x238/0x25c
[   66.119607] [<ffff000008c20f30>] kernel_init+0x10/0x108
[   66.124822] [<ffff000008082e90>] ret_from_fork+0x10/0x40
[   66.130125] SMP: stopping secondary CPUs

^ permalink raw reply	[flat|nested] 19+ messages in thread
* [PATCH] ahci: use pci_alloc_irq_vectors
@ 2016-10-21 14:01           ` Robert Richter
  0 siblings, 0 replies; 19+ messages in thread
From: Robert Richter @ 2016-10-21 14:01 UTC (permalink / raw)
  To: linux-arm-kernel

Christoph,

On 21.10.16 14:59:18, Christoph Hellwig wrote:
> can you try the latest fixed in the libata tree:
> 
> https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/log/?h=for-4.9-fixes

I see now this warning:

 WARNING: CPU: 0 PID: 1601 at drivers/ata/libata-core.c:6426 ata_host_activate+0x138/0x150

... and it still fails:

[   21.765921] ata1.00: qc timeout (cmd 0xec)
[   21.770031] ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   22.249869] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
[   22.533896] ata4.00: qc timeout (cmd 0xec)
[   22.537996] ata4.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   23.017874] ata4: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
[   32.261874] ata1.00: qc timeout (cmd 0xec)
[   32.265972] ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   32.272059] ata1: limiting SATA link speed to 3.0 Gbps
[   32.753873] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   33.029878] ata4.00: qc timeout (cmd 0xec)
[   33.033978] ata4.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   33.040066] ata4: limiting SATA link speed to 3.0 Gbps
[   33.521884] ata4: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   63.493874] ata1.00: qc timeout (cmd 0xec)
[   63.497973] ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   63.977867] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   65.541890] ata4.00: qc timeout (cmd 0xec)
[   65.545987] ata4.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   66.025873] ata4: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   66.032337] VFS: Cannot open root device "sda2" or unknown-block(0,0): error -6
[   66.039682] Please append a correct "root=" boot option; here are the available partitions:
[   66.048047] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0)

Full log below.

(Note that I tested a backported version based on 4.8 with all your 3
patches applied.)

-Robert


[   15.740362] ahci 0001:00:08.0: version 3.0
[   15.744577] ahci 0001:00:08.0: AHCI 0001.0300 32 slots 1 ports 6 Gbps 0x1 impl SATA mode
[   15.752670] ahci 0001:00:08.0: flags: 64bit ncq sntf ilck pm led clo only pmp fbs pio slum part ccc apst 
[   15.762239] ahci 0001:00:08.0: port 0 is not capable of FBS
[   15.767996] ------------[ cut here ]------------
[   15.772610] WARNING: CPU: 0 PID: 1601 at drivers/ata/libata-core.c:6426 ata_host_activate+0x138/0x150
[   15.781815] 
[   15.783298] CPU: 0 PID: 1601 Comm: kworker/0:1 Tainted: G        W       4.8.1-00004-gf0dadca853a2 #171
[   15.792677] Hardware name: www.cavium.com ThunderX CRB-2S/ThunderX CRB-2S, BIOS 0.3 Sep 13 2016
[   15.801365] Workqueue: events work_for_cpu_fn
[   15.805714] task: ffff800fcb5e4e00 task.stack: ffff800fcb618000
[   15.811622] PC is at ata_host_activate+0x138/0x150
[   15.816401] LR is at ata_host_activate+0x5c/0x150
[   15.821094] pc : [<ffff0000087b7868>] lr : [<ffff0000087b778c>] pstate: 60000045
[   15.828476] sp : ffff800fcb61bbb0
[   15.831780] x29: ffff800fcb61bbb0 x28: 0000000000000001 
[   15.837085] x27: ffff000009245408 x26: ffff000009245bf0 
[   15.842391] x25: ffff800fca8e40a0 x24: ffff800fcb451118 
[   15.847695] x23: 0000000000000080 x22: ffff000009245bf0 
[   15.853000] x21: 0000000000000000 x20: ffff0000087cddc8 
[   15.858305] x19: ffff800fcb451218 x18: ffff0000892f7d77 
[   15.863610] x17: ffff7fe003f2e820 x16: ffffffffffffff98 
[   15.868915] x15: 0000000000000006 x14: ffff0000092f7d85 
[   15.874220] x13: ffff00000979ffff x12: 0000000000000008 
[   15.879525] x11: 0088000000000000 x10: 0140000000000040 
[   15.884829] x9 : 0000000000000000 x8 : ffff000009796500 
[   15.890135] x7 : 0000000000000006 x6 : ffff800fcb618000 
[   15.895439] x5 : ffff800fcb901b00 x4 : 0000000000000000 
[   15.900744] x3 : ffff00001b000104 x2 : ffff800fcb451118 
[   15.906049] x1 : 0000000000000040 x0 : 0000000000000000 
[   15.911354] 
[   15.912835] ---[ end trace 2c145cc81872d49e ]---
[   15.917440] Call trace:
[   15.919876] Exception stack(0xffff800fcb61b9e0 to 0xffff800fcb61bb10)
[   15.926306] b9e0: ffff800fcb451218 0001000000000000 ffff800fcb61bbb0 ffff0000087b7868
[   15.934124] ba00: ffff000009780000 0000000000020000 0000000000000008 00e800000000070f
[   15.941942] ba20: 0000000000000000 ffff7fe000300100 ffff800fcb61bab0 ffff000008776250
[   15.949760] ba40: ffff800fca8e40a0 ffff800fca8e4150 0000000000000004 0000000000000040
[   15.957578] ba60: 0000000000016500 ffff800fcb451118 ffff800fcb61bab0 ffff0000087d10e8
[   15.965396] ba80: 0000000000000000 0000000000000040 ffff800fcb451118 ffff00001b000104
[   15.973214] baa0: 0000000000000000 ffff800fcb901b00 ffff800fcb618000 0000000000000006
[   15.981032] bac0: ffff000009796500 0000000000000000 0140000000000040 0088000000000000
[   15.988849] bae0: 0000000000000008 ffff00000979ffff ffff0000092f7d85 0000000000000006
[   15.996667] bb00: ffffffffffffff98 ffff7fe003f2e820
[   16.001533] [<ffff0000087b7868>] ata_host_activate+0x138/0x150
[   16.007356] [<ffff0000087d2950>] ahci_host_activate+0x138/0x170
[   16.013264] [<ffff0000087ced84>] ahci_init_one+0x8d4/0xd50
[   16.018740] [<ffff00000850f394>] local_pci_probe+0x3c/0xb8
[   16.024214] [<ffff0000080cc458>] work_for_cpu_fn+0x18/0x28
[   16.029689] [<ffff0000080ce710>] process_one_work+0x118/0x378
[   16.035424] [<ffff0000080cebd8>] worker_thread+0x268/0x4b0
[   16.040900] [<ffff0000080d4c10>] kthread+0xd0/0xe8
[   16.045680] [<ffff000008082e90>] ret_from_fork+0x10/0x40
[   16.051483] scsi host0: ahci
[   16.054531] ata1: SATA max UDMA/133 abar m2097152 at 0x814000000000 port 0x814000000100
[   16.062464] ahci 0001:00:09.0: AHCI 0001.0300 32 slots 1 ports 6 Gbps 0x1 impl SATA mode
[   16.070558] ahci 0001:00:09.0: flags: 64bit ncq sntf ilck pm led clo only pmp fbs pio slum part ccc apst 
[   16.080121] ahci 0001:00:09.0: port 0 is not capable of FBS
[   16.085790] ------------[ cut here ]------------
[   16.090400] WARNING: CPU: 0 PID: 1601 at drivers/ata/libata-core.c:6426 ata_host_activate+0x138/0x150
[   16.099604] 
[   16.101086] CPU: 0 PID: 1601 Comm: kworker/0:1 Tainted: G        W       4.8.1-00004-gf0dadca853a2 #171
[   16.110464] Hardware name: www.cavium.com ThunderX CRB-2S/ThunderX CRB-2S, BIOS 0.3 Sep 13 2016
[   16.119150] Workqueue: events work_for_cpu_fn
[   16.123498] task: ffff800fcb5e4e00 task.stack: ffff800fcb618000
[   16.129406] PC is at ata_host_activate+0x138/0x150
[   16.134186] LR is at ata_host_activate+0x5c/0x150
[   16.138878] pc : [<ffff0000087b7868>] lr : [<ffff0000087b778c>] pstate: 60000045
[   16.146260] sp : ffff800fcb61bbb0
[   16.149563] x29: ffff800fcb61bbb0 x28: 0000000000000001 
[   16.154868] x27: ffff000009245408 x26: ffff000009245bf0 
[   16.160172] x25: ffff800fca8e60a0 x24: ffff800fcb45ff18 
[   16.165477] x23: 0000000000000080 x22: ffff000009245bf0 
[   16.170781] x21: 0000000000000000 x20: ffff0000087cddc8 
[   16.176086] x19: ffff800fcb45fe18 x18: ffff0000892f7d77 
[   16.181390] x17: ffff7fe040029e60 x16: ffffffffffffff98 
[   16.186695] x15: 0000000000000006 x14: ffff0000092f7d85 
[   16.192000] x13: ffff000009f3ffff x12: 0000000000000008 
[   16.197304] x11: 0088000000000000 x10: 0140000000000040 
[   16.202608] x9 : 0000000000000000 x8 : ffff000009f36500 
[   16.207913] x7 : 0000000000000006 x6 : ffff800fcb618000 
[   16.213218] x5 : ffff800fcb903900 x4 : 0000000000000000 
[   16.218522] x3 : ffff00001b400104 x2 : ffff800fcb45ff18 
[   16.223827] x1 : 0000000000000040 x0 : 0000000000000000 
[   16.229131] 
[   16.230612] ---[ end trace 2c145cc81872d49f ]---
[   16.235216] Call trace:
[   16.237652] Exception stack(0xffff800fcb61b9e0 to 0xffff800fcb61bb10)
[   16.244081] b9e0: ffff800fcb45fe18 0001000000000000 ffff800fcb61bbb0 ffff0000087b7868
[   16.251899] ba00: ffff000009f20000 0000000000020000 0000000000000008 00e800000000070f
[   16.259717] ba20: 0000000000000000 ffff7fe000300180 ffff800fcb61bab0 ffff000008776250
[   16.267535] ba40: ffff800fca8e60a0 ffff800fca8e6150 0000000000000004 0000000000000040
[   16.275353] ba60: 0000000000016500 ffff800fcb45ff18 ffff800fcb61bab0 ffff0000087d10e8
[   16.283170] ba80: 0000000000000000 0000000000000040 ffff800fcb45ff18 ffff00001b400104
[   16.290988] baa0: 0000000000000000 ffff800fcb903900 ffff800fcb618000 0000000000000006
[   16.298806] bac0: ffff000009f36500 0000000000000000 0140000000000040 0088000000000000
[   16.306623] bae0: 0000000000000008 ffff000009f3ffff ffff0000092f7d85 0000000000000006
[   16.314440] bb00: ffffffffffffff98 ffff7fe040029e60
[   16.319307] [<ffff0000087b7868>] ata_host_activate+0x138/0x150
[   16.325128] [<ffff0000087d2950>] ahci_host_activate+0x138/0x170
[   16.331036] [<ffff0000087ced84>] ahci_init_one+0x8d4/0xd50
[   16.336510] [<ffff00000850f394>] local_pci_probe+0x3c/0xb8
[   16.341985] [<ffff0000080cc458>] work_for_cpu_fn+0x18/0x28
[   16.347458] [<ffff0000080ce710>] process_one_work+0x118/0x378
[   16.353192] [<ffff0000080cebd8>] worker_thread+0x268/0x4b0
[   16.358667] [<ffff0000080d4c10>] kthread+0xd0/0xe8
[   16.363447] [<ffff000008082e90>] ret_from_fork+0x10/0x40
[   16.369153] scsi host1: ahci
[   16.372172] ata2: SATA max UDMA/133 abar m2097152 at 0x815000000000 port 0x815000000100
[   16.380095] ahci 0001:00:0a.0: AHCI 0001.0300 32 slots 1 ports 6 Gbps 0x1 impl SATA mode
[   16.388189] ahci 0001:00:0a.0: flags: 64bit ncq sntf ilck pm led clo only pmp fbs pio slum part ccc apst 
[   16.397752] ahci 0001:00:0a.0: port 0 is not capable of FBS
[   16.403423] ------------[ cut here ]------------
[   16.408033] WARNING: CPU: 0 PID: 1601 at drivers/ata/libata-core.c:6426 ata_host_activate+0x138/0x150
[   16.417238] 
[   16.418719] CPU: 0 PID: 1601 Comm: kworker/0:1 Tainted: G        W       4.8.1-00004-gf0dadca853a2 #171
[   16.428098] Hardware name: www.cavium.com ThunderX CRB-2S/ThunderX CRB-2S, BIOS 0.3 Sep 13 2016
[   16.436784] Workqueue: events work_for_cpu_fn
[   16.441131] task: ffff800fcb5e4e00 task.stack: ffff800fcb618000
[   16.447039] PC is at ata_host_activate+0x138/0x150
[   16.451818] LR is at ata_host_activate+0x5c/0x150
[   16.456511] pc : [<ffff0000087b7868>] lr : [<ffff0000087b778c>] pstate: 60000045
[   16.463893] sp : ffff800fcb61bbb0
[   16.467196] x29: ffff800fcb61bbb0 x28: 0000000000000001 
[   16.472501] x27: ffff000009245408 x26: ffff000009245bf0 
[   16.477806] x25: ffff800fca8e80a0 x24: ffff800fcb451b18 
[   16.483111] x23: 0000000000000080 x22: ffff000009245bf0 
[   16.488415] x21: 0000000000000000 x20: ffff0000087cddc8 
[   16.493720] x19: ffff800fcb451c18 x18: ffff0000892f7d77 
[   16.499025] x17: ffff7fe003f2e6a0 x16: ffffffffffffff98 
[   16.504330] x15: 0000000000000006 x14: ffff0000092f7d85 
[   16.509634] x13: ffff000009f6ffff x12: 0000000000000008 
[   16.514939] x11: 0088000000000000 x10: 0140000000000040 
[   16.520244] x9 : 0000000000000000 x8 : ffff000009f66500 
[   16.525548] x7 : 0000000000000006 x6 : ffff800fcb618000 
[   16.530853] x5 : ffff800fcb905780 x4 : 0000000000000000 
[   16.536158] x3 : ffff00001b800104 [   16.537881] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)

[   16.545541] x2 : ffff800fcb451b18 
[   16.549110] x1 : 0000000000000040 x0 : 0000000000000000 
[   16.554414] 
[   16.555893] ---[ end trace 2c145cc81872d4a0 ]---
[   16.560499] Call trace:
[   16.562934] Exception stack(0xffff800fcb61b9e0 to 0xffff800fcb61bb10)
[   16.569363] b9e0: ffff800fcb451c18 0001000000000000 ffff800fcb61bbb0 ffff0000087b7868
[   16.577181] ba00: ffff000009f50000 0000000000020000 0000000000000008 00e800000000070f
[   16.584999] ba20: 0000000000000000 ffff7fe000300200 ffff800fcb61bab0 ffff000008776250
[   16.592817] ba40: ffff800fca8e80a0 ffff800fca8e8150 0000000000000004 0000000000000040
[   16.600634] ba60: 0000000000016500 ffff800fcb451b18 ffff800fcb61bab0 ffff0000087d10e8
[   16.608452] ba80: 0000000000000000 0000000000000040 ffff800fcb451b18 ffff00001b800104
[   16.616270] baa0: 0000000000000000 ffff800fcb905780 ffff800fcb618000 0000000000000006
[   16.624088] bac0: ffff000009f66500 0000000000000000 0140000000000040 0088000000000000
[   16.631905] bae0: 0000000000000008 ffff000009f6ffff ffff0000092f7d85 0000000000000006
[   16.639723] bb00: ffffffffffffff98 ffff7fe003f2e6a0
[   16.644589] [<ffff0000087b7868>] ata_host_activate+0x138/0x150
[   16.650411] [<ffff0000087d2950>] ahci_host_activate+0x138/0x170
[   16.656318] [<ffff0000087ced84>] ahci_init_one+0x8d4/0xd50
[   16.661793] [<ffff00000850f394>] local_pci_probe+0x3c/0xb8
[   16.667266] [<ffff0000080cc458>] work_for_cpu_fn+0x18/0x28
[   16.672741] [<ffff0000080ce710>] process_one_work+0x118/0x378
[   16.678475] [<ffff0000080cebd8>] worker_thread+0x268/0x4b0
[   16.683949] [<ffff0000080d4c10>] kthread+0xd0/0xe8
[   16.688728] [<ffff000008082e90>] ret_from_fork+0x10/0x40
[   16.692073] ata2: SATA link down (SStatus 0 SControl 300)
[   16.699826] scsi host2: ahci
[   16.702835] ata3: SATA max UDMA/133 abar m2097152 at 0x816000000000 port 0x816000000100
[   16.710759] ahci 0001:00:0b.0: AHCI 0001.0300 32 slots 1 ports 6 Gbps 0x1 impl SATA mode
[   16.718852] ahci 0001:00:0b.0: flags: 64bit ncq sntf ilck pm led clo only pmp fbs pio slum part ccc apst 
[   16.728416] ahci 0001:00:0b.0: port 0 is not capable of FBS
[   16.734084] ------------[ cut here ]------------
[   16.738693] WARNING: CPU: 0 PID: 1601 at drivers/ata/libata-core.c:6426 ata_host_activate+0x138/0x150
[   16.747898] 
[   16.749379] CPU: 0 PID: 1601 Comm: kworker/0:1 Tainted: G        W       4.8.1-00004-gf0dadca853a2 #171
[   16.758758] Hardware name: www.cavium.com ThunderX CRB-2S/ThunderX CRB-2S, BIOS 0.3 Sep 13 2016
[   16.767444] Workqueue: events work_for_cpu_fn
[   16.771792] task: ffff800fcb5e4e00 task.stack: ffff800fcb618000
[   16.777699] PC is at ata_host_activate+0x138/0x150
[   16.782479] LR is at ata_host_activate+0x5c/0x150
[   16.787171] pc : [<ffff0000087b7868>] lr : [<ffff0000087b778c>] pstate: 60000045
[   16.794553] sp : ffff800fcb61bbb0
[   16.797856] x29: ffff800fcb61bbb0 x28: 0000000000000001 
[   16.803161] x27: ffff000009245408 x26: ffff000009245bf0 
[   16.808466] x25: ffff800fca8ea0a0 x24: ffff800fcb45f518 
[   16.813770] x23: 0000000000000080 x22: ffff000009245bf0 
[   16.819075] x21: 0000000000000000 x20: ffff0000087cddc8 
[   16.824380] x19: ffff800fcb45f418 x18: ffff0000892f7d77 
[   16.829685] x17: ffff7fe003f2e6a0 x16: ffffffffffffff98 
[   16.834989] x15: 0000000000000006 x14: ffff0000092f7d85 
[   16.840294] x13: ffff000009fbffff x12: 0000000000000008 
[   16.845599] x11: 0088000000000000 x10: 0140000000000040 
[   16.850903] x9 : 0000000000000000 x8 : ffff000009fb6500 
[   16.856208] x7 : 0000000000000006 x6 : ffff800fcb618000 
[   16.861512] x5 : ffff800fcb907500 x4 : 0000000000000000 
[   16.866817] x3 : ffff00001bc00104 x2 : ffff800fcb45f518 
[   16.872122] x1 : 0000000000000040 x0 : 0000000000000000 
[   16.877426] 
[   16.878906] ---[ end trace 2c145cc81872d4a1 ]---
[   16.883511] Call trace:
[   16.885946] Exception stack(0xffff800fcb61b9e0 to 0xffff800fcb61bb10)
[   16.892376] b9e0: ffff800fcb45f418 0001000000000000 ffff800fcb61bbb0 ffff0000087b7868
[   16.900194] ba00: ffff000009fa0000 0000000000020000 0000000000000008 00e800000000070f
[   16.908011] ba20: 0000000000000000 ffff7fe000300280 ffff800fcb61bab0 ffff000008776250
[   16.915829] ba40: ffff800fca8ea0a0 ffff800fca8ea150 0000000000000004 0000000000000040
[   16.923647] ba60: 0000000000016500 ffff800fcb45f518 ffff800fcb61bab0 ffff0000087d10e8
[   16.931465] ba80: 0000000000000000 0000000000000040 ffff800fcb45f518 ffff00001bc00104
[   16.939283] baa0: 0000000000000000 ffff800fcb907500 ffff800fcb618000 0000000000000006
[   16.947101] bac0: ffff000009fb6500 0000000000000000 0140000000000040 0088000000000000
[   16.954918] bae0: 0000000000000008 ffff000009fbffff ffff0000092f7d85 0000000000000006
[   16.962735] bb00: ffffffffffffff98 ffff7fe003f2e6a0
[   16.967602] [<ffff0000087b7868>] ata_host_activate+0x138/0x150
[   16.973424] [<ffff0000087d2950>] ahci_host_activate+0x138/0x170
[   16.979332] [<ffff0000087ced84>] ahci_init_one+0x8d4/0xd50
[   16.984805] [<ffff00000850f394>] local_pci_probe+0x3c/0xb8
[   16.990280] [<ffff0000080cc458>] work_for_cpu_fn+0x18/0x28
[   16.995753] [<ffff0000080ce710>] process_one_work+0x118/0x378
[   17.001488] [<ffff0000080cebd8>] worker_thread+0x268/0x4b0
[   17.006963] [<ffff0000080d4c10>] kthread+0xd0/0xe8
[   17.011742] [<ffff000008082e90>] ret_from_fork+0x10/0x40
[   17.017465] scsi host3: ahci
[   17.020476] ata4: SATA max UDMA/133 abar m2097152 at 0x817000000000 port 0x817000000100
[   17.024054] ata3: SATA link down (SStatus 0 SControl 300)
[   17.033978] ahci 0005:00:08.0: AHCI 0001.0300 32 slots 1 ports 6 Gbps 0x1 impl SATA mode
[   17.042077] ahci 0005:00:08.0: flags: 64bit ncq sntf ilck pm led clo only pmp fbs pio slum part ccc apst 
[   17.051650] ahci 0005:00:08.0: port 0 is not capable of FBS
[   17.057638] ------------[ cut here ]------------
[   17.062263] WARNING: CPU: 49 PID: 1 at drivers/ata/libata-core.c:6426 ata_host_activate+0x138/0x150
[   17.071295] 
[   17.072781] CPU: 49 PID: 1 Comm: swapper/0 Tainted: G        W       4.8.1-00004-gf0dadca853a2 #171
[   17.081814] Hardware name: www.cavium.com ThunderX CRB-2S/ThunderX CRB-2S, BIOS 0.3 Sep 13 2016
[   17.090500] task: ffff800fc8340000 task.stack: ffff810000484000
[   17.096409] PC is at ata_host_activate+0x138/0x150
[   17.101190] LR is at ata_host_activate+0x5c/0x150
[   17.105883] pc : [<ffff0000087b7868>] lr : [<ffff0000087b778c>] pstate: 60000045
[   17.113266] sp : ffff810000487a90
[   17.116570] x29: ffff810000487a90 x28: 0000000000000001 
[   17.121879] x27: ffff000009245408 x26: ffff000009245bf0 
[   17.127187] x25: ffff8100084810a0 x24: ffff81000a705018 
[   17.132495] x23: 0000000000000080 x22: ffff000009245bf0 
[   17.137803] x21: 0000000000000000 x20: ffff0000087cddc8 
[   17.143110] x19: ffff81000a705118 x18: ffff0000892f7d77 
[   17.148418] x17: ffff7fe003f2e620 x16: 0000000000000002 
[   17.153726] x15: 0000000000000006 x14: ffff0000092f7d85 
[   17.159033] x13: ffff00000a62ffff x12: 0000000000000008 
[   17.164341] x11: 0088000000000000 x10: 0140000000000040 
[   17.169649] x9 : 0000000000000000 x8 : ffff00000a626500 
[   17.174956] x7 : 0000000000000006 x6 : ffff810000484000 
[   17.180264] x5 : ffff81000a71f480 x4 : 0000000000000000 
[   17.185571] x3 : ffff00001e400104 x2 : ffff81000a705018 
[   17.190879] x1 : 0000000000000040 x0 : 0000000000000000 
[   17.196186] 
[   17.197667] ---[ end trace 2c145cc81872d4a2 ]---
[   17.202274] Call trace:
[   17.204712] Exception stack(0xffff8100004878c0 to 0xffff8100004879f0)
[   17.211143] 78c0: ffff81000a705118 0001000000000000 ffff810000487a90 ffff0000087b7868
[   17.218961] 78e0: ffff00000a610000 0000000000020000 0000000000000008 00e800000000070f
[   17.226780] 7900: 0000000000000000 ffff7fe000300300 ffff810000487990 ffff000008776250
[   17.234598] 7920: ffff8100084810a0 ffff810008481150 0000000000000004 0000000000000040
[   17.242417] 7940: 0000000000016500 ffff81000a705018 ffff810000487990 ffff0000087d10e8
[   17.250235] 7960: 0000000000000000 0000000000000040 ffff81000a705018 ffff00001e400104
[   17.258054] 7980: 0000000000000000 ffff81000a71f480 ffff810000484000 0000000000000006
[   17.265872] 79a0: ffff00000a626500 0000000000000000 0140000000000040 0088000000000000
[   17.273691] 79c0: 0000000000000008 ffff00000a62ffff ffff0000092f7d85 0000000000000006
[   17.281508] 79e0: 0000000000000002 ffff7fe003f2e620
[   17.286376] [<ffff0000087b7868>] ata_host_activate+0x138/0x150
[   17.292201] [<ffff0000087d2950>] ahci_host_activate+0x138/0x170
[   17.298111] [<ffff0000087ced84>] ahci_init_one+0x8d4/0xd50
[   17.303590] [<ffff00000850f394>] local_pci_probe+0x3c/0xb8
[   17.309065] [<ffff000008510330>] pci_device_probe+0x110/0x148
[   17.314808] [<ffff00000876ac54>] driver_probe_device+0x204/0x2b0
[   17.320803] [<ffff00000876adac>] __driver_attach+0xac/0xb0
[   17.326279] [<ffff000008768d24>] bus_for_each_dev+0x5c/0xa0
[   17.331840] [<ffff00000876aee8>] driver_attach+0x20/0x28
[   17.337141] [<ffff0000087697d0>] bus_add_driver+0x1c8/0x230
[   17.342703] [<ffff00000876b620>] driver_register+0x60/0xf8
[   17.348178] [<ffff0000085103a0>] __pci_register_driver+0x38/0x40
[   17.354183] [<ffff0000090b2fec>] ahci_pci_driver_init+0x20/0x28
[   17.360100] [<ffff000009080c88>] do_one_initcall+0x84/0x114
[   17.365662] [<ffff000009080ed0>] kernel_init_freeable+0x1b8/0x25c
[   17.371754] [<ffff000008c20f30>] kernel_init+0x10/0x108
[   17.376972] [<ffff000008082e90>] ret_from_fork+0x10/0x40
[   17.382862] scsi host4: ahci
[   17.385910] ata5: SATA max UDMA/133 abar m2097152 at 0x914000000000 port 0x914000000100
[   17.393763] ahci 0005:00:09.0: AHCI 0001.0300 32 slots 1 ports 6 Gbps 0x1 impl SATA mode
[   17.401864] ahci 0005:00:09.0: flags: 64bit ncq sntf ilck pm led clo only pmp fbs pio slum part ccc apst 
[   17.411425] ahci 0005:00:09.0: port 0 is not capable of FBS
[   17.417096] ------------[ cut here ]------------
[   17.421707] WARNING: CPU: 49 PID: 1 at drivers/ata/libata-core.c:6426 ata_host_activate+0x138/0x150
[   17.430739] 
[   17.432221] CPU: 49 PID: 1 Comm: swapper/0 Tainted: G        W       4.8.1-00004-gf0dadca853a2 #171
[   17.441253] Hardware name: www.cavium.com ThunderX CRB-2S/ThunderX CRB-2S, BIOS 0.3 Sep 13 2016
[   17.449939] task: ffff800fc8340000 task.stack: ffff810000484000
[   17.455847] PC is at ata_host_activate+0x138/0x150
[   17.460627] LR is at ata_host_activate+0x5c/0x150
[   17.465320] pc : [<ffff0000087b7868>] lr : [<ffff0000087b778c>] pstate: 60000045
[   17.472703] sp : ffff810000487a90
[   17.476007] x29: ffff810000487a90 x28: 0000000000000001 
[   17.481314] x27: ffff000009245408 x26: ffff000009245bf0 
[   17.486621] x25: ffff8100084830a0 x24: ffff81000a70fa18 
[   17.491929] x23: 0000000000000080 x22: ffff000009245bf0 
[   17.497236] x21: 0000000000000000 x20: ffff0000087cddc8 
[   17.502544] x19: ffff81000a70f918 x18: ffff0000892f7d77 
[   17.507851] x17: ffff7fe040029ea0 [   17.509883] ata4: SATA link up 6.0 Gbps (SStatus 133 SControl 300)

[   17.517234] x16: ffffffffffffff98 
[   17.520804] x15: 0000000000000006 x14: ffff0000092f7d85 
[   17.526112] x13: ffff00000a67ffff x12: 0000000000000008 
[   17.531420] x11: 0088000000000000 x10: 0140000000000040 
[   17.536727] x9 : 0000000000000000 x8 : ffff00000a676500 
[   17.542035] x7 : 0000000000000006 x6 : ffff810000484000 
[   17.547342] x5 : ffff81000a71d680 x4 : 0000000000000000 
[   17.552650] x3 : ffff00001e800104 x2 : ffff81000a70fa18 
[   17.557957] x1 : 0000000000000040 x0 : 0000000000000000 
[   17.563264] 
[   17.564745] ---[ end trace 2c145cc81872d4a3 ]---
[   17.569351] Call trace:
[   17.571788] Exception stack(0xffff8100004878c0 to 0xffff8100004879f0)
[   17.578218] 78c0: ffff81000a70f918 0001000000000000 ffff810000487a90 ffff0000087b7868
[   17.586036] 78e0: ffff00000a660000 0000000000020000 0000000000000008 00e800000000070f
[   17.593855] 7900: 0000000000000000 ffff7fe000300380 ffff810000487990 ffff000008776250
[   17.601673] 7920: ffff8100084830a0 ffff810008483150 0000000000000004 0000000000000040
[   17.609492] 7940: 0000000000016500 ffff81000a70fa18 ffff810000487990 ffff0000087d10e8
[   17.617310] 7960: 0000000000000000 0000000000000040 ffff81000a70fa18 ffff00001e800104
[   17.625129] 7980: 0000000000000000 ffff81000a71d680 ffff810000484000 0000000000000006
[   17.632947] 79a0: ffff00000a676500 0000000000000000 0140000000000040 0088000000000000
[   17.640765] 79c0: 0000000000000008 ffff00000a67ffff ffff0000092f7d85 0000000000000006
[   17.648583] 79e0: ffffffffffffff98 ffff7fe040029ea0
[   17.653451] [<ffff0000087b7868>] ata_host_activate+0x138/0x150
[   17.659273] [<ffff0000087d2950>] ahci_host_activate+0x138/0x170
[   17.665182] [<ffff0000087ced84>] ahci_init_one+0x8d4/0xd50
[   17.670657] [<ffff00000850f394>] local_pci_probe+0x3c/0xb8
[   17.676131] [<ffff000008510330>] pci_device_probe+0x110/0x148
[   17.681867] [<ffff00000876ac54>] driver_probe_device+0x204/0x2b0
[   17.687863] [<ffff00000876adac>] __driver_attach+0xac/0xb0
[   17.693337] [<ffff000008768d24>] bus_for_each_dev+0x5c/0xa0
[   17.698899] [<ffff00000876aee8>] driver_attach+0x20/0x28
[   17.704200] [<ffff0000087697d0>] bus_add_driver+0x1c8/0x230
[   17.708031] ata5: SATA link down (SStatus 0 SControl 300)
[   17.715147] [<ffff00000876b620>] driver_register+0x60/0xf8
[   17.720621] [<ffff0000085103a0>] __pci_register_driver+0x38/0x40
[   17.726617] [<ffff0000090b2fec>] ahci_pci_driver_init+0x20/0x28
[   17.732527] [<ffff000009080c88>] do_one_initcall+0x84/0x114
[   17.738089] [<ffff000009080ed0>] kernel_init_freeable+0x1b8/0x25c
[   17.744172] [<ffff000008c20f30>] kernel_init+0x10/0x108
[   17.749386] [<ffff000008082e90>] ret_from_fork+0x10/0x40
[   17.755136] scsi host5: ahci
[   17.758152] ata6: SATA max UDMA/133 abar m2097152 at 0x915000000000 port 0x915000000100
[   17.766004] ahci 0005:00:0a.0: AHCI 0001.0300 32 slots 1 ports 6 Gbps 0x1 impl SATA mode
[   17.774095] ahci 0005:00:0a.0: flags: 64bit ncq sntf ilck pm led clo only pmp fbs pio slum part ccc apst 
[   17.783660] ahci 0005:00:0a.0: port 0 is not capable of FBS
[   17.789335] ------------[ cut here ]------------
[   17.793946] WARNING: CPU: 49 PID: 1 at drivers/ata/libata-core.c:6426 ata_host_activate+0x138/0x150
[   17.802977] 
[   17.804460] CPU: 49 PID: 1 Comm: swapper/0 Tainted: G        W       4.8.1-00004-gf0dadca853a2 #171
[   17.813491] Hardware name: www.cavium.com ThunderX CRB-2S/ThunderX CRB-2S, BIOS 0.3 Sep 13 2016
[   17.822177] task: ffff800fc8340000 task.stack: ffff810000484000
[   17.828085] PC is at ata_host_activate+0x138/0x150
[   17.832866] LR is at ata_host_activate+0x5c/0x150
[   17.837559] pc : [<ffff0000087b7868>] lr : [<ffff0000087b778c>] pstate: 60000045
[   17.844942] sp : ffff810000487a90
[   17.848246] x29: ffff810000487a90 x28: 0000000000000001 
[   17.853553] x27: ffff000009245408 x26: ffff000009245bf0 
[   17.858861] x25: ffff8100084850a0 x24: ffff81000a705e18 
[   17.864169] x23: 0000000000000080 x22: ffff000009245bf0 
[   17.869477] x21: 0000000000000000 x20: ffff0000087cddc8 
[   17.874784] x19: ffff81000a705f18 x18: ffff0000892f7d77 
[   17.880092] x17: ffff7fe040029ea0 x16: ffffffffffffff98 
[   17.885399] x15: 0000000000000006 x14: ffff0000092f7d85 
[   17.890707] x13: ffff00000a6dffff x12: 0000000000000008 
[   17.896014] x11: 0088000000000000 x10: 0140000000000040 
[   17.901321] x9 : 0000000000000000 x8 : ffff00000a6d6500 
[   17.906628] x7 : 0000000000000006 x6 : ffff810000484000 
[   17.911936] x5 : ffff81000a71b880 x4 : 0000000000000000 
[   17.917244] x3 : ffff00001ec00104 x2 : ffff81000a705e18 
[   17.922551] x1 : 0000000000000040 x0 : 0000000000000000 
[   17.927858] 
[   17.929339] ---[ end trace 2c145cc81872d4a4 ]---
[   17.933945] Call trace:
[   17.936381] Exception stack(0xffff8100004878c0 to 0xffff8100004879f0)
[   17.942811] 78c0: ffff81000a705f18 0001000000000000 ffff810000487a90 ffff0000087b7868
[   17.950630] 78e0: ffff00000a6c0000 0000000000020000 0000000000000008 00e800000000070f
[   17.958449] 7900: 0000000000000000 ffff7fe000300400 ffff810000487990 ffff000008776250
[   17.966267] 7920: ffff8100084850a0 ffff810008485150 0000000000000004 0000000000000040
[   17.974085] 7940: 0000000000016500 ffff81000a705e18 ffff810000487990 ffff0000087d10e8
[   17.981904] 7960: 0000000000000000 0000000000000040 ffff81000a705e18 ffff00001ec00104
[   17.989722] 7980: 0000000000000000 ffff81000a71b880 ffff810000484000 0000000000000006
[   17.997541] 79a0: ffff00000a6d6500 0000000000000000 0140000000000040 0088000000000000
[   18.005359] 79c0: 0000000000000008 ffff00000a6dffff ffff0000092f7d85 0000000000000006
[   18.013177] 79e0: ffffffffffffff98 ffff7fe040029ea0
[   18.018044] [<ffff0000087b7868>] ata_host_activate+0x138/0x150
[   18.023867] [<ffff0000087d2950>] ahci_host_activate+0x138/0x170
[   18.029775] [<ffff0000087ced84>] ahci_init_one+0x8d4/0xd50
[   18.035250] [<ffff00000850f394>] local_pci_probe+0x3c/0xb8
[   18.040725] [<ffff000008510330>] pci_device_probe+0x110/0x148
[   18.046460] [<ffff00000876ac54>] driver_probe_device+0x204/0x2b0
[   18.052456] [<ffff00000876adac>] __driver_attach+0xac/0xb0
[   18.057931] [<ffff000008768d24>] bus_for_each_dev+0x5c/0xa0
[   18.063492] [<ffff00000876aee8>] driver_attach+0x20/0x28
[   18.068793] [<ffff0000087697d0>] bus_add_driver+0x1c8/0x230
[   18.074355] [<ffff00000876b620>] driver_register+0x60/0xf8
[   18.079829] [<ffff0000085103a0>] __pci_register_driver+0x38/0x40
[   18.080051] ata6: SATA link down (SStatus 0 SControl 300)
[   18.091210] [<ffff0000090b2fec>] ahci_pci_driver_init+0x20/0x28
[   18.097120] [<ffff000009080c88>] do_one_initcall+0x84/0x114
[   18.102682] [<ffff000009080ed0>] kernel_init_freeable+0x1b8/0x25c
[   18.108765] [<ffff000008c20f30>] kernel_init+0x10/0x108
[   18.113979] [<ffff000008082e90>] ret_from_fork+0x10/0x40
[   18.119725] scsi host6: ahci
[   18.122747] ata7: SATA max UDMA/133 abar m2097152 at 0x916000000000 port 0x916000000100
[   18.130601] ahci 0005:00:0b.0: AHCI 0001.0300 32 slots 1 ports 6 Gbps 0x1 impl SATA mode
[   18.138693] ahci 0005:00:0b.0: flags: 64bit ncq sntf ilck pm led clo only pmp fbs pio slum part ccc apst 
[   18.148258] ahci 0005:00:0b.0: port 0 is not capable of FBS
[   18.153931] ------------[ cut here ]------------
[   18.158542] WARNING: CPU: 49 PID: 1 at drivers/ata/libata-core.c:6426 ata_host_activate+0x138/0x150
[   18.167574] 
[   18.169057] CPU: 49 PID: 1 Comm: swapper/0 Tainted: G        W       4.8.1-00004-gf0dadca853a2 #171
[   18.178089] Hardware name: www.cavium.com ThunderX CRB-2S/ThunderX CRB-2S, BIOS 0.3 Sep 13 2016
[   18.186774] task: ffff800fc8340000 task.stack: ffff810000484000
[   18.192683] PC is at ata_host_activate+0x138/0x150
[   18.197463] LR is at ata_host_activate+0x5c/0x150
[   18.202156] pc : [<ffff0000087b7868>] lr : [<ffff0000087b778c>] pstate: 60000045
[   18.209539] sp : ffff810000487a90
[   18.212843] x29: ffff810000487a90 x28: 0000000000000001 
[   18.218150] x27: ffff000009245408 x26: ffff000009245bf0 
[   18.223458] x25: ffff8100084870a0 x24: ffff81000a70ec18 
[   18.228765] x23: 0000000000000080 x22: ffff000009245bf0 
[   18.234073] x21: 0000000000000000 x20: ffff0000087cddc8 
[   18.239380] x19: ffff81000a70eb18 x18: ffff0000892f7d77 
[   18.244688] x17: ffff7fe040029ee0 x16: ffffffffffffff98 
[   18.249995] x15: 0000000000000006 x14: ffff0000092f7d85 
[   18.255303] x13: ffff00000a73ffff x12: 0000000000000008 
[   18.260611] x11: 0088000000000000 x10: 0140000000000040 
[   18.265918] x9 : 0000000000000000 x8 : ffff00000a736500 
[   18.271225] x7 : 0000000000000006 x6 : ffff810000484000 
[   18.276533] x5 : ffff81000a719a80 x4 : 0000000000000000 
[   18.281840] x3 : ffff00001f000104 x2 : ffff81000a70ec18 
[   18.287148] x1 : 0000000000000040 x0 : 0000000000000000 
[   18.292455] 
[   18.293936] ---[ end trace 2c145cc81872d4a5 ]---
[   18.298542] Call trace:
[   18.300979] Exception stack(0xffff8100004878c0 to 0xffff8100004879f0)
[   18.307409] 78c0: ffff81000a70eb18 0001000000000000 ffff810000487a90 ffff0000087b7868
[   18.315228] 78e0: ffff00000a720000 0000000000020000 0000000000000008 00e800000000070f
[   18.323046] 7900: 0000000000000000 ffff7fe000300480 ffff810000487990 ffff000008776250
[   18.330865] 7920: ffff8100084870a0 ffff810008487150 0000000000000004 0000000000000040
[   18.338683] 7940: 0000000000016500 ffff81000a70ec18 ffff810000487990 ffff0000087d10e8
[   18.346502] 7960: 0000000000000000 0000000000000040 ffff81000a70ec18 ffff00001f000104
[   18.354320] 7980: 0000000000000000 ffff81000a719a80 ffff810000484000 0000000000000006
[   18.362139] 79a0: ffff00000a736500 0000000000000000 0140000000000040 0088000000000000
[   18.369957] 79c0: 0000000000000008 ffff00000a73ffff ffff0000092f7d85 0000000000000006
[   18.377775] 79e0: ffffffffffffff98 ffff7fe040029ee0
[   18.382643] [<ffff0000087b7868>] ata_host_activate+0x138/0x150
[   18.388465] [<ffff0000087d2950>] ahci_host_activate+0x138/0x170
[   18.394373] [<ffff0000087ced84>] ahci_init_one+0x8d4/0xd50
[   18.399848] [<ffff00000850f394>] local_pci_probe+0x3c/0xb8
[   18.405323] [<ffff000008510330>] pci_device_probe+0x110/0x148
[   18.411059] [<ffff00000876ac54>] driver_probe_device+0x204/0x2b0
[   18.417055] [<ffff00000876adac>] __driver_attach+0xac/0xb0
[   18.422529] [<ffff000008768d24>] bus_for_each_dev+0x5c/0xa0
[   18.428091] [<ffff00000876aee8>] driver_attach+0x20/0x28
[   18.433392] [<ffff0000087697d0>] bus_add_driver+0x1c8/0x230
[   18.438954] [<ffff00000876b620>] driver_register+0x60/0xf8
[   18.444010] ata7: SATA link down (SStatus 0 SControl 300)
[   18.449813] [<ffff0000085103a0>] __pci_register_driver+0x38/0x40
[   18.455809] [<ffff0000090b2fec>] ahci_pci_driver_init+0x20/0x28
[   18.461719] [<ffff000009080c88>] do_one_initcall+0x84/0x114
[   18.467281] [<ffff000009080ed0>] kernel_init_freeable+0x1b8/0x25c
[   18.473364] [<ffff000008c20f30>] kernel_init+0x10/0x108
[   18.478578] [<ffff000008082e90>] ret_from_fork+0x10/0x40
[   18.484409] scsi host7: ahci
[   18.487425] ata8: SATA max UDMA/133 abar m2097152 at 0x917000000000 port 0x917000000100
...
[   18.808074] ata8: SATA link down (SStatus 0 SControl 300)
...
[   21.765921] ata1.00: qc timeout (cmd 0xec)
[   21.770031] ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   22.249869] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
[   22.533896] ata4.00: qc timeout (cmd 0xec)
[   22.537996] ata4.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   23.017874] ata4: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
[   32.261874] ata1.00: qc timeout (cmd 0xec)
[   32.265972] ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   32.272059] ata1: limiting SATA link speed to 3.0 Gbps
[   32.753873] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   33.029878] ata4.00: qc timeout (cmd 0xec)
[   33.033978] ata4.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   33.040066] ata4: limiting SATA link speed to 3.0 Gbps
[   33.521884] ata4: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   63.493874] ata1.00: qc timeout (cmd 0xec)
[   63.497973] ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   63.977867] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   65.541890] ata4.00: qc timeout (cmd 0xec)
[   65.545987] ata4.00: failed to IDENTIFY (I/O error, err_mask=0x4)
[   66.025873] ata4: SATA link up 3.0 Gbps (SStatus 123 SControl 320)
[   66.032337] VFS: Cannot open root device "sda2" or unknown-block(0,0): error -6
[   66.039682] Please append a correct "root=" boot option; here are the available partitions:
[   66.048047] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0)
[   66.056304] CPU: 55 PID: 1 Comm: swapper/0 Tainted: G        W       4.8.1-00004-gf0dadca853a2 #171
[   66.065337] Hardware name: www.cavium.com ThunderX CRB-2S/ThunderX CRB-2S, BIOS 0.3 Sep 13 2016
[   66.074023] Call trace:
[   66.076474] [<ffff0000080883c8>] dump_backtrace+0x0/0x1a0
[   66.081863] [<ffff00000808857c>] show_stack+0x14/0x20
[   66.086908] [<ffff00000849adf4>] dump_stack+0x94/0xb8
[   66.091956] [<ffff00000815df94>] panic+0x10c/0x26c
[   66.096744] [<ffff000009081318>] mount_block_root+0x18c/0x264
[   66.102480] [<ffff00000908150c>] mount_root+0x11c/0x134
[   66.107695] [<ffff000009081660>] prepare_namespace+0x13c/0x184
[   66.113517] [<ffff000009080f50>] kernel_init_freeable+0x238/0x25c
[   66.119607] [<ffff000008c20f30>] kernel_init+0x10/0x108
[   66.124822] [<ffff000008082e90>] ret_from_fork+0x10/0x40
[   66.130125] SMP: stopping secondary CPUs

^ permalink raw reply	[flat|nested] 19+ messages in thread
* Re: [PATCH] ahci: use pci_alloc_irq_vectors
  2016-10-21 14:01           ` Robert Richter
@ 2016-10-22 14:11             ` Christoph Hellwig
  -1 siblings, 0 replies; 19+ messages in thread
From: Christoph Hellwig @ 2016-10-22 14:11 UTC (permalink / raw)
  To: Robert Richter
  Cc: Christoph Hellwig, Robert Richter, Auger Eric, Marc Zyngier,
	linux-ide, dan.j.williamps, Tejun Heo, linux-arm-kernel

Hi Robert,

is this a controller that's using MSI-X?

If so can you try the patch below?

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index ba5f11c..5fe852d 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1617,7 +1617,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 		/* legacy intx interrupts */
 		pci_intx(pdev, 1);
 	}
-	hpriv->irq = pdev->irq;
+	hpriv->irq = pci_irq_vector(pdev, 0);
 
 	if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss)
 		host->flags |= ATA_HOST_PARALLEL_SCAN;

^ permalink raw reply related	[flat|nested] 19+ messages in thread
* [PATCH] ahci: use pci_alloc_irq_vectors
@ 2016-10-22 14:11             ` Christoph Hellwig
  0 siblings, 0 replies; 19+ messages in thread
From: Christoph Hellwig @ 2016-10-22 14:11 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Robert,

is this a controller that's using MSI-X?

If so can you try the patch below?

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index ba5f11c..5fe852d 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1617,7 +1617,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 		/* legacy intx interrupts */
 		pci_intx(pdev, 1);
 	}
-	hpriv->irq = pdev->irq;
+	hpriv->irq = pci_irq_vector(pdev, 0);
 
 	if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss)
 		host->flags |= ATA_HOST_PARALLEL_SCAN;

^ permalink raw reply related	[flat|nested] 19+ messages in thread
* Re: [PATCH] ahci: use pci_alloc_irq_vectors
  2016-10-22 14:11             ` Christoph Hellwig
@ 2016-10-24 18:57               ` David Daney
  -1 siblings, 0 replies; 19+ messages in thread
From: David Daney @ 2016-10-24 18:57 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Robert Richter, linux-ide, Marc Zyngier, Auger Eric,
	Robert Richter, dan.j.williamps, Tejun Heo, linux-arm-kernel

Hi Christoph,

I can answer these...

On 10/22/2016 07:11 AM, Christoph Hellwig wrote:
> Hi Robert,
>
> is this a controller that's using MSI-X?

Yes.  This is a ThunderX SoC with on-chip AHCI that use MSI-X

>
> If so can you try the patch below?

I applied it to v4.9-rc1 (really commit 
6f33d6458e35d6ba53c2635ee4b8a3177cbd912d), and this didn't seem to make 
it work.



>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index ba5f11c..5fe852d 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1617,7 +1617,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>   		/* legacy intx interrupts */
>   		pci_intx(pdev, 1);
>   	}
> -	hpriv->irq = pdev->irq;
> +	hpriv->irq = pci_irq_vector(pdev, 0);
>
>   	if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss)
>   		host->flags |= ATA_HOST_PARALLEL_SCAN;
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>


^ permalink raw reply	[flat|nested] 19+ messages in thread
* [PATCH] ahci: use pci_alloc_irq_vectors
@ 2016-10-24 18:57               ` David Daney
  0 siblings, 0 replies; 19+ messages in thread
From: David Daney @ 2016-10-24 18:57 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Christoph,

I can answer these...

On 10/22/2016 07:11 AM, Christoph Hellwig wrote:
> Hi Robert,
>
> is this a controller that's using MSI-X?

Yes.  This is a ThunderX SoC with on-chip AHCI that use MSI-X

>
> If so can you try the patch below?

I applied it to v4.9-rc1 (really commit 
6f33d6458e35d6ba53c2635ee4b8a3177cbd912d), and this didn't seem to make 
it work.



>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index ba5f11c..5fe852d 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1617,7 +1617,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>   		/* legacy intx interrupts */
>   		pci_intx(pdev, 1);
>   	}
> -	hpriv->irq = pdev->irq;
> +	hpriv->irq = pci_irq_vector(pdev, 0);
>
>   	if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss)
>   		host->flags |= ATA_HOST_PARALLEL_SCAN;
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

^ permalink raw reply	[flat|nested] 19+ messages in thread
* Re: [PATCH] ahci: use pci_alloc_irq_vectors
  2016-10-24 18:57               ` David Daney
@ 2016-10-24 19:21                 ` Christoph Hellwig
  -1 siblings, 0 replies; 19+ messages in thread
From: Christoph Hellwig @ 2016-10-24 19:21 UTC (permalink / raw)
  To: David Daney
  Cc: Robert Richter, Auger Eric, Marc Zyngier, linux-ide,
	Robert Richter, dan.j.williamps, Tejun Heo, Christoph Hellwig,
	linux-arm-kernel

Hi David,

On Mon, Oct 24, 2016 at 11:57:46AM -0700, David Daney wrote:
>> If so can you try the patch below?
>
> I applied it to v4.9-rc1 (really commit 
> 6f33d6458e35d6ba53c2635ee4b8a3177cbd912d), and this didn't seem to make it 
> work.

Please try on top of the libata for-4.9-fixes branch:

https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/log/?h=for-4.9-fixes

^ permalink raw reply	[flat|nested] 19+ messages in thread
* [PATCH] ahci: use pci_alloc_irq_vectors
@ 2016-10-24 19:21                 ` Christoph Hellwig
  0 siblings, 0 replies; 19+ messages in thread
From: Christoph Hellwig @ 2016-10-24 19:21 UTC (permalink / raw)
  To: linux-arm-kernel

Hi David,

On Mon, Oct 24, 2016 at 11:57:46AM -0700, David Daney wrote:
>> If so can you try the patch below?
>
> I applied it to v4.9-rc1 (really commit 
> 6f33d6458e35d6ba53c2635ee4b8a3177cbd912d), and this didn't seem to make it 
> work.

Please try on top of the libata for-4.9-fixes branch:

https://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/log/?h=for-4.9-fixes

^ permalink raw reply	[flat|nested] 19+ messages in thread
* Re: [PATCH] ahci: use pci_alloc_irq_vectors
  2016-10-22 14:11             ` Christoph Hellwig
@ 2016-10-24 20:29               ` David Daney
  -1 siblings, 0 replies; 19+ messages in thread
From: David Daney @ 2016-10-24 20:29 UTC (permalink / raw)
  To: Christoph Hellwig, Robert Richter
  Cc: Auger Eric, Marc Zyngier, linux-ide, Robert Richter,
	dan.j.williamps, Tejun Heo, linux-arm-kernel

On 10/22/2016 07:11 AM, Christoph Hellwig wrote:
> Hi Robert,
>
> is this a controller that's using MSI-X?
>
> If so can you try the patch below?
>

After better understanding your request, I applied this against:

http://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/log/?h=for-4.9-fixes 
(commit a478b097474cd9f2268ab1beaca74ff09e652b9b)

This is now working on my ThunderX CRB-2S system.

You can add:

Tested-by: David Daney <david.daney@cavium.com>


Thanks for taking the time to work through this.



> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index ba5f11c..5fe852d 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1617,7 +1617,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>   		/* legacy intx interrupts */
>   		pci_intx(pdev, 1);
>   	}
> -	hpriv->irq = pdev->irq;
> +	hpriv->irq = pci_irq_vector(pdev, 0);
>
>   	if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss)
>   		host->flags |= ATA_HOST_PARALLEL_SCAN;
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

^ permalink raw reply	[flat|nested] 19+ messages in thread
* [PATCH] ahci: use pci_alloc_irq_vectors
@ 2016-10-24 20:29               ` David Daney
  0 siblings, 0 replies; 19+ messages in thread
From: David Daney @ 2016-10-24 20:29 UTC (permalink / raw)
  To: linux-arm-kernel

On 10/22/2016 07:11 AM, Christoph Hellwig wrote:
> Hi Robert,
>
> is this a controller that's using MSI-X?
>
> If so can you try the patch below?
>

After better understanding your request, I applied this against:

http://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/log/?h=for-4.9-fixes 
(commit a478b097474cd9f2268ab1beaca74ff09e652b9b)

This is now working on my ThunderX CRB-2S system.

You can add:

Tested-by: David Daney <david.daney@cavium.com>


Thanks for taking the time to work through this.



> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index ba5f11c..5fe852d 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1617,7 +1617,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>   		/* legacy intx interrupts */
>   		pci_intx(pdev, 1);
>   	}
> -	hpriv->irq = pdev->irq;
> +	hpriv->irq = pci_irq_vector(pdev, 0);
>
>   	if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss)
>   		host->flags |= ATA_HOST_PARALLEL_SCAN;
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

^ permalink raw reply	[flat|nested] 19+ messages in thread
* Re: [PATCH] ahci: use pci_alloc_irq_vectors
  2016-10-22 14:11             ` Christoph Hellwig
@ 2016-10-25  9:25               ` Robert Richter
  -1 siblings, 0 replies; 19+ messages in thread
From: Robert Richter @ 2016-10-25  9:25 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Robert Richter, Auger Eric, Marc Zyngier, linux-ide,
	dan.j.williamps, Tejun Heo, linux-arm-kernel

On 22.10.16 16:11:23, Christoph Hellwig wrote:
> Hi Robert,
> 
> is this a controller that's using MSI-X?
> 
> If so can you try the patch below?

Great, that fixes the issue. Thanks.

Tested-by: Robert Richter <rrichter@cavium.com>

> 
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index ba5f11c..5fe852d 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1617,7 +1617,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  		/* legacy intx interrupts */
>  		pci_intx(pdev, 1);
>  	}
> -	hpriv->irq = pdev->irq;
> +	hpriv->irq = pci_irq_vector(pdev, 0);
>  
>  	if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss)
>  		host->flags |= ATA_HOST_PARALLEL_SCAN;

^ permalink raw reply	[flat|nested] 19+ messages in thread
* [PATCH] ahci: use pci_alloc_irq_vectors
@ 2016-10-25  9:25               ` Robert Richter
  0 siblings, 0 replies; 19+ messages in thread
From: Robert Richter @ 2016-10-25  9:25 UTC (permalink / raw)
  To: linux-arm-kernel

On 22.10.16 16:11:23, Christoph Hellwig wrote:
> Hi Robert,
> 
> is this a controller that's using MSI-X?
> 
> If so can you try the patch below?

Great, that fixes the issue. Thanks.

Tested-by: Robert Richter <rrichter@cavium.com>

> 
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index ba5f11c..5fe852d 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -1617,7 +1617,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  		/* legacy intx interrupts */
>  		pci_intx(pdev, 1);
>  	}
> -	hpriv->irq = pdev->irq;
> +	hpriv->irq = pci_irq_vector(pdev, 0);
>  
>  	if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss)
>  		host->flags |= ATA_HOST_PARALLEL_SCAN;

^ permalink raw reply	[flat|nested] 19+ messages in thread
end of thread, other threads:[~2016-10-25  9:25 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-05 15:21 (unknown), Christoph Hellwig
2016-09-05 15:21 ` [PATCH] ahci: use pci_alloc_irq_vectors Christoph Hellwig
2016-09-06 16:39   ` Tejun Heo
2016-10-20 15:47     ` Robert Richter
2016-10-20 15:47       ` Robert Richter
2016-10-21 12:59       ` Christoph Hellwig
2016-10-21 12:59         ` Christoph Hellwig
2016-10-21 14:01         ` Robert Richter
2016-10-21 14:01           ` Robert Richter
2016-10-22 14:11           ` Christoph Hellwig
2016-10-22 14:11             ` Christoph Hellwig
2016-10-24 18:57             ` David Daney
2016-10-24 18:57               ` David Daney
2016-10-24 19:21               ` Christoph Hellwig
2016-10-24 19:21                 ` Christoph Hellwig
2016-10-24 20:29             ` David Daney
2016-10-24 20:29               ` David Daney
2016-10-25  9:25             ` Robert Richter
2016-10-25  9:25               ` Robert Richter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.