From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [RFC V4 PATCH 1/6] arm64: dts: msm8992 SoC and LG Bullhead (Nexus 5X) support Date: Fri, 21 Oct 2016 11:20:04 -0700 Message-ID: <20161021182004.GW7509@tuxbot> References: <1477048273-32451-1-git-send-email-jeremymc@redhat.com> <1477048273-32451-2-git-send-email-jeremymc@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f171.google.com ([209.85.192.171]:34085 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934172AbcJUSUJ (ORCPT ); Fri, 21 Oct 2016 14:20:09 -0400 Received: by mail-pf0-f171.google.com with SMTP id r16so60852982pfg.1 for ; Fri, 21 Oct 2016 11:20:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1477048273-32451-2-git-send-email-jeremymc@redhat.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Jeremy McNicoll Cc: linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, robh@kernel.org, andy.gross@linaro.org, sboyd@codeaurora.org, arnd@arndb.de, mark.rutland@arm.com, michael.scott@linaro.org On Fri 21 Oct 04:11 PDT 2016, Jeremy McNicoll wrote: > From: Jeremy McNicoll > > Initial device tree support for Qualcomm MSM8992 SoC and > LG Bullhead / Google Nexus 5X support. > Looks reasonable, just two small nits below. > Signed-off-by: Jeremy McNicoll > --- > arch/arm64/boot/dts/qcom/Makefile | 4 +- > .../boot/dts/qcom/msm8992-bullhead-rev-101.dts | 42 ++++ > arch/arm64/boot/dts/qcom/msm8992-pins.dtsi | 38 ++++ > arch/arm64/boot/dts/qcom/msm8992.dtsi | 214 +++++++++++++++++++++ > 4 files changed, 296 insertions(+), 2 deletions(-) > create mode 100644 arch/arm64/boot/dts/qcom/msm8992-bullhead-rev-101.dts > create mode 100644 arch/arm64/boot/dts/qcom/msm8992-pins.dtsi > create mode 100644 arch/arm64/boot/dts/qcom/msm8992.dtsi > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 5dd05de..abb366e 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -1,6 +1,6 @@ > dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc.dtb msm8916-mtp.dtb > -dtb-$(CONFIG_ARCH_QCOM) += msm8996-mtp.dtb > -dtb-$(CONFIG_ARCH_QCOM) += apq8096-db820c.dtb > +dtb-$(CONFIG_ARCH_QCOM) += msm8996-mtp.dtb apq8096-db820c.dtb Don't change these, just add yours. [..] > diff --git a/arch/arm64/boot/dts/qcom/msm8992.dtsi b/arch/arm64/boot/dts/qcom/msm8992.dtsi [..] > + > + msmgpio: pinctrl@fd510000 { > + compatible = "qcom,msm8994-pinctrl", "qcom,msm8974-pinctrl"; This device is not compatible with the msm8974 TLMM, so please drop the second compatible. > + reg = <0xfd510000 0x4000>; > + interrupts = ; > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + Regards, Bjorn