From mboxrd@z Thu Jan 1 00:00:00 1970 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH 1/2] KVM: VMX: clean up declaration of VPID/EPT invalidation types Date: Fri, 21 Oct 2016 21:40:29 +0200 Message-ID: <20161021194029.GB29131@potion> References: <1476830705-19269-1-git-send-email-jan.dakinevich@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, pbonzini@redhat.com, kernellwp@gmail.com To: Jan Dakinevich Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59854 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932277AbcJUTkd (ORCPT ); Fri, 21 Oct 2016 15:40:33 -0400 Content-Disposition: inline In-Reply-To: <1476830705-19269-1-git-send-email-jan.dakinevich@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: 2016-10-19 01:45+0300, Jan Dakinevich: > - Remove VMX_EPT_EXTENT_INDIVIDUAL_ADDR, since there is no such type of > EPT invalidation > > - Rename VMX_VPID_EXTENT_ALL_CONTEXT to VMX_VPID_EXTENT_GLOBAL_CONTEXT > for consitency: all-context VPID invalidation is referenced by > "global" keyword in all other places of code SDM names this invalidation as "all contexts" and global translations have a different meaning, so I would keep it, for clarity. We already use the other meaning in SINGLE_CONTEXT_RETAINING_GLOBALS and for example INVPCID has type for "all contexts, including globals" and "all contexts, excluding globals", so we will have to really distinguish global and global at some point ... > - Add missing VPID types names > > Signed-off-by: Jan Dakinevich > ---