From: Daniel Vetter <daniel@ffwll.ch>
To: Sagar Arun Kamble <sagar.a.kamble@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/1] drm/i915: Give write permission to gt_boost_freq_mhz
Date: Mon, 24 Oct 2016 11:07:05 +0200 [thread overview]
Message-ID: <20161024090705.GO20761@phenom.ffwll.local> (raw)
In-Reply-To: <20161024090513.GN20761@phenom.ffwll.local>
On Mon, Oct 24, 2016 at 11:05:13AM +0200, Daniel Vetter wrote:
> On Mon, Oct 24, 2016 at 10:00:49AM +0530, Sagar Arun Kamble wrote:
>
> And uabi change with 0 commit message. This needs to be _much_ better ;-)
Also the patch subject isn't really useful: It's a literal translation
from the patch to Enlish, which adds nothing. Much better to summarize a
patch in terms of impacts and goals, e.g. "Allow userspace to set gpu
boost".
Plus of course then explain in the commit message why that is a good idea,
why we need it, testcase and userspace for this and all this stuff.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-24 9:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 4:30 [PATCH 1/1] drm/i915: Give write permission to gt_boost_freq_mhz Sagar Arun Kamble
2016-10-24 4:47 ` ✓ Fi.CI.BAT: success for series starting with [1/1] " Patchwork
2016-10-24 9:05 ` [PATCH 1/1] " Daniel Vetter
2016-10-24 9:07 ` Daniel Vetter [this message]
2016-10-24 9:12 ` Chris Wilson
2016-10-24 10:13 ` Kamble, Sagar A
2016-10-26 6:15 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024090705.GO20761@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sagar.a.kamble@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.