From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bye1L-0002ac-DV for qemu-devel@nongnu.org; Mon, 24 Oct 2016 08:06:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bye1G-00011u-Ia for qemu-devel@nongnu.org; Mon, 24 Oct 2016 08:06:27 -0400 Date: Mon, 24 Oct 2016 23:04:50 +1100 From: David Gibson Message-ID: <20161024120450.GH11052@umbus.fritz.box> References: <1476823604-15403-1-git-send-email-thuth@redhat.com> <20161019021650.GC11140@umbus.fritz.box> <317ca528-643a-42be-0a5a-e5c25bb2dec6@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wayzTnRSUXKNfBqd" Content-Disposition: inline In-Reply-To: <317ca528-643a-42be-0a5a-e5c25bb2dec6@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/5] nvram: Refactor OpenBIOS NVRAM code to support -prom-env on pseries, too List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Bharata B Rao , Mark Cave-Ayland , "qemu-ppc@nongnu.org" , Alexander Graf , Artyom Tarasenko , "qemu-devel@nongnu.org" --wayzTnRSUXKNfBqd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 24, 2016 at 12:36:05PM +0200, Thomas Huth wrote: > On 24.10.2016 12:22, Bharata B Rao wrote: > >=20 > > On Wed, Oct 19, 2016 at 7:46 AM, David Gibson > > > wrot= e: > >=20 > > On Tue, Oct 18, 2016 at 10:46:39PM +0200, Thomas Huth wrote: > > > The OpenBIOS NVRAM set-up is based on the layout defined in the C= HRP > > > (Common Hardware Reference Platform) specification. This is the s= ame > > > layout that is also used by the PAPR specification and thus by the > > SLOF > > > firmware of the pseries machine. By refactoring the NVRAM code fr= om > > > mac_nvram.c, we can use the same functions for setting up the NVR= AM > > > for both, OpenBIOS and SLOF. This way we can support the "-prom-e= nv" > > > parameter of QEMU for SLOF, too, which is very useful to influence > > > the firmware boot process. > > > > > > Thomas Huth (5): > > > nvram: Introduce helper functions for CHRP "system" and "free s= pace" > > > partitions > > > sparc: Use the new common NVRAM functions for system and free s= pace > > > partition > > > spapr_nvram: Pre-initialize the NVRAM to support the -prom-env > > > parameter > > > nvram: Move the remaining CHRP NVRAM related code to chrp_nvram= =2E[ch] > > > nvram: Rename openbios_firmware_abi.h into sun_nvram.h > > > > > > hw/nvram/Makefile.objs | 1 + > > > hw/nvram/chrp_nvram.c | 85 > > ++++++++++++++++++++++ > > > hw/nvram/mac_nvram.c | 49 +++-----= ----- > > > hw/nvram/spapr_nvram.c | 6 ++ > > > hw/sparc/sun4m.c | 35 ++------- > > > hw/sparc64/sun4u.c | 35 ++------- > > > include/hw/nvram/chrp_nvram.h | 54 > > ++++++++++++++ > > > .../nvram/{openbios_firmware_abi.h =3D> sun_nvram.h} | 47 +-----= ------ > > > tests/postcopy-test.c | 8 +- > > > 9 files changed, 179 insertions(+), 141 deletions(-) > > > create mode 100644 hw/nvram/chrp_nvram.c > > > create mode 100644 include/hw/nvram/chrp_nvram.h > > > rename include/hw/nvram/{openbios_firmware_abi.h =3D> sun_nvram.= h} > > (50%) > >=20 > > Series, > >=20 > > Reviewed-by: David Gibson > > > >=20 > > I've put it into ppc-for-2.8 tentatively. However I'd like to get = an > > Acked-by from Mark for the Sparc bits before I send my next pull > > request. > >=20 > >=20 > > I observe an early boot failure in SLOF with a commit from this patchset > > on ppc-for-2.8 branch. > >=20 > > 4e1257ed41bce16baa8a010 - spapr_nvram: Pre-initialize the NVRAM to > > support the -prom-env parameter > >=20 > > SLOF ******************************************************************= **** > > QEMU Starting > > Build Date =3D Oct 19 2016 09:58:38 > > FW Version =3D git-efd65f49929d7db7 > > Press "s" to enter Open Firmware. > >=20 > > Populating /vdevice methods > > Populating /vdevice/vty@71000000 > > Populating /vdevice/nvram@71000001 > > Populating /vdevice/v-scsi@71000002 > > SCSI: Looking for devices > > 8200000000000000 CD-ROM : "QEMU QEMU CD-ROM 2.5+" > > Populating /pci@800000020000000 > > 00 1000 (D) : 1033 0194 serial bus [ usb-xhci ] > > 00 0800 (D) : 1af4 1001 virtio [ block ] > > 00 0000 (D) : 1af4 1000 virtio [ net ] > > Scanning USB > > XHCI: Initializing > > Using default console: /vdevice/vty@71000000 > > =20 > > Welcome to Open Firmware > >=20 > > Copyright (c) 2004, 2011 IBM Corporation All rights reserved. > > This program and the accompanying materials are made available > > under the terms of the BSD License available at > > http://www.opensource.org/licenses/bsd-license.php > >=20 > >=20 > > Trying to load: from: /pci@800000020000000/scsi@1 ... Successfully l= oaded > > error: out of memory. > > out of memory > > Aborted. Press any key to exit. >=20 > Yuck. Confirmed. Sorry for the inconvenience. Seems like SLOF does not > create the properties in the /options device tree node anymore in this ca= se. >=20 > David, could you please unqueue the "spapr_nvram: Pre-initialize the > NVRAM to support the -prom-env parameter" patch from the ppc-for-2.8 > branch until I figure out a fix for this problem? Thanks! Done. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --wayzTnRSUXKNfBqd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYDfjiAAoJEGw4ysog2bOSESkP/0GS4R0YkclZQBmCgES513Tx nsl9tLaNW00v78zvVzcr6QREMeb6qKg4uZ5RGClOvL3HC8uJnsQfYgiS8bjEWYG/ zGSeaxlqB/9i905QhKGKtYaQb1NMfNFXQDty+75HcdV7dUvbyY4yc4HoE/nPYkAW PGM7852z2AOGI4ZeY6AUfKuQ+nzhubFHsosoPBLvmk4HlJp0jV3sY6FQuD085kCh V6s5RSOlOiluW9onZrp8lfdDzjxjP31QLtBvgm4b19ZuSbhla3tBp/F9qhGPu4+/ JH5GOXUK0IU7kHnRgNqmxMvsMj1hXEKHUinYResazl6lKeuae02IcjIxc/FhtEmO 6EwNx3H4c7aoWETRb4HoErN+aPagXEo2ExlwlguTONctDdKUsupFTHiIaclt0i1y f4OkKCFF9cIag/YZxdBS5A0sjmd4noz18WUBvBNY47lFTZ60hTK9vT8eveiOE7Gw mFyOwMY8wi8EwmWmuPA+3XGhCWCpjqIbRksQvheyPjbRbkQF63UxQlgTKXNhI/e8 qMrHnbHos/gCfFpk0cwy/YqxXxGegbzKOMh7Ty0L1FpwsnR56GtHENgA6kwIj+M8 GC6GeSHR+OJO95J1QxVV0qw23mUS0iKmL+iWlJq6lyZ80i74KE6wzP1SPEu9NcYf zR7fXLI1IKmE/ARtstVA =62lJ -----END PGP SIGNATURE----- --wayzTnRSUXKNfBqd--