From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byfbe-00048l-I2 for qemu-devel@nongnu.org; Mon, 24 Oct 2016 09:48:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byfbd-0006Ny-Kh for qemu-devel@nongnu.org; Mon, 24 Oct 2016 09:48:02 -0400 Date: Mon, 24 Oct 2016 15:47:50 +0200 From: Kevin Wolf Message-ID: <20161024134750.GC4374@noname.redhat.com> References: <1476925867-24748-1-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476925867-24748-1-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2] less confusing block file names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, berrange@redhat.com, qemu-block@nongnu.org, stefanha@redhat.com, mreitz@redhat.com, armbru@redhat.com Am 20.10.2016 um 03:11 hat Eric Blake geschrieben: > Based on a suggestion here: > https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg00350.html > > Eric Blake (2): > block: Rename raw_bsd to raw.c > block: rename raw-{posix,win32} to file-*.c Seems to do what it promises: Reviewed-by: Kevin Wolf I'd like to hear a few more opinions on whether it's a good idea, but I don't think this should stay for too long on the list because we already have conflicting patches. One effect that makes me less than fully happy is that 'git log block/raw.c' without --follow mixes the history of the renamed driver with the history of the old, differently licensed one. On the other hand, the removal of the old driver happened three years ago, so it's probably unlikely that people confuse what belongs to which one and revive old code accidentally. Kevin