From: David Sterba <dsterba@suse.cz>
To: Wang Xiaoguang <wangxg.fnst@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: imporve delayed refs iterations
Date: Mon, 24 Oct 2016 18:46:39 +0200 [thread overview]
Message-ID: <20161024164639.GE22935@twin.jikos.cz> (raw)
In-Reply-To: <20161021090507.28425-1-wangxg.fnst@cn.fujitsu.com>
On Fri, Oct 21, 2016 at 05:05:07PM +0800, Wang Xiaoguang wrote:
> This issue was found when I tried to delete a heavily reflinked file,
> when deleting such files, other transaction operation will not have a
> chance to make progress, for example, start_transaction() will blocked
> in wait_current_trans(root) for long time, sometimes it even triggers
> soft lockups, and the time taken to delete such heavily reflinked file
> is also very large, often hundreds of seconds. Using perf top, it reports
> that:
> [...] With this patch, it just took about 10~15 seconds to
> delte the same file.
Great improvement! Patch looks good on a quick skim so I'll add it to
next, but proper review is still required.
next prev parent reply other threads:[~2016-10-24 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 9:05 [PATCH] btrfs: imporve delayed refs iterations Wang Xiaoguang
2016-10-24 16:46 ` David Sterba [this message]
2016-10-24 17:38 ` Holger Hoffstätte
2016-10-24 19:00 ` Liu Bo
2016-10-25 7:05 ` Wang Xiaoguang
2016-10-25 13:05 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024164639.GE22935@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wangxg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.