From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938870AbcJXSUB (ORCPT ); Mon, 24 Oct 2016 14:20:01 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:44940 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbcJXST6 (ORCPT ); Mon, 24 Oct 2016 14:19:58 -0400 Date: Mon, 24 Oct 2016 19:19:37 +0100 From: Mark Brown To: Axel Haslam Cc: Greg KH , Johan Hovold , robh+dt@kernel.org, Sekhar Nori , Alan Stern , Kevin Hilman , Sergei Shtylyov , David Lechner , manjunath.goudar@linaro.org, Alexandre Bailon , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Message-ID: <20161024181937.GP17252@sirena.org.uk> References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-10-ahaslam@baylibre.com> <20161024175320.GO17252@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ncX6roZrNNHXnAbh" Content-Disposition: inline In-Reply-To: X-Cookie: When the cup is full, carry it level. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ncX6roZrNNHXnAbh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 24, 2016 at 08:11:40PM +0200, Axel Haslam wrote: > On Mon, Oct 24, 2016 at 7:53 PM, Mark Brown wrote: > > does it make sense to report this as a mode, we don't report other error > > conditions as modes but instead use REGULATOR_STATUS_ with the > > get_status() operation? > I used mode, because when the regulator toggles the overcurrent > line, it means that it has entered a current limited mode, at least the > regulator im looking at. ill change to STATUS That's not what regulator modes are - please look at the documentation for the defines here. They're about the quality of regulation. --ncX6roZrNNHXnAbh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJYDlC4AAoJECTWi3JdVIfQmdUH/RuucFM9xqc+08wBouDQgC8s iSTRAq2UbaNAREQCLvxqRSeqzBISXdet55SDHo7kAhIYke8guFj9uUledjpjoIrQ eIpoYg2YFajqB5Zpr7lDFRu8mWeJC0+xl4e9ywU9smJBBXCsQDJotNqOvpVF0PJW eWa2mWNRLdcVCx7wvuDHFrzJ6sNp4lZkfDedMPdrfipkqMCGgpDsjLlyua2efHnI Md4cODQBziV+g/haCl/O89Wch9pA80EOtwSRgFo9psUYSK8QGRi3zJa5sKs3gKan xVo2KeaLuYWJRvSOlFdGK+36kKSzaXeug013Eo5AuoBMSxO2VaGGU9UVIVKouy8= =h4df -----END PGP SIGNATURE----- --ncX6roZrNNHXnAbh-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@kernel.org (Mark Brown) Date: Mon, 24 Oct 2016 19:19:37 +0100 Subject: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event In-Reply-To: References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-10-ahaslam@baylibre.com> <20161024175320.GO17252@sirena.org.uk> Message-ID: <20161024181937.GP17252@sirena.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Oct 24, 2016 at 08:11:40PM +0200, Axel Haslam wrote: > On Mon, Oct 24, 2016 at 7:53 PM, Mark Brown wrote: > > does it make sense to report this as a mode, we don't report other error > > conditions as modes but instead use REGULATOR_STATUS_ with the > > get_status() operation? > I used mode, because when the regulator toggles the overcurrent > line, it means that it has entered a current limited mode, at least the > regulator im looking at. ill change to STATUS That's not what regulator modes are - please look at the documentation for the defines here. They're about the quality of regulation. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: not available URL: