All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: aik@ozlabs.ru, mdroth@linux.vnet.ibm.com, groug@kaod.org
Cc: agraf@suse.de, lvivier@redhat.com, thuth@redhat.com,
	qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
	bharata@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCHv3 00/12] pseries: Consolidate guest device tree construction
Date: Tue, 25 Oct 2016 14:23:41 +1100	[thread overview]
Message-ID: <20161025032341.GS11052@umbus.fritz.box> (raw)
In-Reply-To: <20161025025002.GQ11052@umbus.fritz.box>

[-- Attachment #1: Type: text/plain, Size: 1710 bytes --]

On Tue, Oct 25, 2016 at 01:50:02PM +1100, David Gibson wrote:
> On Mon, Oct 24, 2016 at 04:04:31PM +1100, David Gibson wrote:
> > For historical reasons construction of the guest device tree in spapr
> > is divided between spapr_create_fdt_skel() which is called at init
> > time, and spapr_build_fdt() which runs at reset time.  Over time, more
> > and more things have needed to be moved to reset time.
> > 
> > This series consolidates all the device tree construction to reset
> > time, with some minor cleanups along the way.  This will help to make
> > it more maintainable in future.
> > 
> > Changes since v2:
> >   * Removed a leftover reference to a variable called 'stdout',
> >     shadowing the standard library stdout
> > Changes since v1:
> >   * Fixed a memory leak introduced by 1/12 (spotted by Thomas Huth)
> >   * Removed one patch that's already merged in ppc-for-2.8
> 
> Thanks for the acks, everyone.  I've now merged this series into
> ppc-for-2.8, tentatively.
> 
> Bharata Rao reported some boot failures caused by the series, but I
> haven't been able to reproduce them so far.  Bharata, could you retest
> with the latest version (in ppc-for-2.8) and, if the problems are
> still present, send me some reproducer steps.

Actually, I just realised the bug Bharata reported looks identical to
one someone else spotted.  That was caused by one of Thomas' NVRAM
cleanups, rather than the DT cleanup.  It's already been removed from
ppc-for-2.8 pending debug.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-10-25  3:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-24  5:04 [Qemu-devel] [PATCHv3 00/12] pseries: Consolidate guest device tree construction David Gibson
2016-10-24  5:04 ` [Qemu-devel] [PATCHv3 01/12] pseries: Split device tree construction from device tree load David Gibson
2016-10-24 19:03   ` Michael Roth
2016-10-25  0:57   ` Alexey Kardashevskiy
2016-10-24  5:04 ` [Qemu-devel] [PATCHv3 02/12] pseries: Remove rtas_addr and fdt_addr fields from machinestate David Gibson
2016-10-24 19:06   ` Michael Roth
2016-10-24  5:04 ` [Qemu-devel] [PATCHv3 03/12] pseries: Make spapr_create_fdt_skel() get information from machine state David Gibson
2016-10-24  5:04 ` [Qemu-devel] [PATCHv3 04/12] pseries: Move adding of fdt reserve map entries David Gibson
2016-10-24  5:04 ` [Qemu-devel] [PATCHv3 05/12] pseries: Consolidate RTAS loading David Gibson
2016-10-24  5:04 ` [Qemu-devel] [PATCHv3 06/12] pseries: Move construction of /interrupt-controller fdt node David Gibson
2016-10-24  5:04 ` [Qemu-devel] [PATCHv3 07/12] pseries: Consolidate construction of /chosen device tree node David Gibson
2016-10-24 19:10   ` Michael Roth
2016-10-24  5:04 ` [Qemu-devel] [PATCHv3 08/12] pseries: Consolidate construction of /rtas " David Gibson
2016-10-24  5:04 ` [Qemu-devel] [PATCHv3 09/12] pseries: Move /event-sources construction to spapr_build_fdt() David Gibson
2016-10-24  5:04 ` [Qemu-devel] [PATCHv3 10/12] pseries: Move /hypervisor node construction to fdt_build_fdt() David Gibson
2016-10-24  5:04 ` [Qemu-devel] [PATCHv3 11/12] pseries: Consolidate construction of /vdevice device tree node David Gibson
2016-10-24  5:04 ` [Qemu-devel] [PATCHv3 12/12] pseries: Remove spapr_create_fdt_skel() David Gibson
2016-10-25  2:50 ` [Qemu-devel] [PATCHv3 00/12] pseries: Consolidate guest device tree construction David Gibson
2016-10-25  3:23   ` David Gibson [this message]
2016-10-25  3:41     ` Bharata B Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161025032341.GS11052@umbus.fritz.box \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=groug@kaod.org \
    --cc=lvivier@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.