From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byspM-000810-HH for qemu-devel@nongnu.org; Mon, 24 Oct 2016 23:55:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byspI-0007zq-Dy for qemu-devel@nongnu.org; Mon, 24 Oct 2016 23:55:04 -0400 Date: Tue, 25 Oct 2016 14:35:52 +1100 From: David Gibson Message-ID: <20161025033552.GT11052@umbus.fritz.box> References: <1477285201-10244-1-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="A3RWl4qWgABmkY4K" Content-Disposition: inline In-Reply-To: <1477285201-10244-1-git-send-email-david@gibson.dropbear.id.au> Subject: Re: [Qemu-devel] [PATCHv5 00/12] Cleanups to qtest PCI handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: pbonzini@redhat.com, qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, lvivier@redhat.com, agraf@suse.de, stefanha@redhat.com, mst@redhat.com, aik@ozlabs.ru, mdroth@linux.vnet.ibm.com, groug@kaod.org, thuth@redhat.com --A3RWl4qWgABmkY4K Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 24, 2016 at 03:59:49PM +1100, David Gibson wrote: > This series contains a number of cleanups to the libqos code for > accessing PCI devices, and to tests which use it. >=20 > The general aim is to improve the consistency of semantics across > functions, and reduce the amount of intimate knowledge of the libqos > PCI layer needed by tests. >=20 > This should make it easier to write PCI tests which will be portable > to different guest machines with different PCI host bridge > arrangements. >=20 > This series is on top of my ppc-for-2.8 branch, since it contains > patches enabling the virtio tests on ppc, which would otherwise > conflict with the changes here. Greg, Alexey, Michael, Some reviews from outside RH would be really welcome. >=20 > Changes since v4: > * Fixed some remaining abstraction breaks in ahci-test > * Removed QPCI_BAR_INVALID, turned out not to really be useful >=20 > Changes since v3: > * Fixed another endian bug introduced in ide-test >=20 > Changes since v2: > * Fixed build bugs in virtio-9p-test, which I didn't find earlier > due to not having the right libraries installed > * Fixed an endian bug I accidentally introduced in ide-test > * Better handling of invalid BAR tokens >=20 > Changes since v1: > * Split out updates to tco-test into separate patch > * Split out updates to ide-test into separate patch > * Neater and more general handling of legacy PIO addresses > * Removed now-redundant fields from platform specific bus structures > * Introduced CONFIG_BASE() macro to virtio-pci to remove many > similar assignments > * Fixed handling of two guest testcasesin ivshmem > * Added 64-bit accessors > * Rebase on ppc-for-2.8 to avoid conflict with Laurent's series in > the same area >=20 > David Gibson (12): > libqos: Give qvirtio_config_read*() consistent semantics > libqos: Handle PCI IO de-multiplexing in common code > libqos: Move BAR assignment to common code > libqos: Better handling of PCI legacy IO > tests: Adjust tco-test to use qpci_legacy_iomap() > libqos: Add streaming accessors for PCI MMIO > libqos: Implement mmio accessors in terms of mem{read,write} > tests: Clean up IO handling in ide-test > libqos: Add 64-bit PCI IO accessors > tests: Use qpci_mem{read,write} in ivshmem-test > tests: Don't assume structure of PCI IO base in ahci-test > libqos: Change PCI accessors to take opaque BAR handle >=20 > tests/ahci-test.c | 13 +-- > tests/e1000e-test.c | 7 +- > tests/ide-test.c | 177 +++++++++++++++++++++++++++------------= -- > tests/ivshmem-test.c | 47 +++++++---- > tests/libqos/ahci.c | 4 +- > tests/libqos/ahci.h | 7 +- > tests/libqos/pci-pc.c | 187 ++++++++++-----------------------------= ---- > tests/libqos/pci-spapr.c | 194 ++++++++++++---------------------------= ------ > tests/libqos/pci.c | 194 +++++++++++++++++++++++++++++++++++++--= ------ > tests/libqos/pci.h | 66 ++++++++++----- > tests/libqos/usb.c | 6 +- > tests/libqos/usb.h | 2 +- > tests/libqos/virtio-mmio.c | 16 ++-- > tests/libqos/virtio-pci.c | 122 ++++++++++++++-------------- > tests/libqos/virtio-pci.h | 2 +- > tests/rtl8139-test.c | 10 +-- > tests/tco-test.c | 80 +++++++++---------- > tests/usb-hcd-ehci-test.c | 5 +- > tests/virtio-9p-test.c | 8 +- > tests/virtio-blk-test.c | 42 +++------- > tests/virtio-scsi-test.c | 4 +- > 21 files changed, 598 insertions(+), 595 deletions(-) >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --A3RWl4qWgABmkY4K Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYDtMWAAoJEGw4ysog2bOSX7sQAIBzcCDwtirshye6Rhkx8Kxf wD1XpkD3+AI8h3E9N/RIUl7gu0zNscmTwIswS+FunwFpoRsYBpdFSTAP5KF+3zVV nFCkYO+1poD+ual0Vzv0XQQzd+XBOLfKXIV76WChEtfTPEj+C9KTzvPBydn1JFWs FxhvCEnHji92ijmj4G1POu3SngrANc8gS1JbjEubos8ffKuTwSwILqQT8v1TfK/s DzJyQsZYQY5zViVp46F9p2+amixIpVzSTY4/yNVYzp4rlt94DwW8VppdTMaC3cIc sBVzN50bcA5IBhLJrsXVIjOKK/qsAqgIK+mFuvZvh84DobJvaeuq3xJuFL0q4t0y VVV8YsSKP+hfliaI9TIRSsxlO8H/3Gnfyzu2v5aQRKaaJ9/7Im7VH0bDsb/r4LgK 93NvaQlHbesclZNAqVZMKQW0q7+9drKAhiTfGWRSnEOM1pW+UQwmNuadJzaf6y4b h4MfSvYHX7kVsw/e1w0tPfSGYiupxynyDSKC5COQGlTuFkBEatOqMYOUa6+Zls08 +tP/a6LaM/HSNst2cID1OrqX/QDbQoN0QIz49TqcQnxmRGLy5d/nw2yoVyis8Sa9 0bgD+osyfBMo+/lWpkZBWh6grGu8+Dk3s2NP0SPf7ArbFOCwEqTvisPZ0hl0X5nj uO7yLqgqRLH0iOx8ZiV0 =Glgx -----END PGP SIGNATURE----- --A3RWl4qWgABmkY4K--