From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57352) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byscH-0004ad-ST for qemu-devel@nongnu.org; Mon, 24 Oct 2016 23:41:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byscE-0004IU-Pd for qemu-devel@nongnu.org; Mon, 24 Oct 2016 23:41:33 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:60667 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1byscE-0004Hj-C0 for qemu-devel@nongnu.org; Mon, 24 Oct 2016 23:41:30 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9P3cWaI025118 for ; Mon, 24 Oct 2016 23:41:28 -0400 Received: from e23smtp06.au.ibm.com (e23smtp06.au.ibm.com [202.81.31.148]) by mx0b-001b2d01.pphosted.com with ESMTP id 269v7wfbx5-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 24 Oct 2016 23:41:28 -0400 Received: from localhost by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 25 Oct 2016 13:41:26 +1000 Date: Tue, 25 Oct 2016 09:11:16 +0530 From: Bharata B Rao Reply-To: bharata@linux.vnet.ibm.com References: <1477285483-10766-1-git-send-email-david@gibson.dropbear.id.au> <20161025025002.GQ11052@umbus.fritz.box> <20161025032341.GS11052@umbus.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161025032341.GS11052@umbus.fritz.box> Message-Id: <20161025034116.GA3466@in.ibm.com> Subject: Re: [Qemu-devel] [PATCHv3 00/12] pseries: Consolidate guest device tree construction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aik@ozlabs.ru, mdroth@linux.vnet.ibm.com, groug@kaod.org, agraf@suse.de, lvivier@redhat.com, thuth@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org On Tue, Oct 25, 2016 at 02:23:41PM +1100, David Gibson wrote: > On Tue, Oct 25, 2016 at 01:50:02PM +1100, David Gibson wrote: > > On Mon, Oct 24, 2016 at 04:04:31PM +1100, David Gibson wrote: > > > For historical reasons construction of the guest device tree in spapr > > > is divided between spapr_create_fdt_skel() which is called at init > > > time, and spapr_build_fdt() which runs at reset time. Over time, more > > > and more things have needed to be moved to reset time. > > > > > > This series consolidates all the device tree construction to reset > > > time, with some minor cleanups along the way. This will help to make > > > it more maintainable in future. > > > > > > Changes since v2: > > > * Removed a leftover reference to a variable called 'stdout', > > > shadowing the standard library stdout > > > Changes since v1: > > > * Fixed a memory leak introduced by 1/12 (spotted by Thomas Huth) > > > * Removed one patch that's already merged in ppc-for-2.8 > > > > Thanks for the acks, everyone. I've now merged this series into > > ppc-for-2.8, tentatively. > > > > Bharata Rao reported some boot failures caused by the series, but I > > haven't been able to reproduce them so far. Bharata, could you retest > > with the latest version (in ppc-for-2.8) and, if the problems are > > still present, send me some reproducer steps. > > Actually, I just realised the bug Bharata reported looks identical to > one someone else spotted. That was caused by one of Thomas' NVRAM > cleanups, rather than the DT cleanup. It's already been removed from > ppc-for-2.8 pending debug. David - After I reported the boot failure with this patchset to you, I figured out that the root cause was in fact the NVRAM patchset which I later reported separately. Regards, Bharata.