From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758667AbcJYJPs (ORCPT ); Tue, 25 Oct 2016 05:15:48 -0400 Received: from mail-hk2apc01on0102.outbound.protection.outlook.com ([104.47.124.102]:40532 "EHLO APC01-HK2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755903AbcJYJPp (ORCPT ); Tue, 25 Oct 2016 05:15:45 -0400 X-Greylist: delayed 891 seconds by postgrey-1.27 at vger.kernel.org; Tue, 25 Oct 2016 05:15:44 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=anton.tikhomirov@cdnetworks.co.kr; Date: Tue, 25 Oct 2016 18:00:44 +0900 From: Anton Tikhomirov To: mmarek@suse.com Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] kbuild/mkspec: avoid using brace expansion Message-ID: <20161025090041.GA4423@cdnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [114.111.60.64] X-ClientProxiedBy: KL1PR06CA0003.apcprd06.prod.outlook.com (10.165.15.141) To SG2PR06MB0853.apcprd06.prod.outlook.com (10.162.204.13) X-MS-Office365-Filtering-Correlation-Id: b494f621-2e9f-468f-6c94-08d3fcb56af7 X-Microsoft-Exchange-Diagnostics: 1;SG2PR06MB0853;2:2NI858bGgpl7z5bcsDF7s64EhU2h6atqDp8Ro+kOSC9rrRqPIeX2+pKOMmZIqJowwwPJsNRFCQt0ZKjGvYYgCfcR0ZjDZizDMOgZ2zagemOipuoknJet1alUq31/3MEaLRoNua9OjaqkYBT1OwqhF21VEXcedq/9P3HVNOG88mCme3joGfn2J5rvcUKZ5kMePDdhG8I1OcHsvCgEJGUOOw==;3:Kq5K3eSg/64CFTsB2dzIl5L1atnZpvDuDEjVnMgIXNTOMKVy/WG7X9cxjI1shFiyjD9HuE5bsldkBmClFJI/8gLvzWIyAx7Vfx4lh+4sH9dOLcv07PWGRSWBP1j/7eSYMC6ZdllB1/HL9QVOtdOdUA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB0853; X-Microsoft-Exchange-Diagnostics: 1;SG2PR06MB0853;25:apXw+aAspjg37aw6LenV5F5jTYdeCSKtGzr0rUsBwuOWSX1rfijWamLPk6Vzjob6REZztpEvCX2x9HIicO9zGtrRqYqyRDCfur5bZEFx+qwPXDXSldV1opbbKfplPQ/3dgn3usREhlx3NwsflHv09fNCeF0SjniN6rx4YUs3Gy0JikeSG7X+C5TxwntGOD/uCoUEYh2492ir8fi96xQtFghIcYPhevV3E7o1vElWTMHUOSMSrusmBzQdOzp8Qx+D+PEkiLxZfm2gbLiQjpREx8eWRaOZPqe8xpun9A6mpAcYaGMAVV347p4tWvtOGGiAZ+2NmpDkXWTs1eQ1nu2YsudcZfWk2FWH9ST50US2nQGKynVQJQlsrWbYOk2GjY4jNpzH17Wf99SKNWFsFj4/BK0Xaw7r/y+wzoMbgjpTDEET4mqH8/CkBJSt6Ct6xVfx2MLvcybgmmtv85tB62jex4hke4+n/hygF0+6QmWEmBgb2hwvqdZzSD/mj732q733AJVCVYvOfn7VpLxwigyN9Ji2PNJhBKtQzsT0Wv2/eT/s3pYjzlt3SMGNt8wrBuCJ8hk/MYZu0r8GDY2syBNWiDBE1nkTGOtbN7cEa6eAnZ+nCbgT8GI5HdUR5oTOlX3LgSQ83zK68Sh6EIxgDtbRhPWTLfAkuW5KeavWlo4fsyMjcAXhFi9/6r8N2DrnjvfSMN0AZgCMdLOPDICSnrT3j+0Dg4JEYBYO7JLmYuDV6SR9jBaQPCP1MvzGnv+dmebG X-Microsoft-Exchange-Diagnostics: 1;SG2PR06MB0853;31:xRa7ESj110dBF/Gcgn8PC/zzdL30O3qMbLZgtmghzWiLeHwnEYF5xzZqAqzxLRExL56s5EewaprA/HYzhD8jeXUAILfsdHhCgSXlsMsMNPXt4cwy3UAaQOh8IvGL4AT9M5LVzMH0N2q8baQmuYpWA9HvKJtakN/OQ2tldRGsT6Y+1+3jfN8jzqcSdreI7lsXcJ7JdK4/ZqJRs5PjnKGVA9p7PtNe8+j4aglF5JpG+XnWkSFumXOZmAvY6DctPLCa;20:7jZVrg/WpsS974yARdaPOAJWUld8CSBwxpHjdiqS5VXlh8V2gV/pkS4Lt+D21XiYNI3On4S2fiJjO4myiCy7Jb9/tr+t16oOMwloN+WzaGL79l9wxBlNIiZyJY/F8u27mOpxcPvdyzV5lHJY5soKWrmudIxpUq5SWlcpHMySLC0=;4:uyuMXgf2bymUW1rudqpqmgykrpOSqN0q2hXHJyGyH1E+eZgEn3mmX9+neZxHP/WYjHKMXO957jOrOyhl6cHiMuEBJsvpoZme85FwIU6s4CIvMwootlgVoeoAPH7qjPqi7bWEI0V00VvaH7CwqgBi+gHwmeopNTV4kQi71MWQGITl3XCCw3bZI3kwMzKW0HQVBOO8kptTdQ5JfI0z7v1UphJ01rH+l5pXEGYZI2hDLPLhDGCOFb7aPXsFJZU5zD6sbHGKYwmN4CQQympYt/Mz8JLFssgl3DnRgt/IL5COz8YHM06MbBbXG2xHlp5Q6saswGd18kJIWBZbyqwjmzOWMgbXUr5P9g4umwJNcv191fdpUlR4gY0S4PBBx4+U2RD/lIjx4ZASLY9cgqBhfYrTqRg71UbEzhkheSR0GLj6fkTuPt9ZcI4R4dEN8U3fREjW X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6043046)(6042046);SRVR:SG2PR06MB0853;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB0853; X-Forefront-PRVS: 01068D0A20 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(189002)(199003)(101416001)(2906002)(77096005)(92566002)(66066001)(47776003)(5660300001)(7736002)(68736007)(21086003)(305945005)(7846002)(110136003)(81156014)(81166006)(97736004)(42882006)(6916009)(189998001)(2351001)(229853001)(2361001)(33656002)(36756003)(42186005)(106356001)(4001350100001)(50466002)(105586002)(8676002)(19580405001)(6116002)(19580395003)(6666003)(54356999)(50986999)(586003)(23676002)(69596002)(3846002)(1076002)(83506001)(18370500001);DIR:OUT;SFP:1102;SCL:1;SRVR:SG2PR06MB0853;H:cdnetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTRzJQUjA2TUIwODUzOzIzOnZjMzlEUjluTDdOcU9tSFVRZHhZaVA3bUdJ?= =?utf-8?B?REF3OXRYQXhtNWVyOXJxcWFpaG9JNmJqdEdnSG5FWGNRVEJBWHhJMmtEeW9L?= =?utf-8?B?a2p2MnhnLzhwNk9tZWo2UVg0cHdrOWFXWGJIYXdIY0psZWQwM0NvWmNnYTZT?= =?utf-8?B?aXpyMllNaVhKbDhxd3dNeWFrZkdSbUxUdVpyaENFRGtzbFh6WlJWMDU2S013?= =?utf-8?B?RzYzWXRjUTJRT0Y5NklQVExuays5bEFMb2VMeDVIZzZ1WFFpODRWbHc0QTk3?= =?utf-8?B?UWV4NWgyUUNFZXR2MmdEdTI2cDYrL09XRGNNdlJpd3VYQngyRFNzcHV2anNM?= =?utf-8?B?WnFxUERFbHZYTU93eVc4cW1FUUE1c1BqS2NUZlBLazREWnhPdVNoTFlnTE1y?= =?utf-8?B?czIzVDBaMmpieVRlVDFvRHF2UGF6WWlUK2F6cGxlaHBNS0tCTEh3T0s3Tmho?= =?utf-8?B?SWI0N3YrdlhzQm9JQ2dXRTRyYTNjYkR0L3pvWFlNZlByNUF2TFIzUG9MWjNi?= =?utf-8?B?UDMxaTRUeTRpYUdwQUc1cVhJUzNzZ012bEFqVVFuYjZMOCtBRjllSmdHS0Nt?= =?utf-8?B?MGswaTFrU1FKalQwb3p6Wm01ZTUxOFZaOU9nSXlJbFVUY1RTMG9va2ZmaTFj?= =?utf-8?B?RVo4OUtYM1RCN3lmYWJnd3RkSWtFbXk3MmhjRXhBQWVIaElIZ3NScjlBMnRF?= =?utf-8?B?bHlQSTlSVStldG5aRktGSXh6dU1RM1JRZ2dCdGdlbEF3Wkx2TTZ4eitQODNz?= =?utf-8?B?MFlEbkl3RUpnR2FPcy9yL1VySGVjcW0rOE1aK3JCWDJoSUVyTythdlRySWx2?= =?utf-8?B?bzM0alFHMmc2eDBsUmh4eVhUd2swcHd0Qjh5ZmJIMkNPbkUyZUQ3OERCVS9q?= =?utf-8?B?bU0yNzdFWnkxVytOU0o0TzIrUjhlc2F3azRVbFB4TnU1c0ErMTdWaG5qNkxl?= =?utf-8?B?cW44cG9WUmR0SHh6ZUZwVDduOVJ3R1NMcmtPYWR2QVJGaW5qSWFUcVpsVkox?= =?utf-8?B?TXBFam02YW10ek9tUS9FN1F0WThsajBNL3NWRXNCZWM2UmJpdzRJdGRXTEU5?= =?utf-8?B?MU9zVjhWM21zOXJRSEMxL3BqWUo0cjZGZHg0TFZQamhhMXNVK3FmR2dRTnh5?= =?utf-8?B?NDhDQTROYmZ2YmxEbzY4WmNtOXAxbTQvV0UxQ1E4dkpFb2dXeUNab3JJcFht?= =?utf-8?B?MmZGQTh5UnZ2YnErNlJPdXdMWjM3MXdlSTNtM1ltKzNaQmpMdzN6K2VtMXFU?= =?utf-8?B?elFUTE92d2hqbGk4S3ZTTnY2R2h1M3BPYk9GWndOVjNlZVdQRlBzYXpqRnV2?= =?utf-8?B?K1RSeWc0a0k5dUM3cWVPYlJtZTJnd1dteEo0NGw3cFVwQW9kcWxkZ2J2endW?= =?utf-8?B?ZXF4V1h0Mnc5cG91cnU0SVNoM09tTS9UTkpJNEp3UmErVDdrSGtZWFUramk0?= =?utf-8?B?dVpTUjlSYVZ2RWhwOG16UGxaNThWWDd0ajh0cGtZUGxKNzQwb2l6YVI4aThY?= =?utf-8?B?R25sT0FUK29wVlRwelZnbnpTTXhFS0pnWk9nZDVUNmFRVVM2WVJsbm5VaFlF?= =?utf-8?B?aUJibnZFdFZ5dk4yZ2F0dFk3VjBsVEhiZDd0bEloQ0F6dUhUU1AwMlYybkFW?= =?utf-8?Q?VHe00kVaf6RRNtGsp0oW?= X-Microsoft-Exchange-Diagnostics: 1;SG2PR06MB0853;6:0MzdPsJe6eNFfQ75syMrZxGmUbUiwop4RpFc+6xjrkYEoLAi9eBd/jpZATSMzM7ycPMgAR8NhSWymA8muegO1tjN17soabsaque80emeqb8lmVaaTF1PPWac024Q7oaFeULzjv7LOpQHi8+U+OYW86iTRkontcWN4IBa5NDVLYVW640MFHA38ZGeMEf82ycbyHWkDuj2Zsg068Flv0mgLoI+XodD6lhoLMrBEgN2pJswegtjnEhSV4ZppS9mXlUkXRrsyWP1vU/SHO0IR/N4EWvLYRYibZvtmcZnhGgOVwGdChdOJ2HKpBPxMwa2NaTck2JZtWYK2k66tgzl8SO41A==;5:hPvycOQER0uzxsOPNiG7lGb5A/LoGT5GgumiXeL8OsWytNJY3DE9zrscuq+XI0hioRq5jcK62ijUgr9tGSha0vI1mBX4aUsd7OHxNlbOimfiH+DPgYNJM5W0I/nJJOwrBBrRt+9t2e87JgvpOxHy1yvIDpFbsg1TaT8FJ1S4de4=;24:zv9MpetWydmFVZOT2tnG4JewHiEOSOZQ9W8WF2i6Lis0PIgAFORJeY/uJ/znEKRuJSYCWMd86aYs/pQOx1j09XrfIBR8Mj/BzPKeZ0qUTLE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SG2PR06MB0853;7:dokLfIo6X17dK0VClQXkvVSc/SjROqRVXyrU3LnM2YmroynuGqiq9ldK0ACAsVyTlM1Vikb9v4Ny/9ufiDVwtp8PnmTZp1uLfwwJQOsx3X0bI81XueR2IALULra3b9DUvIC7SiNhQtGLfyn1ABkd67hDKglDtSjbn1Py89eCQIsxfZu5sA9p7xdT5cbm/1VtTiFK5TCkecJSgPvBdkU/U9pHrsW80poZ5TA+FHs1reFSbtHiFgt3JIxAqJ/G4A115UQG9bO/AJa0Cxiy1l2dhoLNXmsroA/vcM6drtrCLsnGPKLFFYtMb8id1gmh/Bs+jJndew1znWQa6up3cu5xWVyG+7CXHUj8NE0cMcqUflg= X-OriginatorOrg: cdnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2016 09:00:49.8467 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB0853 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Brace expansion might not work properly if _buildshell RPM macro points to a shell other than bash. Particularly, with _bulidshell defined to /bin/dash it leads to broken build and source symlinks. Signed-off-by: Anton Tikhomirov --- scripts/package/mkspec | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/package/mkspec b/scripts/package/mkspec index 57673ba..bb43f15 100755 --- a/scripts/package/mkspec +++ b/scripts/package/mkspec @@ -116,7 +116,8 @@ echo 'mv vmlinux.bz2 $RPM_BUILD_ROOT'"/boot/vmlinux-$KERNELRELEASE.bz2" echo "%endif" if ! $PREBUILT; then -echo 'rm -f $RPM_BUILD_ROOT'"/lib/modules/$KERNELRELEASE/{build,source}" +echo 'rm -f $RPM_BUILD_ROOT'"/lib/modules/$KERNELRELEASE/build" +echo 'rm -f $RPM_BUILD_ROOT'"/lib/modules/$KERNELRELEASE/source" echo "mkdir -p "'$RPM_BUILD_ROOT'"/usr/src/kernels/$KERNELRELEASE" echo "EXCLUDES=\"$RCS_TAR_IGNORE --exclude .tmp_versions --exclude=*vmlinux* --exclude=*.o --exclude=*.ko --exclude=*.cmd --exclude=Documentation --exclude=firmware --exclude .config.old --exclude .missing-syscalls.d\"" echo "tar "'$EXCLUDES'" -cf- . | (cd "'$RPM_BUILD_ROOT'"/usr/src/kernels/$KERNELRELEASE;tar xvf -)" -- 2.7.4