All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: X86 ML <x86@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 00/12] x86/microcode: Rework microcode loading
Date: Tue, 25 Oct 2016 11:55:10 +0200	[thread overview]
Message-ID: <20161025095522.11964-1-bp@alien8.de> (raw)

From: Borislav Petkov <bp@suse.de>

So this is something I've been meaning to do for a while now: cleanup
the Intel side of the microcode loader. But who has time?

Luckily (or not), CONFIG_RANDOMIZE_MEMORY came about and broke the
loader just enough so that I can finally force myself to go and clean it
all up, make it more robust.

So this is my attempt at it, the meat of the whole change is patch 11.
Which is unreadable as a diff to almost everyone, except to me, maybe :)
But it is the only way I could think of to do this without breaking the
driver knowingly. Oh, and staring at the code after the patch applied
makes it much clearer and nicer again anyway.

This pile has been tested on both AMD and Intel boxes of different
garden variety, with suspend to disk and to RAM and 32-bit and 64-bit.

Comments, suggestions and eventual pickup are appreciated :)

Thanks.

Borislav Petkov (12):
  x86/microcode: Run the AP-loading routine only on the application
    processors
  x86/microcode: Move driver authors to CREDITS
  x86/microcode/intel: Simplify generic_load_microcode()
  x86/microcode: Remove one ifdef clause
  x86/microcode: Export the microcode cache linked list
  x86/microcode/AMD: Hand down the CPU family
  x86/microcode: Issue the debug printk on resume only on success
  x86/microcode: Collect CPU info on resume
  x86/microcode/AMD: Retract functions
  x86/microcode/intel: Remove intel_lib.c
  x86/microcode: Rework microcode loading
  x86/microcode: Bump driver version, update copyrights

 CREDITS                                   |   4 +
 arch/x86/include/asm/microcode.h          |  18 +-
 arch/x86/include/asm/microcode_amd.h      |  30 +-
 arch/x86/include/asm/microcode_intel.h    |   4 -
 arch/x86/kernel/cpu/common.c              |   7 +-
 arch/x86/kernel/cpu/microcode/Makefile    |   2 +-
 arch/x86/kernel/cpu/microcode/amd.c       | 421 ++++++++-------
 arch/x86/kernel/cpu/microcode/core.c      |  83 ++-
 arch/x86/kernel/cpu/microcode/intel.c     | 834 +++++++++++++-----------------
 arch/x86/kernel/cpu/microcode/intel_lib.c | 184 -------
 10 files changed, 647 insertions(+), 940 deletions(-)
 delete mode 100644 arch/x86/kernel/cpu/microcode/intel_lib.c

-- 
2.10.0

             reply	other threads:[~2016-10-25  9:58 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25  9:55 Borislav Petkov [this message]
2016-10-25  9:55 ` [PATCH 01/12] x86/microcode: Run the AP-loading routine only on the application processors Borislav Petkov
2016-10-25 16:27   ` [tip:x86/microcode] " tip-bot for Borislav Petkov
2016-10-25  9:55 ` [PATCH 02/12] x86/microcode: Move driver authors to CREDITS Borislav Petkov
2016-10-25 16:28   ` [tip:x86/microcode] " tip-bot for Borislav Petkov
2016-10-25  9:55 ` [PATCH 03/12] x86/microcode/intel: Simplify generic_load_microcode() Borislav Petkov
2016-10-25 16:28   ` [tip:x86/microcode] " tip-bot for Borislav Petkov
2016-10-25  9:55 ` [PATCH 04/12] x86/microcode: Remove one ifdef clause Borislav Petkov
2016-10-25 16:29   ` [tip:x86/microcode] x86/microcode: Remove one #ifdef clause tip-bot for Borislav Petkov
2016-10-25  9:55 ` [PATCH 05/12] x86/microcode: Export the microcode cache linked list Borislav Petkov
2016-10-25 16:29   ` [tip:x86/microcode] " tip-bot for Borislav Petkov
2016-10-25  9:55 ` [PATCH 06/12] x86/microcode/AMD: Hand down the CPU family Borislav Petkov
2016-10-25 16:30   ` [tip:x86/microcode] x86/microcode/amd: " tip-bot for Borislav Petkov
2016-10-25  9:55 ` [PATCH 07/12] x86/microcode: Issue the debug printk on resume only on success Borislav Petkov
2016-10-25 16:30   ` [tip:x86/microcode] " tip-bot for Borislav Petkov
2016-10-25  9:55 ` [PATCH 08/12] x86/microcode: Collect CPU info on resume Borislav Petkov
2016-10-25 16:31   ` [tip:x86/microcode] " tip-bot for Borislav Petkov
2016-10-25  9:55 ` [PATCH 09/12] x86/microcode/AMD: Retract functions Borislav Petkov
2016-10-25 16:31   ` [tip:x86/microcode] x86/microcode/amd: Move private inlines to .c and mark local functions static tip-bot for Borislav Petkov
2016-10-25  9:55 ` [PATCH 10/12] x86/microcode/intel: Remove intel_lib.c Borislav Petkov
2016-10-25 16:32   ` [tip:x86/microcode] " tip-bot for Borislav Petkov
2016-10-25  9:55 ` [PATCH 11/12] x86/microcode: Rework microcode loading Borislav Petkov
2016-10-25 16:32   ` [tip:x86/microcode] " tip-bot for Borislav Petkov
2016-10-25  9:55 ` [PATCH 12/12] x86/microcode: Bump driver version, update copyrights Borislav Petkov
2016-10-25 16:33   ` [tip:x86/microcode] " tip-bot for Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161025095522.11964-1-bp@alien8.de \
    --to=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH 00/12] x86/microcode: Rework microcode loading' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.