[PATCH] build: Fix build script to use correct cmake cmd

[PATCH] build: Fix build script to use correct cmake cmd

[Dennis Dalessandro]

The build script does not use the variable it sets up for cmake. Fix it
so it does.

Signed-off-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 build.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/build.sh b/build.sh
index 9006030..10518d8 100755
--- a/build.sh
+++ b/build.sh
@@ -23,9 +23,9 @@ fi
 cd "$BUILDDIR"
 
 if [ "x$NINJA" == "x" ]; then
-    cmake ..
+    $CMAKE ..
     make
 else
-    cmake -GNinja ..
+    $CMAKE -GNinja ..
     $NINJA
 fi

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] build: Fix build script to use correct cmake cmd

[Jason Gunthorpe]

On Fri, Oct 21, 2016 at 10:27:28AM -0700, Dennis Dalessandro wrote:
> The build script does not use the variable it sets up for cmake. Fix it
> so it does.

Yep, my bad. I put this with the other minor fixes that came by
lately:

https://github.com/linux-rdma/rdma-core/pull/25

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] build: Fix build script to use correct cmake cmd

[Doug Ledford]

[-- Attachment #1.1: Type: text/plain, Size: 964 bytes --]

On 10/21/2016 2:05 PM, Jason Gunthorpe wrote:
> On Fri, Oct 21, 2016 at 10:27:28AM -0700, Dennis Dalessandro wrote:
>> The build script does not use the variable it sets up for cmake. Fix it
>> so it does.
> 
> Yep, my bad. I put this with the other minor fixes that came by
> lately:
> 
> https://github.com/linux-rdma/rdma-core/pull/25
> 
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

According to github, this change broke the travis CI build on your pull
request when the previous patches all worked.  However, travis is down
right now, so I suspect this didn't *actually* break it, that the travis
CI was down anyway and github logged a failure.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG Key ID: 0E572FDD


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

Re: [PATCH] build: Fix build script to use correct cmake cmd

[Jason Gunthorpe]

On Fri, Oct 21, 2016 at 03:03:23PM -0400, Doug Ledford wrote:
> According to github, this change broke the travis CI build on your pull
> request when the previous patches all worked.  However, travis is down
> right now, so I suspect this didn't *actually* break it, that the travis
> CI was down anyway and github logged a failure.

Yes, travis does not use build.sh

Maybe this is a good time to ask if anyone is interested in the docker
stuff I have - eg should I make it pushable? It is easy to use, but
you need to have docker installed.

There are several other container/chroot/docker based toolkits out
there for doing this sort of work, but I haven't studied that area in
a while to see if there is something workable.

The docker script is able to run almost-travis locally, as well as do
clean package builds for all distros.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] build: Fix build script to use correct cmake cmd

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]

On Fri, Oct 21, 2016 at 01:30:34PM -0600, Jason Gunthorpe wrote:
> On Fri, Oct 21, 2016 at 03:03:23PM -0400, Doug Ledford wrote:
> > According to github, this change broke the travis CI build on your pull
> > request when the previous patches all worked.  However, travis is down
> > right now, so I suspect this didn't *actually* break it, that the travis
> > CI was down anyway and github logged a failure.
>
> Yes, travis does not use build.sh
>
> Maybe this is a good time to ask if anyone is interested in the docker
> stuff I have - eg should I make it pushable? It is easy to use, but
> you need to have docker installed.

I would be happy to get it and be more confident in my local tests.

>
> There are several other container/chroot/docker based toolkits out
> there for doing this sort of work, but I haven't studied that area in
> a while to see if there is something workable.
>
> The docker script is able to run almost-travis locally, as well as do
> clean package builds for all distros.

It looks like it goes beyond rdma-core definition. Do we want to put it
separately or anyway integrate into main library?

>
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] build: Fix build script to use correct cmake cmd

[Jason Gunthorpe]

On Tue, Oct 25, 2016 at 01:12:00PM +0300, Leon Romanovsky wrote:

> > Maybe this is a good time to ask if anyone is interested in the docker
> > stuff I have - eg should I make it pushable? It is easy to use, but
> > you need to have docker installed.
> 
> I would be happy to get it and be more confident in my local tests.

Okay, let me look at it some more, I think it could be streamlined a
bit.

> > The docker script is able to run almost-travis locally, as well as do
> > clean package builds for all distros.
> 
> It looks like it goes beyond rdma-core definition. Do we want to put it
> separately or anyway integrate into main library?

It is a 500 line script, I'd keep it internal. The latest version has
learned to use different spec files depend on the distro build too, so
there is a bunch of subtle integration.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] build: Fix build script to use correct cmake cmd

[Jason Gunthorpe]

On Tue, Oct 25, 2016 at 01:12:00PM +0300, Leon Romanovsky wrote:
> > stuff I have - eg should I make it pushable? It is easy to use, but
> > you need to have docker installed.
> 
> I would be happy to get it and be more confident in my local tests.

You can test it out with this commit:

https://github.com/jgunthorpe/rdma-plumbing/commit/ef24b991c949ad4f50614bf6bf549e1cdf841358

It will need some tidying before it can merged, but let me know if it
is useful as-is.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] build: Fix build script to use correct cmake cmd

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]

On Mon, Nov 07, 2016 at 04:57:09PM -0700, Jason Gunthorpe wrote:
> On Tue, Oct 25, 2016 at 01:12:00PM +0300, Leon Romanovsky wrote:
> > > stuff I have - eg should I make it pushable? It is easy to use, but
> > > you need to have docker installed.
> >
> > I would be happy to get it and be more confident in my local tests.
>
> You can test it out with this commit:
>
> https://github.com/jgunthorpe/rdma-plumbing/commit/ef24b991c949ad4f50614bf6bf549e1cdf841358
>
> It will need some tidying before it can merged, but let me know if it
> is useful as-is.

Thanks, I'll do my best to try it next week.

>
> Jason

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]