From: Bruce Richardson <bruce.richardson@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "Guo, Jia" <jia.guo@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v4] net/i40e: fix hash filter invalid issue in X722
Date: Tue, 25 Oct 2016 13:29:03 +0100 [thread overview]
Message-ID: <20161025122902.GC54704@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F80E294671@SHSMSX103.ccr.corp.intel.com>
On Tue, Oct 25, 2016 at 10:22:09AM +0000, Wu, Jingjing wrote:
>
>
> > -----Original Message-----
> > From: Guo, Jia
> > Sent: Tuesday, October 25, 2016 10:43 AM
> > To: Zhang, Helin <helin.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> > Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>
> > Subject: [PATCH v4] net/i40e: fix hash filter invalid issue in X722
> >
> > When verifying the Hash filtering on X722, we found a problem that
> > the hash value in descriptor is incorrect. The root caused is X722
> > uses different way of hash key word selection comparing with X710/XL710.
> > This patch fixes it by setting X722 specific key selection.
> >
> > Signed-off-by: Jeff Guo <jia.guo@intel.com>
>
> If we use default configuration on HW, this issue will not exist. But
> our software sets the default value through i40e_filter_input_set_init.
> So I think fix line need to be the commit which introduced input set
> changing feature.
>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com> with additional line:
>
> Fixes: commit 98f055707685 ("i40e: configure input fields for RSS or flow director ")
>
Applied, with fixes line, to dpdk-next-net/rel_16_11
/Bruce
next prev parent reply other threads:[~2016-10-25 12:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 10:51 [PATCH] drivers/i40e: fix the hash filter invalid calculation in X722 Jeff Guo
2016-09-29 6:29 ` Wu, Jingjing
2016-09-29 18:15 ` Ferruh Yigit
2016-09-30 6:05 ` Wu, Jingjing
2016-09-30 9:09 ` Ferruh Yigit
2016-10-16 1:40 ` [PATCH v2 1/2] drivers/i40e: fix X722 macro absence result in compile Jeff Guo
2016-10-16 1:40 ` [PATCH v2 2/2] drivers/i40e: fix the hash filter invalid calculation in X722 Jeff Guo
2016-10-18 16:25 ` Ferruh Yigit
2016-10-20 2:48 ` [PATCH] net/i40e: " Jeff Guo
2016-10-24 9:10 ` Wu, Jingjing
2016-10-25 2:11 ` Guo, Jia
2016-10-25 2:26 ` [PATCH v4] " Jeff Guo
2016-10-25 2:42 ` [PATCH v4] net/i40e: fix hash filter invalid issue " Jeff Guo
2016-10-25 10:22 ` Wu, Jingjing
2016-10-25 12:29 ` Bruce Richardson [this message]
2016-10-16 13:31 ` [PATCH v2 1/2] drivers/i40e: fix X722 macro absence result in compile Ananyev, Konstantin
2016-10-17 7:44 ` Guo, Jia
2016-10-17 9:54 ` Ananyev, Konstantin
2016-10-17 10:14 ` Chilikin, Andrey
2016-10-18 16:22 ` Ferruh Yigit
2016-10-19 6:10 ` Guo, Jia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025122902.GC54704@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jia.guo@intel.com \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.