From: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
To: Lukas Wunner <lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ard Biesheuvel
<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Andreas Noever
<andreas.noever-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v2 1/3] efi: Add device path parser
Date: Tue, 25 Oct 2016 13:44:06 +0100 [thread overview]
Message-ID: <20161025124406.GD20387@codeblueprint.co.uk> (raw)
In-Reply-To: <20161019115119.GA2973-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
On Wed, 19 Oct, at 01:51:19PM, Lukas Wunner wrote:
> > Where in your patch series is this function called? Am I missing
> > something?
>
> This is called by unmarshal_devices() in patch [2/3] of this series.
Where is PATCH 2? I can't find it in my inbox or on linux-efi.
> > Also, unless there's some existing namespace with "get_device_by_*"
> > I'd prefer for this function name to have "efi_" as the prefix.
>
> There's get_device() defined in include/linux/device.h which returns a
> reference to a device, this function here is basically named after it
> because it likewise returns a reference.
>
> How about efi_get_device_by_path()?
That'd be great, thanks!
next prev parent reply other threads:[~2016-10-25 12:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 10:57 [PATCH v2 0/3] Apple device properties Lukas Wunner
[not found] ` <cover.1476698603.git.lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2016-10-17 10:57 ` [PATCH v2 3/3] thunderbolt: Use Device ROM retrieved from EFI Lukas Wunner
2016-10-17 10:57 ` [PATCH v2 2/3] x86/efi: Retrieve and assign Apple device properties Lukas Wunner
2016-10-17 10:57 ` [PATCH v2 1/3] efi: Add device path parser Lukas Wunner
[not found] ` <ece9b12b1d0b86c83e8369e4123fc7bc60db1fdc.1476698603.git.lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2016-10-19 11:17 ` Matt Fleming
[not found] ` <20161019111728.GC31476-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-10-19 11:51 ` Lukas Wunner
[not found] ` <20161019115119.GA2973-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2016-10-25 12:44 ` Matt Fleming [this message]
[not found] ` <20161025124406.GD20387-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-10-25 13:51 ` Lukas Wunner
2016-10-21 16:34 ` Peter Jones
[not found] ` <20161021163435.y2zlysz7dhw5ymho-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-10-22 10:16 ` Lukas Wunner
[not found] ` <20161022101608.GA4447-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2016-10-25 14:18 ` Peter Jones
[not found] ` <20161025141819.2z244yr2ubscrm2r-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-10-27 12:31 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025124406.GD20387@codeblueprint.co.uk \
--to=matt-mf/unelci9gs6ibeejttw/xrex20p6io@public.gmane.org \
--cc=andreas.noever-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org \
--cc=pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.