From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Tue, 25 Oct 2016 13:44:11 +0200 Subject: [Buildroot] [PATCH 02/30] toolchain-external: pass CC and CFLAGS as arguments In-Reply-To: References: <1477255711-28603-1-git-send-email-romain.naour@gmail.com> <1477255711-28603-3-git-send-email-romain.naour@gmail.com> Message-ID: <20161025134411.12a91a7d@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Tue, 25 Oct 2016 13:07:01 +0200, Arnout Vandecappelle wrote: > This is exactly the same commit message as the previous commit. However, what > this patch actually does is > > 1. Pass up CC and CFLAGS one level more > -> I think this should be squashed with the previous commit. > > 2. pass LIBS as arguments > -> This should be a separate commit, with the appropriate commit message. I believe Romain's idea is to split this per *function* (or family of functions) being changed, not per arguments being passed. So indeed, the wording of his commit titles and logs is not very good. It should have been: toolchain-external: TOOLCHAIN_EXTERNAL_CREATE_*_LIB_SYMLINK: use arguments instead of global variables toolchain-external: TOOLCHAIN_EXTERNAL_INSTALL_*_LIBS: use arguments instead of global variables toolchain-external: TOOLCHAIN_EXTERNAL_INSTALL_WRAPPER: use arguments instead of global variables toolchain-external: TOOLCHAIN_EXTERNAL_INSTALL_TARGET_GDBSERVER: use arguments instead of global variables I find this split a lot more logical than a split by argument being added, as the latter would mean a given function gets modified in two different patches. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com