From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9E9AE1A1E57 for ; Tue, 25 Oct 2016 09:24:17 -0700 (PDT) Date: Tue, 25 Oct 2016 10:24:16 -0600 From: Ross Zwisler Subject: Re: [PATCH] nvdimm: make CONFIG_NVDIMM_DAX 'bool' Message-ID: <20161025162416.GA16761@linux.intel.com> References: <20161025155246.4174413-1-arnd@arndb.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20161025155246.4174413-1-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Arnd Bergmann Cc: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, "Paul E. McKenney" List-ID: On Tue, Oct 25, 2016 at 05:52:04PM +0200, Arnd Bergmann wrote: > tatus: O > Content-Length: 2346 > Lines: 60 > > A bugfix just tried to address a randconfig build problem and introduced > a variant of the same problem: with CONFIG_LIBNVDIMM=y and > CONFIG_NVDIMM_DAX=m, the nvdimm module now fails to link: > > drivers/nvdimm/built-in.o: In function `to_nd_device_type': > bus.c:(.text+0x1b5d): undefined reference to `is_nd_dax' > drivers/nvdimm/built-in.o: In function `nd_region_notify_driver_action.constprop.2': > region_devs.c:(.text+0x6b6c): undefined reference to `is_nd_dax' > region_devs.c:(.text+0x6b8c): undefined reference to `to_nd_dax' > drivers/nvdimm/built-in.o: In function `nd_region_probe': > region.c:(.text+0x70f3): undefined reference to `nd_dax_create' > drivers/nvdimm/built-in.o: In function `mode_show': > namespace_devs.c:(.text+0xa196): undefined reference to `is_nd_dax' > drivers/nvdimm/built-in.o: In function `nvdimm_namespace_common_probe': > (.text+0xa55f): undefined reference to `is_nd_dax' > drivers/nvdimm/built-in.o: In function `nvdimm_namespace_common_probe': > (.text+0xa56e): undefined reference to `to_nd_dax' > > This reverts the earlier fix, making NVDIMM_DAX a 'bool' option again > as it should be (it gets linked into the libnvdimm module). To fix > the original problem, I'm adding a dependency on LIBNVDIMM to > DEV_DAX_PMEM, which ensures we can't have that one built-in if the > rest is a module. > > Fixes: 4e65e9381c7a ("/dev/dax: fix Kconfig dependency build breakage") > Signed-off-by: Arnd Bergmann Reviewed-by: Ross Zwisler _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941613AbcJYQYT (ORCPT ); Tue, 25 Oct 2016 12:24:19 -0400 Received: from mga04.intel.com ([192.55.52.120]:64985 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932543AbcJYQYS (ORCPT ); Tue, 25 Oct 2016 12:24:18 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,546,1473145200"; d="scan'208";a="23860253" Date: Tue, 25 Oct 2016 10:24:16 -0600 From: Ross Zwisler To: Arnd Bergmann Cc: Dan Williams , Johannes Thumshirn , "Paul E. McKenney" , Ross Zwisler , linux-kernel@vger.kernel.org, linux-nvdimm@ml01.01.org Subject: Re: [PATCH] nvdimm: make CONFIG_NVDIMM_DAX 'bool' Message-ID: <20161025162416.GA16761@linux.intel.com> References: <20161025155246.4174413-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161025155246.4174413-1-arnd@arndb.de> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 25, 2016 at 05:52:04PM +0200, Arnd Bergmann wrote: > tatus: O > Content-Length: 2346 > Lines: 60 > > A bugfix just tried to address a randconfig build problem and introduced > a variant of the same problem: with CONFIG_LIBNVDIMM=y and > CONFIG_NVDIMM_DAX=m, the nvdimm module now fails to link: > > drivers/nvdimm/built-in.o: In function `to_nd_device_type': > bus.c:(.text+0x1b5d): undefined reference to `is_nd_dax' > drivers/nvdimm/built-in.o: In function `nd_region_notify_driver_action.constprop.2': > region_devs.c:(.text+0x6b6c): undefined reference to `is_nd_dax' > region_devs.c:(.text+0x6b8c): undefined reference to `to_nd_dax' > drivers/nvdimm/built-in.o: In function `nd_region_probe': > region.c:(.text+0x70f3): undefined reference to `nd_dax_create' > drivers/nvdimm/built-in.o: In function `mode_show': > namespace_devs.c:(.text+0xa196): undefined reference to `is_nd_dax' > drivers/nvdimm/built-in.o: In function `nvdimm_namespace_common_probe': > (.text+0xa55f): undefined reference to `is_nd_dax' > drivers/nvdimm/built-in.o: In function `nvdimm_namespace_common_probe': > (.text+0xa56e): undefined reference to `to_nd_dax' > > This reverts the earlier fix, making NVDIMM_DAX a 'bool' option again > as it should be (it gets linked into the libnvdimm module). To fix > the original problem, I'm adding a dependency on LIBNVDIMM to > DEV_DAX_PMEM, which ensures we can't have that one built-in if the > rest is a module. > > Fixes: 4e65e9381c7a ("/dev/dax: fix Kconfig dependency build breakage") > Signed-off-by: Arnd Bergmann Reviewed-by: Ross Zwisler