All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Jerry Lee <jerrylee@qnap.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: resizing file system fails when file system block size is smaller than page size
Date: Tue, 25 Oct 2016 13:19:36 -0400	[thread overview]
Message-ID: <20161025171936.uk2l7arhwmbrlib5@thunk.org> (raw)
In-Reply-To: <CAA1ppbijDUUH2AN40qkoC-w88sz6BBSz89rtvXPiT089pHYgqQ@mail.gmail.com>

On Fri, Sep 09, 2016 at 07:36:06PM +0800, Jerry Lee wrote:
> 
> I have a file system with 4K block size on a 32K page size platform, and
> something strange happened when expanding the file system from size 17TB to
> 20TB.  It seems that the new file system size is not calculated correctly.
> 
> $ resize2fs /dev/mapper/dev
> resize2fs 1.43.3 (04-Sep-2016)
> Filesystem at /dev/mapper/dev is mounted on /share/DATA; on-line
> resizing required
> resize2fs: On-line shrinking not supported
> 
> After digging into the issue, I find that the following operation makes the
> high 32bit of the new_size variable be wiped out and results in a smaller
> size compared to the currently used block counts.

Thanks for the report; I've applied your suggested fix.

       	       	       	    	    - Ted

      reply	other threads:[~2016-10-25 17:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-09 11:36 resizing file system fails when file system block size is smaller than page size Jerry Lee
2016-10-25 17:19 ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161025171936.uk2l7arhwmbrlib5@thunk.org \
    --to=tytso@mit.edu \
    --cc=jerrylee@qnap.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.