From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941606AbcJYJvf (ORCPT ); Tue, 25 Oct 2016 05:51:35 -0400 Received: from mail.kernel.org ([198.145.29.136]:60430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932843AbcJYJvd (ORCPT ); Tue, 25 Oct 2016 05:51:33 -0400 Date: Tue, 25 Oct 2016 18:51:26 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: Shuah Khan , linux-kernel@vger.kernel.org, Ingo Molnar , Namhyung Kim , Tom Zanussi , linux-kselftest@vger.kernel.org Subject: Re: [PATCH 2/5] selftests: ftrace: Fix test cases to enable tracing Message-Id: <20161025185126.c0cf722d1d1d140bfb2f7ee0@kernel.org> In-Reply-To: <20161024155027.5dd9674a@gandalf.local.home> References: <147685280526.8760.8021110184607782896.stgit@devbox> <147685282642.8760.554191165644931816.stgit@devbox> <20161024155027.5dd9674a@gandalf.local.home> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steve, On Mon, 24 Oct 2016 15:50:27 -0400 Steven Rostedt wrote: > On Wed, 19 Oct 2016 13:53:46 +0900 > Masami Hiramatsu wrote: > > > Fix some test cases to enable tracing before starting > > trace test. This can avoid false-positive failure when > > previous testcase fails while disabling tracing. > > I wonder if this would be better to do the enabling from the ftracetest > script instead. Then the tests would need to worry about it. Hm, sounds reasonable. Also some other options should be reset for avoiding unexpected failure. I'll try that. Thanks! > > -- Steve > > > > > > Signed-off-by: Masami Hiramatsu > > --- > > .../selftests/ftrace/test.d/event/event-enable.tc | 1 + > > .../selftests/ftrace/test.d/event/event-pid.tc | 1 + > > .../ftrace/test.d/event/subsystem-enable.tc | 1 + > > .../ftrace/test.d/event/toplevel-enable.tc | 1 + > > .../ftrace/test.d/ftrace/func_profiler.tc | 1 + > > .../ftrace/test.d/kprobe/kprobe_ftrace.tc | 1 + > > 6 files changed, 6 insertions(+) > > > > diff --git a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc > > index 87eb9d6..ee7ea0a 100644 > > --- a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc > > +++ b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc > > @@ -23,6 +23,7 @@ fi > > > > reset_tracer > > do_reset > > +enable_tracing > > > > echo 'sched:sched_switch' > set_event > > > > diff --git a/tools/testing/selftests/ftrace/test.d/event/event-pid.tc b/tools/testing/selftests/ftrace/test.d/event/event-pid.tc > > index d4ab27b..1477e5e 100644 > > --- a/tools/testing/selftests/ftrace/test.d/event/event-pid.tc > > +++ b/tools/testing/selftests/ftrace/test.d/event/event-pid.tc > > @@ -30,6 +30,7 @@ fi > > > > reset_tracer > > do_reset > > +enable_tracing > > > > echo 1 > events/sched/sched_switch/enable > > > > diff --git a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc > > index ced27ef..f4a64f9 100644 > > --- a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc > > +++ b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc > > @@ -23,6 +23,7 @@ fi > > > > reset_tracer > > do_reset > > +enable_tracing > > > > echo 'sched:*' > set_event > > > > diff --git a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc > > index 0bb5df3..037a82e 100644 > > --- a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc > > +++ b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc > > @@ -23,6 +23,7 @@ fi > > > > reset_tracer > > do_reset > > +enable_tracing > > > > echo '*:*' > set_event > > > > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc > > index 7808336..d10d6e0 100644 > > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc > > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc > > @@ -36,6 +36,7 @@ fail() { # mesg > > > > echo "Testing function tracer with profiler:" > > echo "enable function tracer" > > +enable_tracing > > echo function > current_tracer > > echo "enable profiler" > > echo 1 > function_profile_enabled > > diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_ftrace.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_ftrace.tc > > index d6f2f49..bdbd385 100644 > > --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_ftrace.tc > > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_ftrace.tc > > @@ -10,6 +10,7 @@ echo _do_fork > set_ftrace_filter > > echo 0 > events/enable > > echo > kprobe_events > > echo 'p:testprobe _do_fork' > kprobe_events > > +enable_tracing > > > > # kprobe on / ftrace off > > echo 1 > events/kprobes/testprobe/enable > -- Masami Hiramatsu