From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758503AbcJYTBS (ORCPT ); Tue, 25 Oct 2016 15:01:18 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:57974 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752973AbcJYTBQ (ORCPT ); Tue, 25 Oct 2016 15:01:16 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 55ACC615C1 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Tue, 25 Oct 2016 12:01:14 -0700 From: Stephen Boyd To: Viresh Kumar Cc: Rafael Wysocki , nm@ti.com, Viresh Kumar , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , robh@kernel.org, d-gerlach@ti.com, broonie@kernel.org Subject: Re: [PATCH V2 7/8] PM / OPP: Allow platform specific custom opp_set_rate() callbacks Message-ID: <20161025190114.GV26139@codeaurora.org> References: <4786e1f0958441b03e6d91ce21817898574c45ed.1476952750.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4786e1f0958441b03e6d91ce21817898574c45ed.1476952750.git.viresh.kumar@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/20, Viresh Kumar wrote: > The generic opp_set_rate() handler isn't sufficient for platforms with > complex DVFS. For example, some TI platforms have multiple regulators > for a CPU device. The order in which various supplies need to be > programmed is only known to the platform code and its best to leave it > to it. > > This patch implements APIs to register platform specific opp_set_rate() > callback. > > Signed-off-by: Viresh Kumar > --- Overall it looks ok, but I'd prefer set_opp instead of set_rate. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project